[ros-diffs] [jgardou] 58356: [DLLs] - hopefully put an end to this embarassing succession by adding missing linkage to msvcrt where needed. Than you ld, for getting symbols out of thin air

Author: jgardou
Date: Sat Feb 23 18:07:51 2013
New Revision: 58356

URL: http://svn.reactos.org/svn/reactos?rev=58356&view=rev
Log:
[DLLs]
 - hopefully put an end to this embarassing succession by adding missing linkage to msvcrt
where needed.
Than you ld, for getting symbols out of thin air

Modified:
    trunk/reactos/dll/directx/dinput8/CMakeLists.txt
    trunk/reactos/dll/directx/dmusic/CMakeLists.txt
    trunk/reactos/dll/directx/dplay/CMakeLists.txt
    trunk/reactos/dll/directx/msdmo/CMakeLists.txt
    trunk/reactos/dll/win32/comcat/CMakeLists.txt
    trunk/reactos/dll/win32/mcicda/CMakeLists.txt
    trunk/reactos/dll/win32/mmdrv/CMakeLists.txt
    trunk/reactos/dll/win32/msacm32/msacm32.drv/CMakeLists.txt
    trunk/reactos/dll/win32/nddeapi/CMakeLists.txt
    trunk/reactos/dll/win32/olecli32/CMakeLists.txt
    trunk/reactos/dll/win32/olepro32/CMakeLists.txt
    trunk/reactos/dll/win32/olesvr32/CMakeLists.txt
    trunk/reactos/dll/win32/rasapi32/CMakeLists.txt
    trunk/reactos/dll/win32/samsrv/CMakeLists.txt
    trunk/reactos/dll/win32/sxs/CMakeLists.txt
    trunk/reactos/dll/win32/tapi32/CMakeLists.txt
    trunk/reactos/dll/win32/updspapi/CMakeLists.txt
    trunk/reactos/dll/win32/version/CMakeLists.txt
    trunk/reactos/dll/win32/winmm/midimap/CMakeLists.txt
    trunk/reactos/dll/win32/wshtcpip/CMakeLists.txt

Modified: trunk/reactos/dll/directx/dinput8/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/dinput8/CMakeL…
==============================================================================
--- trunk/reactos/dll/directx/dinput8/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/directx/dinput8/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51
2013
@@ -21,6 +21,7 @@
     wine)
 
 add_importlibs(dinput8
+    msvcrt
     user32
     advapi32
     ole32

Modified: trunk/reactos/dll/directx/dmusic/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/dmusic/CMakeLi…
==============================================================================
--- trunk/reactos/dll/directx/dmusic/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/directx/dmusic/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -31,6 +31,7 @@
     wine)
 
 add_importlibs(dmusic
+    msvcrt
     user32
     advapi32
     ole32

Modified: trunk/reactos/dll/directx/dplay/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/dplay/CMakeLis…
==============================================================================
--- trunk/reactos/dll/directx/dplay/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/directx/dplay/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -16,12 +16,14 @@
     wine)
 
 add_importlibs(dplay
+    msvcrt
     user32
     advapi32
     ole32
     winmm
     dinput
     dplayx
+    kernel32
     ntdll)
 
 add_dependencies(dplay psdk)

Modified: trunk/reactos/dll/directx/msdmo/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/msdmo/CMakeLis…
==============================================================================
--- trunk/reactos/dll/directx/msdmo/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/directx/msdmo/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -17,6 +17,7 @@
 target_link_libraries(msdmo uuid wine mediaobj_guid)
 
 add_importlibs(msdmo
+    msvcrt
     user32
     advapi32
     ole32

Modified: trunk/reactos/dll/win32/comcat/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comcat/CMakeList…
==============================================================================
--- trunk/reactos/dll/win32/comcat/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/comcat/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -19,7 +19,7 @@
 
 target_link_libraries(comcat uuid wine)
 
-add_importlibs(comcat ole32 user32 advapi32 ntdll)
+add_importlibs(comcat msvcrt ole32 user32 advapi32 kernel32 ntdll)
 
 add_dependencies(comcat psdk)
 add_cd_file(TARGET comcat DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/mcicda/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mcicda/CMakeList…
==============================================================================
--- trunk/reactos/dll/win32/mcicda/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/mcicda/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -12,6 +12,6 @@
 
 set_module_type(mcicda win32dll)
 target_link_libraries(mcicda wine)
-add_importlibs(mcicda winmm user32 kernel32 ntdll)
+add_importlibs(mcicda msvcrt winmm user32 kernel32 ntdll)
 add_dependencies(mcicda psdk)
 add_cd_file(TARGET mcicda DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/mmdrv/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mmdrv/CMakeLists…
==============================================================================
--- trunk/reactos/dll/win32/mmdrv/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/mmdrv/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -17,6 +17,6 @@
 add_library(mmdrv SHARED ${SOURCE})
 set_module_type(mmdrv win32dll UNICODE)
 
-add_importlibs(mmdrv winmm user32 kernel32 ntdll)
+add_importlibs(mmdrv msvcrt winmm user32 kernel32 ntdll)
 add_dependencies(mmdrv psdk)
 add_cd_file(TARGET mmdrv DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/msacm32/msacm32.drv/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msacm32/msacm32.…
==============================================================================
--- trunk/reactos/dll/win32/msacm32/msacm32.drv/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/msacm32/msacm32.drv/CMakeLists.txt [iso-8859-1] Sat Feb 23
18:07:51 2013
@@ -13,6 +13,6 @@
 
 target_link_libraries(msacm32.drv wine)
 
-add_importlibs(msacm32.drv msacm32 user32 winmm advapi32 kernel32 ntdll)
+add_importlibs(msacm32.drv msvcrt msacm32 user32 winmm advapi32 kernel32 ntdll)
 add_dependencies(msacm32.drv psdk)
 add_cd_file(TARGET msacm32.drv DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/nddeapi/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/nddeapi/CMakeLis…
==============================================================================
--- trunk/reactos/dll/win32/nddeapi/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/nddeapi/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -14,6 +14,6 @@
 
 target_link_libraries(nddeapi wine)
 
-add_importlibs(nddeapi kernel32 ntdll)
+add_importlibs(nddeapi msvcrt kernel32 ntdll)
 add_dependencies(nddeapi psdk)
 add_cd_file(TARGET nddeapi DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/olecli32/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/olecli32/CMakeLi…
==============================================================================
--- trunk/reactos/dll/win32/olecli32/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/olecli32/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -11,6 +11,6 @@
 add_library(olecli32 SHARED ${SOURCE})
 set_module_type(olecli32 win32dll)
 target_link_libraries(olecli32 wine)
-add_importlibs(olecli32 ole32 gdi32 kernel32 ntdll)
+add_importlibs(olecli32 msvcrt ole32 gdi32 kernel32 ntdll)
 add_dependencies(olecli32 psdk)
 add_cd_file(TARGET olecli32 DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/olepro32/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/olepro32/CMakeLi…
==============================================================================
--- trunk/reactos/dll/win32/olepro32/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/olepro32/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -16,6 +16,7 @@
 target_link_libraries(olepro32 wine)
 
 add_importlibs(olepro32
+    msvcrt
     oleaut32
     kernel32
     ntdll)

Modified: trunk/reactos/dll/win32/olesvr32/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/olesvr32/CMakeLi…
==============================================================================
--- trunk/reactos/dll/win32/olesvr32/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/olesvr32/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -15,6 +15,6 @@
 
 target_link_libraries(olesvr32 wine)
 
-add_importlibs(olesvr32 kernel32 ntdll)
+add_importlibs(olesvr32 msvcrt kernel32 ntdll)
 add_dependencies(olesvr32 psdk)
 add_cd_file(TARGET olesvr32 DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/rasapi32/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rasapi32/CMakeLi…
==============================================================================
--- trunk/reactos/dll/win32/rasapi32/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/rasapi32/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -12,6 +12,6 @@
 add_library(rasapi32 SHARED ${SOURCE})
 set_module_type(rasapi32 win32dll)
 target_link_libraries(rasapi32 wine)
-add_importlibs(rasapi32 kernel32 ntdll)
+add_importlibs(rasapi32 msvcrt kernel32 ntdll)
 add_dependencies(rasapi32 psdk)
 add_cd_file(TARGET rasapi32 DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/samsrv/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/samsrv/CMakeList…
==============================================================================
--- trunk/reactos/dll/win32/samsrv/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/samsrv/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -25,6 +25,6 @@
 set_module_type(samsrv win32dll UNICODE)
 
 target_link_libraries(samsrv wine ${PSEH_LIB})
-add_importlibs(samsrv rpcrt4 advapi32 kernel32 ntdll)
+add_importlibs(samsrv msvcrt rpcrt4 advapi32 kernel32 ntdll)
 add_dependencies(samsrv psdk)
 add_cd_file(TARGET samsrv DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/sxs/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/sxs/CMakeLists.t…
==============================================================================
--- trunk/reactos/dll/win32/sxs/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/sxs/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -14,6 +14,6 @@
 add_library(sxs SHARED ${SOURCE})
 set_module_type(sxs win32dll)
 target_link_libraries(sxs wine)
-add_importlibs(sxs oleaut32 ole32 kernel32 ntdll)
+add_importlibs(sxs msvcrt oleaut32 ole32 kernel32 ntdll)
 add_dependencies(sxs psdk)
 add_cd_file(TARGET sxs DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/tapi32/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/tapi32/CMakeList…
==============================================================================
--- trunk/reactos/dll/win32/tapi32/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/tapi32/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -18,7 +18,7 @@
 
 target_link_libraries(tapi32 wine)
 
-add_importlibs(tapi32 advapi32 kernel32 ntdll)
+add_importlibs(tapi32 msvcrt advapi32 kernel32 ntdll)
 add_dependencies(tapi32 psdk)
 
 add_cd_file(TARGET tapi32 DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/updspapi/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/updspapi/CMakeLi…
==============================================================================
--- trunk/reactos/dll/win32/updspapi/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/updspapi/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -14,7 +14,7 @@
 
 target_link_libraries(updspapi wine)
 
-add_importlibs(updspapi setupapi kernel32 ntdll)
+add_importlibs(updspapi msvcrt setupapi kernel32 ntdll)
 add_dependencies(updspapi psdk)
 
 add_cd_file(TARGET updspapi DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/version/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/version/CMakeLis…
==============================================================================
--- trunk/reactos/dll/win32/version/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/version/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -16,7 +16,7 @@
 set_module_type(version win32dll)
 
 target_link_libraries(version wine)
-add_importlibs(version kernel32 ntdll)
+add_importlibs(version msvcrt kernel32 ntdll)
 add_dependencies(version psdk)
 add_cd_file(TARGET version DESTINATION reactos/system32 FOR all)
 

Modified: trunk/reactos/dll/win32/winmm/midimap/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/winmm/midimap/CM…
==============================================================================
--- trunk/reactos/dll/win32/winmm/midimap/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/winmm/midimap/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51
2013
@@ -10,7 +10,7 @@
 
 target_link_libraries(midimap uuid wine)
 
-add_importlibs(midimap advapi32 user32 winmm kernel32 ntdll)
+add_importlibs(midimap advapi32 user32 winmm msvcrt kernel32 ntdll)
 add_dependencies(midimap psdk)
 add_cd_file(TARGET midimap DESTINATION reactos/system32 FOR all)
 

Modified: trunk/reactos/dll/win32/wshtcpip/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wshtcpip/CMakeLi…
==============================================================================
--- trunk/reactos/dll/win32/wshtcpip/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/wshtcpip/CMakeLists.txt [iso-8859-1] Sat Feb 23 18:07:51 2013
@@ -14,6 +14,6 @@
 set_module_type(wshtcpip win32dll UNICODE)
 
 target_link_libraries(wshtcpip tdilib)
-add_importlibs(wshtcpip ws2_32 kernel32 ntdll)
+add_importlibs(wshtcpip ws2_32 msvcrt kernel32 ntdll)
 add_dependencies(wshtcpip psdk)
 add_cd_file(TARGET wshtcpip DESTINATION reactos/system32 FOR all)