[ros-diffs] [tkreuzer] 65391: [FREELDR] Remove explicit comparisons with TRUE i.e. if (BooleanValue == TRUE) -> if (BooleanValue) (and not !BooleanValue as accidentally written in the previous commit message!)...

Author: tkreuzer
Date: Thu Nov 13 11:00:41 2014
New Revision: 65391

URL: http://svn.reactos.org/svn/reactos?rev=65391&view=rev
Log:
[FREELDR]
Remove explicit comparisons with TRUE
i.e. if (BooleanValue == TRUE) -> if (BooleanValue) (and not !BooleanValue as
accidentally written in the previous commit message!)
Patch by Love Nystrom
CORE-8799

Modified:
    trunk/reactos/boot/freeldr/freeldr/cache/blocklist.c
    trunk/reactos/boot/freeldr/freeldr/cache/cache.c
    trunk/reactos/boot/freeldr/freeldr/linuxboot.c
    trunk/reactos/boot/freeldr/freeldr/reactos/registry.c

Modified: trunk/reactos/boot/freeldr/freeldr/cache/blocklist.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/cache…
==============================================================================
--- trunk/reactos/boot/freeldr/freeldr/cache/blocklist.c	[iso-8859-1] (original)
+++ trunk/reactos/boot/freeldr/freeldr/cache/blocklist.c	[iso-8859-1] Thu Nov 13 11:00:41
2014
@@ -149,7 +149,7 @@
     // that isn't forced to be in the cache and remove
     // it from the list
     CacheBlockToFree = CONTAINING_RECORD(CacheDrive->CacheBlockHead.Blink,
CACHE_BLOCK, ListEntry);
-    while (&CacheBlockToFree->ListEntry != &CacheDrive->CacheBlockHead
&& CacheBlockToFree->LockedInCache == TRUE)
+    while (&CacheBlockToFree->ListEntry != &CacheDrive->CacheBlockHead
&& CacheBlockToFree->LockedInCache)
     {
         CacheBlockToFree = CONTAINING_RECORD(CacheBlockToFree->ListEntry.Blink,
CACHE_BLOCK, ListEntry);
     }

Modified: trunk/reactos/boot/freeldr/freeldr/cache/cache.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/cache…
==============================================================================
--- trunk/reactos/boot/freeldr/freeldr/cache/cache.c	[iso-8859-1] (original)
+++ trunk/reactos/boot/freeldr/freeldr/cache/cache.c	[iso-8859-1] Thu Nov 13 11:00:41
2014
@@ -42,10 +42,10 @@
     // If we already have a cache for this drive then
     // by all means lets keep it, unless it is a removable
     // drive, in which case we'll invalidate the cache
-    if ((CacheManagerInitialized == TRUE) &&
+    if ((CacheManagerInitialized) &&
         (DriveNumber == CacheManagerDrive.DriveNumber) &&
         (DriveNumber >= 0x80) &&
-        (CacheManagerDataInvalid != TRUE))
+        (!CacheManagerDataInvalid))
     {
         return TRUE;
     }

Modified: trunk/reactos/boot/freeldr/freeldr/linuxboot.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/linux…
==============================================================================
--- trunk/reactos/boot/freeldr/freeldr/linuxboot.c	[iso-8859-1] (original)
+++ trunk/reactos/boot/freeldr/freeldr/linuxboot.c	[iso-8859-1] Thu Nov 13 11:00:41 2014
@@ -451,7 +451,7 @@
         LinuxSetupSector->LoadFlags |= LINUX_FLAG_CAN_USE_HEAP;
     }
 
-    if ((NewStyleLinuxKernel == FALSE) && (LinuxHasInitrd == TRUE))
+    if ((NewStyleLinuxKernel == FALSE) && (LinuxHasInitrd))
     {
         UiMessageBox("Error: Cannot load a ramdisk (initrd) with an old kernel
image.");
         return FALSE;

Modified: trunk/reactos/boot/freeldr/freeldr/reactos/registry.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/react…
==============================================================================
--- trunk/reactos/boot/freeldr/freeldr/reactos/registry.c	[iso-8859-1] (original)
+++ trunk/reactos/boot/freeldr/freeldr/reactos/registry.c	[iso-8859-1] Thu Nov 13 11:00:41
2014
@@ -119,7 +119,7 @@
         return Error;
     }
 
-    CurrentSet = (LastKnownGood == TRUE) ? LastKnownGoodSet : DefaultSet;
+    CurrentSet = (LastKnownGood) ? LastKnownGoodSet : DefaultSet;
     wcscpy(ControlSetKeyName, L"ControlSet");
     switch(CurrentSet)
     {