[ros-diffs] [sginsberg] 38273: - Re-enable some Winetests now that Cm sucks less - Add missing ROS-HACK tag

Author: sginsberg
Date: Mon Dec 22 12:48:06 2008
New Revision: 38273

URL: http://svn.reactos.org/svn/reactos?rev=38273&view=rev
Log:
- Re-enable some Winetests now that Cm sucks less
- Add missing ROS-HACK tag

Removed:
    trunk/rostests/winetests/msi/roshack.diff
Modified:
    trunk/rostests/winetests/comctl32/mru.c
    trunk/rostests/winetests/msi/install.c
    trunk/rostests/winetests/msi/msi.c
    trunk/rostests/winetests/shell32/roshack.diff
    trunk/rostests/winetests/shell32/systray.c

Modified: trunk/rostests/winetests/comctl32/mru.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/comctl32/mru.c?…
==============================================================================
--- trunk/rostests/winetests/comctl32/mru.c [iso-8859-1] (original)
+++ trunk/rostests/winetests/comctl32/mru.c [iso-8859-1] Mon Dec 22 12:48:06 2008
@@ -418,10 +418,6 @@
 {
     hComctl32 = GetModuleHandleA("comctl32.dll");
 
-    /* The registry usage here crashes the system because of broken Cm -- remove this
when Cm gets fixed */
-    skip("ROS-HACK: Skipping mru tests -- Cm is broken\n");
-    return;
-
     delete_reg_entries();
     if (!create_reg_entries())
         return;

Modified: trunk/rostests/winetests/msi/install.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/msi/install.c?r…
==============================================================================
--- trunk/rostests/winetests/msi/install.c [iso-8859-1] (original)
+++ trunk/rostests/winetests/msi/install.c [iso-8859-1] Mon Dec 22 12:48:06 2008
@@ -4561,9 +4561,6 @@
 {
     DWORD len;
     char temp_path[MAX_PATH], prev_path[MAX_PATH];
-    
-    skip("ROS-HACK: Skipping install tests -- Cm sucks\n");
-    return;
 
     init_functionpointers();
 

Modified: trunk/rostests/winetests/msi/msi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/msi/msi.c?rev=3…
==============================================================================
--- trunk/rostests/winetests/msi/msi.c [iso-8859-1] (original)
+++ trunk/rostests/winetests/msi/msi.c [iso-8859-1] Mon Dec 22 12:48:06 2008
@@ -6903,8 +6903,6 @@
 
 START_TEST(msi)
 {
-    skip("ROS-HACK: Skipping msi tests -- Cm sucks\n");
-    return;
 
     init_functionpointers();
 

Removed: trunk/rostests/winetests/msi/roshack.diff
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/msi/roshack.dif…
==============================================================================
--- trunk/rostests/winetests/msi/roshack.diff [iso-8859-1] (original)
+++ trunk/rostests/winetests/msi/roshack.diff (removed)
@@ -1,28 +1,0 @@
-Index: install.c
-===================================================================
---- install.c	(revision 38229)
-+++ install.c	(working copy)
-@@ -4561,6 +4561,9 @@
- {
-     DWORD len;
-     char temp_path[MAX_PATH], prev_path[MAX_PATH];
-+    
-+    skip("ROS-HACK: Skipping install tests -- Cm sucks\n");
-+    return;
- 
-     init_functionpointers();
- 
-Index: msi.c
-===================================================================
---- msi.c	(revision 38229)
-+++ msi.c	(working copy)
-@@ -6903,6 +6903,9 @@
- 
- START_TEST(msi)
- {
-+    skip("ROS-HACK: Skipping msi tests -- Cm sucks\n");
-+    return;
-+
-     init_functionpointers();
- 
-     test_usefeature();

Modified: trunk/rostests/winetests/shell32/roshack.diff
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/shell32/roshack…
==============================================================================
--- trunk/rostests/winetests/shell32/roshack.diff [iso-8859-1] (original)
+++ trunk/rostests/winetests/shell32/roshack.diff [iso-8859-1] Mon Dec 22 12:48:06 2008
@@ -19,7 +19,7 @@
      RECT rc;
      HMODULE huser32, hshell32;
  
-+    skip("Skipping systray tests\n");
++    skip("ROS-HACK: Skipping systray tests\n");
 +    return;
 +
      hshell32 = GetModuleHandleA("shell32.dll");

Modified: trunk/rostests/winetests/shell32/systray.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/shell32/systray…
==============================================================================
--- trunk/rostests/winetests/shell32/systray.c [iso-8859-1] (original)
+++ trunk/rostests/winetests/shell32/systray.c [iso-8859-1] Mon Dec 22 12:48:06 2008
@@ -138,7 +138,7 @@
     RECT rc;
     HMODULE huser32, hshell32;
 
-    skip("Skipping systray tests\n");
+    skip("ROS-HACK: Skipping systray tests\n");
     return;
 
     hshell32 = GetModuleHandleA("shell32.dll");