[ros-diffs] [jgardou] 64526: [CMAKE] - Introduce the kerneldll module type (like kernelmodedriver, but ending with .dll) and use it in various places - vfatx.dll whould in fact be a native DLL

Author: jgardou
Date: Sat Oct  4 20:25:57 2014
New Revision: 64526

URL: http://svn.reactos.org/svn/reactos?rev=64526&view=rev
Log:
[CMAKE]
 - Introduce the kerneldll module type (like kernelmodedriver, but ending with .dll) and
use it in various places
 - vfatx.dll whould in fact be a native DLL

Modified:
    trunk/reactos/cmake/CMakeMacros.cmake
    trunk/reactos/dll/win32/ufatx/CMakeLists.txt
    trunk/reactos/drivers/base/bootvid/CMakeLists.txt
    trunk/reactos/drivers/base/kdrosdbg/CMakeLists.txt
    trunk/reactos/drivers/hid/hidclass/CMakeLists.txt
    trunk/reactos/drivers/ksfilter/ks/CMakeLists.txt
    trunk/reactos/hal/halx86/CMakeLists.txt
    trunk/reactos/win32ss/drivers/displays/framebuf/CMakeLists.txt
    trunk/reactos/win32ss/drivers/displays/vga/CMakeLists.txt
    trunk/reactos/win32ss/drivers/font/ftfd/CMakeLists.txt

Modified: trunk/reactos/cmake/CMakeMacros.cmake
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/CMakeMacros.cmake?re…
==============================================================================
--- trunk/reactos/cmake/CMakeMacros.cmake	[iso-8859-1] (original)
+++ trunk/reactos/cmake/CMakeMacros.cmake	[iso-8859-1] Sat Oct  4 20:25:57 2014
@@ -518,7 +518,8 @@
 
     # Set subsystem. Also take this as an occasion
     # to error out if someone gave a non existing type
-    if((${TYPE} STREQUAL nativecui) OR (${TYPE} STREQUAL nativedll) OR (${TYPE} STREQUAL
kernelmodedriver) OR (${TYPE} STREQUAL wdmdriver))
+    if((${TYPE} STREQUAL nativecui) OR (${TYPE} STREQUAL nativedll) 
+            OR (${TYPE} STREQUAL kernelmodedriver) OR (${TYPE} STREQUAL wdmdriver) OR
(${TYPE} STREQUAL kerneldll))
         set(__subsystem native)
     elseif(${TYPE} STREQUAL win32cui)
         set(__subsystem console)
@@ -617,14 +618,16 @@
         else()
             message(STATUS "${MODULE} has no base address")
         endif()
-    elseif((${TYPE} STREQUAL kernelmodedriver) OR (${TYPE} STREQUAL wdmdriver))
+    elseif((${TYPE} STREQUAL kernelmodedriver) OR (${TYPE} STREQUAL wdmdriver) OR
(${TYPE} STREQUAL kernelmodedll))
         set_image_base(${MODULE} 0x00010000)
     endif()
 
     # Now do some stuff which is specific to each type
-    if((${TYPE} STREQUAL kernelmodedriver) OR (${TYPE} STREQUAL wdmdriver))
+    if((${TYPE} STREQUAL kernelmodedriver) OR (${TYPE} STREQUAL wdmdriver) OR (${TYPE}
STREQUAL kernelmodedll))
         add_dependencies(${MODULE} bugcodes)
-        set_target_properties(${MODULE} PROPERTIES SUFFIX ".sys")
+        if((${TYPE} STREQUAL kernelmodedriver) OR (${TYPE} STREQUAL wdmdriver))
+            set_target_properties(${MODULE} PROPERTIES SUFFIX ".sys")
+        endif()
     endif()
 
     if(${TYPE} STREQUAL win32ocx)

Modified: trunk/reactos/dll/win32/ufatx/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ufatx/CMakeLists…
==============================================================================
--- trunk/reactos/dll/win32/ufatx/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/win32/ufatx/CMakeLists.txt	[iso-8859-1] Sat Oct  4 20:25:57 2014
@@ -7,9 +7,9 @@
 
 add_library(ufatx SHARED ${SOURCE})
 
-set_module_type(ufatx win32dll ENTRYPOINT 0 )
+target_link_libraries(ufatx vfatxlib)
+set_module_type(ufatx nativedll ENTRYPOINT 0 )
 
-target_link_libraries(ufatx vfatxlib)
 add_importlibs(ufatx ntdll)
 
 add_dependencies(ufatx psdk)

Modified: trunk/reactos/drivers/base/bootvid/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/CMake…
==============================================================================
--- trunk/reactos/drivers/base/bootvid/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/base/bootvid/CMakeLists.txt	[iso-8859-1] Sat Oct  4 20:25:57
2014
@@ -19,12 +19,10 @@
     bootvid.rc
     ${CMAKE_CURRENT_BINARY_DIR}/bootvid.def)
 
-set_entrypoint(bootvid 0)
-set_subsystem(bootvid native)
-set_image_base(bootvid 0x00010000)
+set_module_type(bootvid kerneldll ENTRYPOINT 0)
 
 add_importlibs(bootvid ntoskrnl hal)
 add_pch(bootvid precomp.h SOURCE)
-add_dependencies(bootvid psdk bugcodes)
+add_dependencies(bootvid psdk)
 add_cd_file(TARGET bootvid DESTINATION reactos/system32 NO_CAB FOR all)
 

Modified: trunk/reactos/drivers/base/kdrosdbg/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kdrosdbg/CMak…
==============================================================================
--- trunk/reactos/drivers/base/kdrosdbg/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/base/kdrosdbg/CMakeLists.txt	[iso-8859-1] Sat Oct  4 20:25:57
2014
@@ -8,12 +8,10 @@
 
 add_library(kdcom SHARED ${SOURCE})
 
-set_entrypoint(kdcom 0)
-set_subsystem(kdcom native)
-set_image_base(kdcom 0x00010000)
+set_module_type(kdcom kerneldll ENTRYPOINT 0)
 
 add_importlibs(kdcom ntoskrnl hal)
 target_link_libraries(kdcom cportlib)
-add_dependencies(kdcom psdk bugcodes)
+add_dependencies(kdcom psdk)
 
 add_cd_file(TARGET kdcom DESTINATION reactos/system32 NO_CAB FOR all)

Modified: trunk/reactos/drivers/hid/hidclass/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/hid/hidclass/CMake…
==============================================================================
--- trunk/reactos/drivers/hid/hidclass/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/hid/hidclass/CMakeLists.txt	[iso-8859-1] Sat Oct  4 20:25:57
2014
@@ -13,12 +13,8 @@
     hidclass.rc
     ${CMAKE_CURRENT_BINARY_DIR}/hidclass.def)
 
-set_entrypoint(hidclass 0)
-set_subsystem(hidclass native)
-set_target_properties(hidclass PROPERTIES SUFFIX ".sys")
-
+set_module_type(hidclass kernelmodedriver ENTRYPOINT 0)
 
 add_importlibs(hidclass ntoskrnl hidparse hal)
-add_dependencies(hidclass bugcodes)
 add_pch(hidclass precomp.h SOURCE)
 add_cd_file(TARGET hidclass DESTINATION reactos/system32/drivers NO_CAB FOR all)

Modified: trunk/reactos/drivers/ksfilter/ks/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/CMakeL…
==============================================================================
--- trunk/reactos/drivers/ksfilter/ks/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/ksfilter/ks/CMakeLists.txt	[iso-8859-1] Sat Oct  4 20:25:57
2014
@@ -40,15 +40,11 @@
     ks.rc
     ${CMAKE_CURRENT_BINARY_DIR}/ks.def)
 
-set_target_properties(ks PROPERTIES SUFFIX ".sys")
-
-set_entrypoint(ks 0)
-set_subsystem(ks native)
-set_image_base(ks 0x00010000)
+set_module_type(ks kernelmodedriver ENTRYPOINT 0)
 
 target_link_libraries(ks ${PSEH_LIB})
 add_pch(ks precomp.h SOURCE)
 add_importlibs(ks ntoskrnl hal)
-add_dependencies(ks psdk bugcodes)
+add_dependencies(ks psdk)
 add_cd_file(TARGET ks DESTINATION reactos/system32/drivers FOR all)
 

Modified: trunk/reactos/hal/halx86/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/CMakeLists.txt?…
==============================================================================
--- trunk/reactos/hal/halx86/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/CMakeLists.txt	[iso-8859-1] Sat Oct  4 20:25:57 2014
@@ -34,10 +34,8 @@
     target_link_libraries(${_halname} libcntpr)
     add_importlibs(${_halname} ntoskrnl)
     #add_pch(${_halname} include/hal.h)
-    add_dependencies(${_halname} psdk bugcodes asm)
-    set_entrypoint(${_halname} HalInitSystem 8)
-    set_subsystem(${_halname} native)
-    set_image_base(${_halname} 0x00010000)
+    add_dependencies(${_halname} psdk asm)
+    set_module_type(${_halname} kerneldll ENTRYPOINT HalInitSystem 8)
     add_cd_file(TARGET ${_halname} DESTINATION reactos/system32 NO_CAB FOR all)
     if(MSVC)
         add_target_link_flags(${_halname} "/ignore:4216 /ignore:4078")

Modified: trunk/reactos/win32ss/drivers/displays/framebuf/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f…
==============================================================================
--- trunk/reactos/win32ss/drivers/displays/framebuf/CMakeLists.txt	[iso-8859-1]
(original)
+++ trunk/reactos/win32ss/drivers/displays/framebuf/CMakeLists.txt	[iso-8859-1] Sat Oct  4
20:25:57 2014
@@ -14,11 +14,10 @@
     framebuf.rc
     ${CMAKE_CURRENT_BINARY_DIR}/framebuf.def)
 
+set_module_type(framebuf kerneldll ENTRYPOINT DrvEnableDriver 12)
+
 add_pch(framebuf framebuf.h SOURCE)
-set_entrypoint(framebuf DrvEnableDriver 12)
-set_subsystem(framebuf native)
-set_image_base(framebuf 0x00010000)
 target_link_libraries(framebuf libcntpr)
 add_importlibs(framebuf win32k)
-add_dependencies(framebuf psdk bugcodes)
+add_dependencies(framebuf psdk)
 add_cd_file(TARGET framebuf DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/win32ss/drivers/displays/vga/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/v…
==============================================================================
--- trunk/reactos/win32ss/drivers/displays/vga/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/win32ss/drivers/displays/vga/CMakeLists.txt	[iso-8859-1] Sat Oct  4
20:25:57 2014
@@ -19,11 +19,10 @@
     vgaddi.rc
     ${CMAKE_CURRENT_BINARY_DIR}/vgaddi.def)
 
-set_entrypoint(vgaddi DrvEnableDriver 12)
-set_subsystem(vgaddi native)
-set_image_base(vgaddi 0x00010000)
+set_module_type(vgaddi kerneldll ENTRYPOINT DrvEnableDriver 12)
+
 add_pch(vgaddi vgaddi.h SOURCE)
 add_importlibs(vgaddi win32k)
 target_link_libraries(vgaddi libcntpr)
-add_dependencies(vgaddi psdk bugcodes)
+add_dependencies(vgaddi psdk)
 add_cd_file(TARGET vgaddi DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/win32ss/drivers/font/ftfd/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/font/ftfd/…
==============================================================================
--- trunk/reactos/win32ss/drivers/font/ftfd/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/win32ss/drivers/font/ftfd/CMakeLists.txt	[iso-8859-1] Sat Oct  4
20:25:57 2014
@@ -16,9 +16,7 @@
     freetype.rc
     ${CMAKE_CURRENT_BINARY_DIR}/ftfd.def)
 
-set_entrypoint(ftfd FtfdEnableDriver 12)
-set_subsystem(ftfd native)
-set_image_base(ftfd 0x00010000)
+set_module_type(ftfd kerneldll ENTRYPOINT FtfdEnableDriver 12)
 
 target_link_libraries(ftfd
     freetype