[ros-diffs] [ion] 23195: - Add some final missing annotations to kill.c [AUDIT] - Most of the functions are documented at length in Windows Internals II and at a more high-level fashion in Windows Internals 4 and were based on that information. Undocumented routines were based of the operations done in the documented ones (for example, freeing buffers that we know were allocated, etc).

Author: ion
Date: Thu Jul 20 20:30:07 2006
New Revision: 23195

URL: http://svn.reactos.org/svn/reactos?rev=23195&view=rev
Log:
- Add some final missing annotations to kill.c
[AUDIT]
 - Most of the functions are documented at length in Windows Internals II and at a more
high-level fashion in Windows Internals 4 and were based on that information. Undocumented
routines were based of the operations done in the documented ones (for example, freeing
buffers that we know were allocated, etc).

Modified:
    trunk/reactos/ntoskrnl/KrnlFun.c
    trunk/reactos/ntoskrnl/ps/kill.c   (contents, props changed)

Modified: trunk/reactos/ntoskrnl/KrnlFun.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/KrnlFun.c?rev=231…
==============================================================================
--- trunk/reactos/ntoskrnl/KrnlFun.c (original)
+++ trunk/reactos/ntoskrnl/KrnlFun.c Thu Jul 20 20:30:07 2006
@@ -28,7 +28,6 @@
 //  - Use Process/Thread Rundown.
 //  - Use Process Pushlock Locks.
 //  - Use Safe Referencing where needed.
-//  - Use Guarded Mutex instead of Fast Mutex for Active Process Locks.
 //  - Use Security Locks in security.c
 //  - Figure out why processes don't die.
 //  - Generate process cookie for user-more thread.

Modified: trunk/reactos/ntoskrnl/ps/kill.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=231…
==============================================================================
--- trunk/reactos/ntoskrnl/ps/kill.c (original)
+++ trunk/reactos/ntoskrnl/ps/kill.c Thu Jul 20 20:30:07 2006
@@ -90,7 +90,7 @@
 
 VOID
 NTAPI
-PspReapRoutine(PVOID Context)
+PspReapRoutine(IN PVOID Context)
 {
     PLIST_ENTRY *ListAddr;
     PLIST_ENTRY NextEntry;
@@ -130,7 +130,7 @@
 
 VOID
 NTAPI
-PspDeleteProcess(PVOID ObjectBody)
+PspDeleteProcess(IN PVOID ObjectBody)
 {
     PEPROCESS Process = (PEPROCESS)ObjectBody;
     KAPC_STATE ApcState;
@@ -260,7 +260,7 @@
 
 VOID
 NTAPI
-PspDeleteThread(PVOID ObjectBody)
+PspDeleteThread(IN PVOID ObjectBody)
 {
     PETHREAD Thread = (PETHREAD)ObjectBody;
     PEPROCESS Process = Thread->ThreadsProcess;
@@ -315,7 +315,7 @@
  */
 VOID
 NTAPI
-PspExitThread(NTSTATUS ExitStatus)
+PspExitThread(IN NTSTATUS ExitStatus)
 {
     CLIENT_DIED_MSG TerminationMsg;
     NTSTATUS Status;
@@ -726,11 +726,11 @@
 
 VOID
 NTAPI
-PsExitSpecialApc(PKAPC Apc,
-                 PKNORMAL_ROUTINE* NormalRoutine,
-                 PVOID* NormalContext,
-                 PVOID* SystemArgument1,
-                 PVOID* SystemArguemnt2)
+PsExitSpecialApc(IN PKAPC Apc,
+                 IN OUT PKNORMAL_ROUTINE* NormalRoutine,
+                 IN OUT PVOID* NormalContext,
+                 IN OUT PVOID* SystemArgument1,
+                 IN OUT PVOID* SystemArguemnt2)
 {
     NTSTATUS Status;
     PAGED_CODE();
@@ -749,9 +749,9 @@
 
 VOID
 NTAPI
-PspExitNormalApc(PVOID NormalContext,
-                 PVOID SystemArgument1,
-                 PVOID SystemArgument2)
+PspExitNormalApc(IN PVOID NormalContext,
+                 IN PVOID SystemArgument1,
+                 IN PVOID SystemArgument2)
 {
     PKAPC Apc = (PKAPC)SystemArgument1;
     PETHREAD Thread = PsGetCurrentThread();
@@ -789,9 +789,9 @@
  */
 NTSTATUS
 NTAPI
-PspTerminateThreadByPointer(PETHREAD Thread,
-                            NTSTATUS ExitStatus,
-                            BOOLEAN bSelf)
+PspTerminateThreadByPointer(IN PETHREAD Thread,
+                            IN NTSTATUS ExitStatus,
+                            IN BOOLEAN bSelf)
 {
     PKAPC Apc;
     NTSTATUS Status = STATUS_SUCCESS;
@@ -932,7 +932,7 @@
  */
 NTSTATUS
 NTAPI
-PsTerminateSystemThread(NTSTATUS ExitStatus)
+PsTerminateSystemThread(IN NTSTATUS ExitStatus)
 {
     PETHREAD Thread = PsGetCurrentThread();
 

Propchange: trunk/reactos/ntoskrnl/ps/kill.c
------------------------------------------------------------------------------
--- svn:needs-lock (original)
+++ svn:needs-lock (removed)
@@ -1,1 +1,0 @@
-*