[ros-diffs] [ion] 57256: [NTOSKRNL]: Fix two NtAccess function prototypes (NO-OP, not implemented/used) [NTOSKRNL]: Add missing call to ObValidateAccessMask (NO-OP, always returns TRUE).

Author: ion
Date: Sun Sep  9 16:59:23 2012
New Revision: 57256

URL: http://svn.reactos.org/svn/reactos?rev=57256&view=rev
Log:
[NTOSKRNL]: Fix two NtAccess function prototypes (NO-OP, not implemented/used)
[NTOSKRNL]: Add missing call to ObValidateAccessMask (NO-OP, always returns TRUE).

Modified:
    trunk/reactos/include/ndk/sefuncs.h
    trunk/reactos/ntoskrnl/ex/event.c
    trunk/reactos/ntoskrnl/ob/obhandle.c
    trunk/reactos/ntoskrnl/se/semgr.c

Modified: trunk/reactos/include/ndk/sefuncs.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/sefuncs.h?rev=…
==============================================================================
--- trunk/reactos/include/ndk/sefuncs.h [iso-8859-1] (original)
+++ trunk/reactos/include/ndk/sefuncs.h [iso-8859-1] Sun Sep  9 16:59:23 2012
@@ -109,7 +109,7 @@
     IN ULONG ObjectTypeLength,
     IN PGENERIC_MAPPING GenericMapping,
     IN PPRIVILEGE_SET PrivilegeSet,
-    IN ULONG PrivilegeSetLength,
+    IN OUT PULONG PrivilegeSetLength,
     OUT PACCESS_MASK GrantedAccess,
     OUT PNTSTATUS AccessStatus
 );
@@ -125,7 +125,7 @@
     IN ULONG ObjectTypeLength,
     IN PGENERIC_MAPPING GenericMapping,
     IN PPRIVILEGE_SET PrivilegeSet,
-    IN ULONG PrivilegeSetLength,
+    IN OUT PULONG PrivilegeSetLength,
     OUT PACCESS_MASK GrantedAccess,
     OUT PNTSTATUS AccessStatus
 );

Modified: trunk/reactos/ntoskrnl/ex/event.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/event.c?rev=57…
==============================================================================
--- trunk/reactos/ntoskrnl/ex/event.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ex/event.c [iso-8859-1] Sun Sep  9 16:59:23 2012
@@ -140,7 +140,7 @@
                             (PVOID*)&Event);
 
     /* Check for Success */
-    if(NT_SUCCESS(Status))
+    if (NT_SUCCESS(Status))
     {
         /* Initalize the Event */
         KeInitializeEvent(Event,
@@ -156,7 +156,7 @@
                                  &hEvent);
 
         /* Check for success */
-        if(NT_SUCCESS(Status))
+        if (NT_SUCCESS(Status))
         {
             /* Enter SEH for return */
             _SEH2_TRY

Modified: trunk/reactos/ntoskrnl/ob/obhandle.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev…
==============================================================================
--- trunk/reactos/ntoskrnl/ob/obhandle.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ob/obhandle.c [iso-8859-1] Sun Sep  9 16:59:23 2012
@@ -2490,6 +2490,15 @@
         PassedAccessState->SecurityDescriptor =
             TempBuffer->ObjectCreateInfo.SecurityDescriptor;
     }
+    
+    /* Validate the access mask */
+    Status = ObpValidateAccessMask(PassedAccessState);
+    if (!NT_SUCCESS(Status))
+    {
+        /* Cleanup after lookup */
+        ObpReleaseLookupContext(&TempBuffer->LookupContext);
+        goto Cleanup;
+    }
 
     /* Now do the lookup */
     Status = ObpLookupObjectName(TempBuffer->ObjectCreateInfo.RootDirectory,

Modified: trunk/reactos/ntoskrnl/se/semgr.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/semgr.c?rev=57…
==============================================================================
--- trunk/reactos/ntoskrnl/se/semgr.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/se/semgr.c [iso-8859-1] Sun Sep  9 16:59:23 2012
@@ -1072,7 +1072,7 @@
                     IN ULONG ObjectTypeLength,
                     IN PGENERIC_MAPPING GenericMapping,
                     IN PPRIVILEGE_SET PrivilegeSet,
-                    IN ULONG PrivilegeSetLength,
+                    IN OUT PULONG PrivilegeSetLength,
                     OUT PACCESS_MASK GrantedAccess,
                     OUT PNTSTATUS AccessStatus)
 {
@@ -1113,7 +1113,7 @@
                               IN ULONG ObjectTypeLength,
                               IN PGENERIC_MAPPING GenericMapping,
                               IN PPRIVILEGE_SET PrivilegeSet,
-                              IN ULONG PrivilegeSetLength,
+                              IN OUT PULONG PrivilegeSetLength,
                               OUT PACCESS_MASK GrantedAccess,
                               OUT PNTSTATUS AccessStatus)
 {