[ros-diffs] [reactos] 01/01: [CMAKE] msvc.cmake: Enable C4090 warning as error

[Serge Gautherie]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0c5fc49f828a0dff16cbe…

commit 0c5fc49f828a0dff16cbe127d54d5e1ad22c40c9
Author:     Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr>
AuthorDate: Mon Apr 11 21:07:19 2022 +0200
Commit:     Victor Perevertkin <victor(a)perevertkin.ru>
CommitDate: Tue Apr 12 02:08:45 2022 +0300

    [CMAKE] msvc.cmake: Enable C4090 warning as error
    
    C4090: different 'modifier' qualifiers
    
    Follow-up to 42d2d5e (0.4.14-dev-847) and 41bc57d (0.4.15-dev-2952),
    which silenced affected modules.
    CORE-7538
---
 sdk/cmake/msvc.cmake | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sdk/cmake/msvc.cmake b/sdk/cmake/msvc.cmake
index 9f6d4544003..af021129b22 100644
--- a/sdk/cmake/msvc.cmake
+++ b/sdk/cmake/msvc.cmake
@@ -114,7 +114,7 @@ else()
 # - C4022: pointer type mismatch for parameter
 # - C4028: formal parameter different from declaration
 # - C4047: different level of indirection
-# - TODO: C4090: different 'modifier' qualifiers (for C programs only;
+# - C4090: different 'modifier' qualifiers (for C programs only;
 #          for C++ programs, the compiler error C2440 is issued)
 # - C4098: void function returning a value
 # - C4113: parameter lists differ
@@ -130,7 +130,7 @@ else()
 # - C4700: uninitialized variable usage
 # - C4715: 'function': not all control paths return a value
 # - C4716: function must return a value
-add_compile_options(/we4013 /we4020 /we4022 /we4028 /we4047 /we4098 /we4113 /we4129
/we4133 /we4163 /we4229 /we4311 /we4312 /we4313 /we4477 /we4603 /we4700 /we4715 /we4716)
+add_compile_options(/we4013 /we4020 /we4022 /we4028 /we4047 /we4090 /we4098 /we4113
/we4129 /we4133 /we4163 /we4229 /we4311 /we4312 /we4313 /we4477 /we4603 /we4700 /we4715
/we4716)
 
 # - C4101: unreferenced local variable
 # - C4189: local variable initialized but not referenced