[ros-diffs] 01/01: [SHELL32] CShellItem: Fix return value of Compare method

[Giannis Adamopoulos]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=af97de39a2bc3509286565...

commit af97de39a2bc3509286565f670a9feef723deaf3
Author:     Giannis Adamopoulos [e-mail]
AuthorDate: Tue Feb 20 14:36:31 2018 +0200
Commit:     Giannis Adamopoulos [e-mail]
CommitDate: Tue Feb 20 14:36:31 2018 +0200

[SHELL32] CShellItem: Fix return value of Compare method
---
 dll/win32/shell32/CShellItem.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/dll/win32/shell32/CShellItem.cpp b/dll/win32/shell32/CShellItem.cpp
index 1e06c8cff8..5ef965de47 100644
--- a/dll/win32/shell32/CShellItem.cpp
+++ b/dll/win32/shell32/CShellItem.cpp
@@ -199,9 +199,13 @@ HRESULT WINAPI CShellItem::Compare(IShellItem *oth, SICHINTF hint, int *piOrder)
         }
     }

-    if (SUCCEEDED(hr))
+    if(FAILED(hr))
+        return hr;
+
+    if(*piOrder)
+        return S_FALSE;
+    else
         return S_OK;
-    return hr;
 }

HRESULT WINAPI CShellItem::GetClassID(CLSID *pClassID)