[ros-diffs] [gschneider] 38607: - Fix a coordinate problem that occurred with alphablend in DrawIconEx (32bpp mode only) - Welcome back mixer icon in 32bpp mode! - Note for other invisible icons in that mode: 32bpp icon variants are most likely missing in the *.ico file; ReactOS image bpp conversion functions currently clear the alpha channel -> invisibility - Update function names in debug prints, remove duplicate code, slightly improve code readability

Author: gschneider
Date: Tue Jan  6 11:12:07 2009
New Revision: 38607

URL: http://svn.reactos.org/svn/reactos?rev=38607&view=rev
Log:
- Fix a coordinate problem that occurred with alphablend in DrawIconEx (32bpp mode only) 
- Welcome back mixer icon in 32bpp mode!
- Note for other invisible icons in that mode: 32bpp icon variants are most likely missing in the *.ico file; ReactOS image bpp conversion functions currently clear the alpha channel -> invisibility
- Update function names in debug prints, remove duplicate code, slightly improve code readability

Modified:
    trunk/reactos/subsystems/win32/win32k/ntuser/cursoricon.c

Modified: trunk/reactos/subsystems/win32/win32k/ntuser/cursoricon.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntu...
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/cursoricon.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/cursoricon.c [iso-8859-1] Tue Jan  6 11:12:07 2009
@@ -1569,7 +1569,7 @@
       BitmapObj = BITMAPOBJ_LockBitmap(hbmOff);
       if (BitmapObj == NULL)
       {
-          DPRINT1("GDIOBJ_LockObj() failed!\n");
+          DPRINT1("BITMAPOBJ_LockBitmap() failed!\n");
           goto cleanup;
       }
       BITMAP_GetObject(BitmapObj, sizeof(BITMAP), (PVOID)&bm);
@@ -1591,7 +1591,7 @@
           hOldOffBrush = NtGdiSelectBrush(hdcOff, hbrFlickerFreeDraw);
           if (!hOldOffBrush)
           {
-             DPRINT1("NtGdiSelectBitmap() failed!\n");
+             DPRINT1("NtGdiSelectBrush() failed!\n");
              goto cleanup;
           }

@@ -1622,21 +1622,18 @@
          goto cleanup;
       }

-      DoStretchBlt(hdcOff, (DoFlickerFree ? 0 : xLeft),
-                   (DoFlickerFree ? 0 : yTop), cxWidth, cyHeight, hdcMem,
-                   0, 0, IconSize.cx, IconSize.cy,
-                   ((diFlags & DI_IMAGE) ? SRCAND : SRCCOPY), FALSE);
-
-      if (!hbmColor && (bmpMask.bmHeight == 2 * bmpMask.bmWidth)
-         && (diFlags & DI_IMAGE))
-      {
-         DoStretchBlt(hdcOff, (DoFlickerFree ? 0 : xLeft),
-                      (DoFlickerFree ? 0 : yTop), cxWidth, cyHeight, hdcMem,
-                      0, IconSize.cy, IconSize.cx, IconSize.cy, SRCINVERT,
-                      FALSE);
-
-         diFlags &= ~DI_IMAGE;
-      }
+      DoStretchBlt(hdcOff,
+                   (DoFlickerFree || bAlpha ? 0 : xLeft),
+                   (DoFlickerFree || bAlpha ? 0 : yTop), 
+                   cxWidth,
+                   cyHeight,
+                   hdcMem,
+                   0,
+                   0,
+                   IconSize.cx,
+                   IconSize.cy,
+                   ((diFlags & DI_IMAGE) ? SRCAND : SRCCOPY),
+                   FALSE);

NtGdiSelectBitmap(hdcMem, hOldMem);
    }
@@ -1645,9 +1642,16 @@
    {
       hOldMem = NtGdiSelectBitmap(hdcMem, (hbmColor ? hbmColor : hbmMask));

-      DoStretchBlt(hdcOff, (DoFlickerFree ? 0 : xLeft),
-                   (DoFlickerFree ? 0 : yTop), cxWidth, cyHeight, hdcMem,
-                   0, (hbmColor ? 0 : IconSize.cy), IconSize.cx, IconSize.cy,
+      DoStretchBlt(hdcOff, 
+                   (DoFlickerFree || bAlpha ? 0 : xLeft),
+                   (DoFlickerFree || bAlpha ? 0 : yTop),
+                   cxWidth,
+                   cyHeight,
+                   hdcMem,
+                   0,
+                   (hbmColor ? 0 : IconSize.cy),
+                   IconSize.cx,
+                   IconSize.cy,
                    ((diFlags & DI_MASK) ? SRCINVERT : SRCCOPY),
                    NULL != hbmColor);

@@ -1659,7 +1663,7 @@
         BITMAP bm;
         BITMAPOBJ *BitmapObj = NULL;
         PBYTE pBits = NULL;
-        BLENDFUNCTION  BlendFunc;
+        BLENDFUNCTION BlendFunc;
         DWORD Pixel;
         BYTE Red, Green, Blue, Alpha;
         DWORD Count = 0;
@@ -1668,7 +1672,7 @@
         BitmapObj = BITMAPOBJ_LockBitmap(hbmOff);
         if (BitmapObj == NULL)
         {
-            DPRINT1("GDIOBJ_LockObj() failed!\n");
+            DPRINT1("BITMAPOBJ_LockBitmap() failed!\n");
             goto cleanup;
         }
         BITMAP_GetObject(BitmapObj, sizeof(BITMAP), (PVOID)&bm);