[ros-diffs] [reactos] 01/01: [SHELL32] Strip leftover in CDefView::FillFileMenu() (#5330)

[Joachim Henze]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d3164a0f557bdc2cc9dfd…

commit d3164a0f557bdc2cc9dfd86612131f6cf180d462
Author:     Joachim Henze <joachim.henze(a)reactos.org>
AuthorDate: Sun Jun 11 20:53:25 2023 +0200
Commit:     GitHub <noreply(a)github.com>
CommitDate: Sun Jun 11 20:53:25 2023 +0200

    [SHELL32] Strip leftover in CDefView::FillFileMenu() (#5330)
    
    In 0.4.14-dev-955-g 1cf564c25f532c32f9fae891f17a70e62d5c1c14
    Katayama experimented with populating explorers file-menu when no object is selected.
    
    Later we found out, that none of the new entries introduced by that commit really
    made sense and even created duplicates. So the commit was reverted by
    0.4.15-dev-6039-g 0fa4edebd9125b9ca7a4256edbea7675e2152c7e 'Revert
CDefView::FillFileMenu (#5278)' CORE-18429
    
    But it seems that not all parts were properly reverted back then,
    maybe because 6 lines of new code were written between the two lines in the meantime.
---
 dll/win32/shell32/CDefView.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dll/win32/shell32/CDefView.cpp b/dll/win32/shell32/CDefView.cpp
index 880afa6e457..ebcfa767090 100644
--- a/dll/win32/shell32/CDefView.cpp
+++ b/dll/win32/shell32/CDefView.cpp
@@ -1348,8 +1348,6 @@ HRESULT CDefView::FillFileMenu()
             DeleteMenu(hFileMenu, i, MF_BYPOSITION);
     }
 
-    m_cidl = m_ListView.GetSelectedCount();
-
     /* In case we still have this left over, clean it up! */
     if (m_pFileMenu)
     {