[ros-diffs] [akhaldi] 56972: * We've been waiting, for a long time, for the mighty GCC version upgrade, but that was easier said than done, for the Windows build at least. Many have tried, to no avail, so Amin...

Author: akhaldi
Date: Sun Jul 29 00:47:58 2012
New Revision: 56972

URL: http://svn.reactos.org/svn/reactos?rev=56972&view=rev
Log:
* We've been waiting, for a long time, for the mighty GCC version upgrade, but that
was easier said than done, for the Windows build at least. Many have tried, to no avail,
so Amine finally decided to step up, to give it a shot.. he went on and learned the dark
arts of compiling GCC... and he succeeded !
* In the journey of running his GCC 4.7.1 compiled bootcd, two issues were revealed.
Thomas kindly investigated them and fixed them, and as a result the bootcd boots to shell
!
[CSRSRV]
* Fix the output parameter of ProcessLUIDDeviceMapsEnabled case in
NtQueryInformationProcess() to be ULONG instead of BOOLEAN (as required).
* ASSERT that the function succeeds.
[SMSS]
* Move this condition up to the commented-out part (where it belongs).

Modified:
    trunk/reactos/base/system/smss2/sminit.c
    trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c

Modified: trunk/reactos/base/system/smss2/sminit.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss2/sminit.c…
==============================================================================
--- trunk/reactos/base/system/smss2/sminit.c [iso-8859-1] (original)
+++ trunk/reactos/base/system/smss2/sminit.c [iso-8859-1] Sun Jul 29 00:47:58 2012
@@ -1402,8 +1402,8 @@
     NTSTATUS Status, Status1;
     PLIST_ENTRY NextEntry;
     PSMP_REGISTRY_VALUE RegEntry;
-    ULONG_PTR ErrorParameters[3];
-    UNICODE_STRING ErrorResponse;
+    //ULONG_PTR ErrorParameters[3];
+    //UNICODE_STRING ErrorResponse;
     IO_STATUS_BLOCK IoStatusBlock;
     SECURITY_DESCRIPTOR_CONTROL OldFlag = 0;
     USHORT ImageCharacteristics;
@@ -1545,7 +1545,6 @@
             SmpTerminate(ErrorParameters, 5, RTL_NUMBER_OF(ErrorParameters));
         }
         else
-#endif
         if (!(ImageCharacteristics & IMAGE_FILE_DLL))
         {
             /* An invalid known DLL entry will also kill SMSS */
@@ -1556,6 +1555,7 @@
             ErrorParameters[2] = (ULONG)&RegEntry->Value;
             SmpTerminate(ErrorParameters, 5, RTL_NUMBER_OF(ErrorParameters));
         }
+#endif
 
         /* Temporarily hack the SD to use a default DACL for this section */
         if (SmpLiberalSecurityDescriptor)

Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr…
==============================================================================
--- trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1] Sun Jul 29
00:47:58 2012
@@ -500,7 +500,7 @@
     PSECURITY_DESCRIPTOR BnoSd;
     HANDLE SymHandle;
     UNICODE_STRING DirectoryName, SymlinkName;
-    BOOLEAN LuidEnabled;
+    ULONG LuidEnabled;
     RTL_QUERY_REGISTRY_TABLE BaseServerRegistryConfigurationTable[2] =
     {
         {
@@ -674,11 +674,12 @@
     }
 
     /* Check if LUID device maps are enabled */
-    NtQueryInformationProcess(NtCurrentProcess(),
-                              ProcessLUIDDeviceMapsEnabled,
-                              &LuidEnabled,
-                              sizeof(LuidEnabled),
-                              NULL);
+    Status = NtQueryInformationProcess(NtCurrentProcess(),
+                                       ProcessLUIDDeviceMapsEnabled,
+                                       &LuidEnabled,
+                                       sizeof(LuidEnabled),
+                                       NULL);
+    ASSERT(NT_SUCCESS(Status));
     BaseStaticServerData->LUIDDeviceMapsEnabled = LuidEnabled;
     if (!BaseStaticServerData->LUIDDeviceMapsEnabled)
     {