[ros-diffs] [sginsberg] 43673: - Don't use KeBugCheck(0) -- 0 is an invalid bugcode. Use a proper bugcode, DbgBreakPoint or UNIMPLEMENTED instead depending on how the old call was used. - Remove some unused and deprecated macros from the network stack that did this. - fastfat_new: Use FAT_FILE_SYSTEM instead of magic 0x23.

Author: sginsberg
Date: Wed Oct 21 19:52:11 2009
New Revision: 43673

URL: http://svn.reactos.org/svn/reactos?rev=43673&view=rev
Log:
- Don't use KeBugCheck(0) -- 0 is an invalid bugcode. Use a proper bugcode,
DbgBreakPoint or UNIMPLEMENTED instead depending on how the old call was used.
- Remove some unused and deprecated macros from the network stack that did this.
- fastfat_new: Use FAT_FILE_SYSTEM instead of magic 0x23.

Modified:
    trunk/reactos/drivers/filesystems/fastfat/fcb.c
    trunk/reactos/drivers/filesystems/fastfat/vfat.h
    trunk/reactos/drivers/filesystems/fastfat_new/create.c
    trunk/reactos/drivers/filesystems/fastfat_new/fastfat.h
    trunk/reactos/drivers/filesystems/fastfat_new/fcb.c
    trunk/reactos/drivers/network/afd/include/debug.h
    trunk/reactos/drivers/network/dd/ne2000/include/debug.h
    trunk/reactos/drivers/network/dd/ne2000/ne2000/main.c
    trunk/reactos/drivers/network/lan/include/debug.h
    trunk/reactos/drivers/wdm/audio/backpln/portcls/adapter.cpp
    trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_dmus.cpp
    trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp
    trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp
    trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavert.cpp
    trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.cpp
    trunk/reactos/drivers/wdm/audio/backpln/portcls/purecall.cpp
    trunk/reactos/hal/halamd64/generic/hal.c
    trunk/reactos/hal/halarm/generic/hal.c
    trunk/reactos/hal/halppc/generic/bus.c
    trunk/reactos/hal/halppc/generic/irql.c
    trunk/reactos/hal/halppc/generic/profil.c
    trunk/reactos/hal/halx86/generic/bios.c
    trunk/reactos/hal/halx86/generic/profil.c
    trunk/reactos/hal/halx86/mp/mpconfig.c
    trunk/reactos/lib/drivers/ip/network/arp.c
    trunk/reactos/lib/drivers/oskittcp/include/oskitdebug.h
    trunk/reactos/ntoskrnl/ke/powerpc/exp.c
    trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c
    trunk/reactos/ntoskrnl/mm/ppool.c

Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa…
==============================================================================
--- trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -81,7 +81,7 @@
 	{
 		/* FIXME: what to do if no more memory? */
 		DPRINT1("Unable to initialize FCB for filename '%wZ'\n", NameU);
-		KeBugCheckEx(0, (ULONG_PTR)Fcb, (ULONG_PTR)NameU, 0, 0);
+		KeBugCheckEx(FAT_FILE_SYSTEM, (ULONG_PTR)Fcb, (ULONG_PTR)NameU, 0, 0);
 	}
 
 	Fcb->PathNameU.Length = 0;

Modified: trunk/reactos/drivers/filesystems/fastfat/vfat.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa…
==============================================================================
--- trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] Wed Oct 21 19:52:11
2009
@@ -1,4 +1,5 @@
 #include <ntifs.h>
+#include <bugcodes.h>
 #include <ntdddisk.h>
 #include <debug.h>
 

Modified: trunk/reactos/drivers/filesystems/fastfat_new/create.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa…
==============================================================================
--- trunk/reactos/drivers/filesystems/fastfat_new/create.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/fastfat_new/create.c [iso-8859-1] Wed Oct 21
19:52:11 2009
@@ -895,7 +895,7 @@
         else
         {
             /* Unexpected FCB type */
-            KeBugCheckEx(/*FAT_FILE_SYSTEM*/0x23, __LINE__, (ULONG_PTR)Fcb, 0, 0);
+            KeBugCheckEx(FAT_FILE_SYSTEM, __LINE__, (ULONG_PTR)Fcb, 0, 0);
         }
     }
 

Modified: trunk/reactos/drivers/filesystems/fastfat_new/fastfat.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa…
==============================================================================
--- trunk/reactos/drivers/filesystems/fastfat_new/fastfat.h [iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/fastfat_new/fastfat.h [iso-8859-1] Wed Oct 21
19:52:11 2009
@@ -1,4 +1,5 @@
 #include <ntifs.h>
+#include <bugcodes.h>
 #include <ntdddisk.h>
 #include <debug.h>
 #include <pseh/pseh2.h>

Modified: trunk/reactos/drivers/filesystems/fastfat_new/fcb.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa…
==============================================================================
--- trunk/reactos/drivers/filesystems/fastfat_new/fcb.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/fastfat_new/fcb.c [iso-8859-1] Wed Oct 21 19:52:11
2009
@@ -389,7 +389,7 @@
     else
     {
         /* We can't get here */
-        KeBugCheckEx(0x23, CreateDisposition, 0, 0, 0);
+        KeBugCheckEx(FAT_FILE_SYSTEM, CreateDisposition, 0, 0, 0);
     }
 
 

Modified: trunk/reactos/drivers/network/afd/include/debug.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/includ…
==============================================================================
--- trunk/reactos/drivers/network/afd/include/debug.h [iso-8859-1] (original)
+++ trunk/reactos/drivers/network/afd/include/debug.h [iso-8859-1] Wed Oct 21 19:52:11
2009
@@ -50,7 +50,7 @@
 #ifdef NASSERT
 #define ASSERT(x)
 #else /* NASSERT */
-#define ASSERT(x) if (!(x)) { AFD_DbgPrint(MIN_TRACE, ("Assertion "#x"
failed at %s:%d\n", __FILE__, __LINE__)); KeBugCheck(0); }
+#define ASSERT(x) if (!(x)) { AFD_DbgPrint(MIN_TRACE, ("Assertion "#x"
failed at %s:%d\n", __FILE__, __LINE__)); DbgBreakPoint(); }
 #endif /* NASSERT */
 
 #define ASSERT_IRQL(x) ASSERT(KeGetCurrentIrql() <= (x))

Modified: trunk/reactos/drivers/network/dd/ne2000/include/debug.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/ne2000/…
==============================================================================
--- trunk/reactos/drivers/network/dd/ne2000/include/debug.h [iso-8859-1] (original)
+++ trunk/reactos/drivers/network/dd/ne2000/include/debug.h [iso-8859-1] Wed Oct 21
19:52:11 2009
@@ -43,18 +43,6 @@
 #endif /* _MSC_VER */
 
 
-/* Assert is defined in ndis.h */
-#if 0
-#ifdef ASSERT
-#undef ASSERT
-#endif
-
-#ifdef NASSERT
-#define ASSERT(x)
-#else /* NASSERT */
-#define ASSERT(x) if (!(x)) { NDIS_DbgPrint(MIN_TRACE, ("Assertion "#x"
failed at %s:%d\n", __FILE__, __LINE__)); KeBugCheck(0); }
-#endif /* NASSERT */
-#endif
 #define ASSERT_IRQL(x) ASSERT(KeGetCurrentIrql() <= (x))
 #define ASSERT_IRQL_EQUAL(x) ASSERT(KeGetCurrentIrql() == (x))
 

Modified: trunk/reactos/drivers/network/dd/ne2000/ne2000/main.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/ne2000/…
==============================================================================
--- trunk/reactos/drivers/network/dd/ne2000/ne2000/main.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/network/dd/ne2000/ne2000/main.c [iso-8859-1] Wed Oct 21 19:52:11
2009
@@ -1001,7 +1001,7 @@
             if(Status != NDIS_STATUS_SUCCESS)
             {
                 DbgPrint("ne2000!MiniportInitialize: failed to set DwordTest:
0x%x\n", Status);
-                KeBugCheck(0);
+                DbgBreakPoint();
             }
 
             DbgPrint("ne2000!MiniportInitialize: DwordTest successfully
set\n");
@@ -1015,7 +1015,7 @@
             if(Status != NDIS_STATUS_SUCCESS)
             {
                 DbgPrint("ne2000!MiniportInitialize: failed to set StringTest:
0x%x\n", Status);
-                KeBugCheck(0);
+                DbgBreakPoint();
             }
 
             DbgPrint("ne2000!MiniportInitialize: StringTest successfully
set\n");
@@ -1031,14 +1031,14 @@
             if(Status != NDIS_STATUS_SUCCESS)
             {
                 DbgPrint("ne2000!MiniportInitialize: failed to read DwordTest:
0x%x\n", Status);
-                KeBugCheck(0);
+                DbgBreakPoint();
             }
 
             if(ParameterValue->ParameterData.IntegerData != 0x12345678)
             {
                 DbgPrint("ne2000!MiniportInitialize: DwordTest value is wrong:
0x%x\n",
                     ParameterValue->ParameterData.IntegerData);
-                KeBugCheck(0);
+                DbgBreakPoint();
             }
 
             DbgPrint("ne2000!MiniportInitialize: DwordTest value was correctly
read\n");
@@ -1049,7 +1049,7 @@
             if(Status != NDIS_STATUS_SUCCESS)
             {
                 DbgPrint("ne2000!MiniportInitialize: failed to read StringTest:
0x%x\n", Status);
-                KeBugCheck(0);
+                DbgBreakPoint();
             }
 
             if(wcsncmp(ParameterValue->ParameterData.StringData.Buffer,
L"Testing123",
@@ -1057,7 +1057,7 @@
             {
                 DbgPrint("ne2000!MiniportInitialize: StringTest value is wrong:
%wZ\n",
                     &ParameterValue->ParameterData.StringData);
-                KeBugCheck(0);
+                DbgBreakPoint();
             }
 
             DbgPrint("ne2000!MiniportInitialize: StringTest value was correctly
read\n");

Modified: trunk/reactos/drivers/network/lan/include/debug.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/lan/includ…
==============================================================================
--- trunk/reactos/drivers/network/lan/include/debug.h [iso-8859-1] (original)
+++ trunk/reactos/drivers/network/lan/include/debug.h [iso-8859-1] Wed Oct 21 19:52:11
2009
@@ -57,18 +57,6 @@
 
 #endif /* _MSC_VER */
 
-#if 0
-#ifdef ASSERT
-#undef ASSERT
-#endif
-
-#ifdef NASSERT
-#define ASSERT(x)
-#else /* NASSERT */
-#define ASSERT(x) if (!(x)) { LA_DbgPrint(MIN_TRACE, ("Assertion "#x"
failed at %s:%d\n", __FILE__, __LINE__)); KeBugCheck(0); }
-#endif /* NASSERT */
-#endif
-
 #define ASSERT_IRQL(x) ASSERT(KeGetCurrentIrql() <= (x))
 
 #else /* DBG */

Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/adapter.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/…
==============================================================================
--- trunk/reactos/drivers/wdm/audio/backpln/portcls/adapter.cpp [iso-8859-1] (original)
+++ trunk/reactos/drivers/wdm/audio/backpln/portcls/adapter.cpp [iso-8859-1] Wed Oct 21
19:52:11 2009
@@ -232,7 +232,7 @@
     if (!DeviceExt)
     {
         // should not happen
-        KeBugCheck(0);
+        DbgBreakPoint();
         return STATUS_UNSUCCESSFUL;
     }
 

Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_dmus.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/…
==============================================================================
--- trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_dmus.cpp [iso-8859-1] (original)
+++ trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_dmus.cpp [iso-8859-1] Wed Oct 21
19:52:11 2009
@@ -715,7 +715,8 @@
     else
     {
         DPRINT("Unexpected Communication %u DataFlow %u\n",
KsPinDescriptor->Communication, KsPinDescriptor->DataFlow);
-        KeBugCheck(0);
+        DbgBreakPoint();
+        while(TRUE);
     }
 
     Status = NewIrpQueue(&m_IrpQueue);

Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/…
==============================================================================
--- trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp [iso-8859-1]
(original)
+++ trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp [iso-8859-1] Wed
Oct 21 19:52:11 2009
@@ -869,7 +869,8 @@
     else
     {
         DPRINT("Unexpected Communication %u DataFlow %u\n",
KsPinDescriptor->Communication, KsPinDescriptor->DataFlow);
-        KeBugCheck(0);
+        DbgBreakPoint();
+        while(TRUE);
     }
 
 

Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/…
==============================================================================
--- trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp [iso-8859-1]
(original)
+++ trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp [iso-8859-1] Wed Oct
21 19:52:11 2009
@@ -981,7 +981,8 @@
     else
     {
         DPRINT("Unexpected Communication %u DataFlow %u\n",
KsPinDescriptor->Communication, KsPinDescriptor->DataFlow);
-        KeBugCheck(0);
+        DbgBreakPoint();
+        while(TRUE);
     }
 
     Status = m_Miniport->NewStream(&m_Stream,

Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavert.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/…
==============================================================================
--- trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavert.cpp [iso-8859-1]
(original)
+++ trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavert.cpp [iso-8859-1] Wed Oct 21
19:52:11 2009
@@ -697,6 +697,7 @@
     {
         DPRINT("Unexpected Communication %u DataFlow %u\n",
KsPinDescriptor->Communication, KsPinDescriptor->DataFlow);
         KeBugCheck(0);
+        while(TRUE);
     }
 
     Status = m_Miniport->NewStream(&m_Stream, m_PortStream,
ConnectDetails->PinId, Capture, m_Format);

Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/…
==============================================================================
--- trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.cpp [iso-8859-1]
(original)
+++ trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.cpp [iso-8859-1] Wed
Oct 21 19:52:11 2009
@@ -212,7 +212,8 @@
     if (!NT_SUCCESS(Status))
     {
         DPRINT("Failed to obtain ISubdevice interface from port driver\n");
-        KeBugCheck(0);
+        DbgBreakPoint();
+        while(TRUE);
     }
 
     // get current stack location

Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/purecall.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/…
==============================================================================
--- trunk/reactos/drivers/wdm/audio/backpln/portcls/purecall.cpp [iso-8859-1] (original)
+++ trunk/reactos/drivers/wdm/audio/backpln/portcls/purecall.cpp [iso-8859-1] Wed Oct 21
19:52:11 2009
@@ -16,7 +16,7 @@
   {
     // put error handling here
 
-    KeBugCheck(0);
+    DbgBreakPoint();
 
   }
 }

Modified: trunk/reactos/hal/halamd64/generic/hal.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halamd64/generic/hal.c…
==============================================================================
--- trunk/reactos/hal/halamd64/generic/hal.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halamd64/generic/hal.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -120,7 +120,7 @@
 NTAPI
 HalStopProfileInterrupt(IN KPROFILE_SOURCE ProfileSource)
 {
-    KeBugCheck(0);
+    UNIMPLEMENTED;
     return;
 }
 
@@ -131,7 +131,7 @@
 NTAPI
 HalStartProfileInterrupt(IN KPROFILE_SOURCE ProfileSource)
 {
-    KeBugCheck(0);
+    UNIMPLEMENTED;
     return;
 }
 
@@ -142,7 +142,7 @@
 NTAPI
 HalSetProfileInterval(IN ULONG_PTR Interval)
 {
-    KeBugCheck(0);
+    UNIMPLEMENTED;
     return Interval;
 }
 

Modified: trunk/reactos/hal/halarm/generic/hal.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halarm/generic/hal.c?r…
==============================================================================
--- trunk/reactos/hal/halarm/generic/hal.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halarm/generic/hal.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -120,7 +120,7 @@
 NTAPI
 HalStopProfileInterrupt(IN KPROFILE_SOURCE ProfileSource)
 {
-    KeBugCheck(0);
+    UNIMPLEMENTED;
     return;
 }
 
@@ -131,7 +131,7 @@
 NTAPI
 HalStartProfileInterrupt(IN KPROFILE_SOURCE ProfileSource)
 {
-    KeBugCheck(0);
+    UNIMPLEMENTED;
     return;
 }
 
@@ -142,7 +142,7 @@
 NTAPI
 HalSetProfileInterval(IN ULONG_PTR Interval)
 {
-    KeBugCheck(0);
+    UNIMPLEMENTED;
     return Interval;
 }
 

Modified: trunk/reactos/hal/halppc/generic/bus.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halppc/generic/bus.c?r…
==============================================================================
--- trunk/reactos/hal/halppc/generic/bus.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halppc/generic/bus.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -222,7 +222,7 @@
     else if (BusDataType == EisaConfiguration)
     {
         /* FIXME: TODO */
-        KeBugCheck(0);
+        ASSERT(FALSE);
     }
     else if ((BusDataType == PCIConfiguration) &&
              (HalpPCIConfigInitialized) &&

Modified: trunk/reactos/hal/halppc/generic/irql.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halppc/generic/irql.c?…
==============================================================================
--- trunk/reactos/hal/halppc/generic/irql.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halppc/generic/irql.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -216,7 +216,7 @@
     {
       DbgPrint ("(%s:%d) NewIrql %x CurrentIrql %x\n",
 		__FILE__, __LINE__, NewIrql, KeGetPcr()->Irql);
-      KeBugCheck(0);
+      KeBugCheck(IRQL_NOT_LESS_OR_EQUAL);
       for(;;);
     }
 
@@ -251,7 +251,7 @@
     {
       DbgPrint ("%s:%d CurrentIrql %x NewIrql %x\n",
 		__FILE__,__LINE__,KeGetPcr()->Irql,NewIrql);
-      KeBugCheck (0);
+      KeBugCheck (IRQL_NOT_GREATER_OR_EQUAL);
       for(;;);
     }
 
@@ -424,7 +424,7 @@
       break;
 
     default:
-      KeBugCheck(0);
+      DbgBreakPoint();
   }
 }
 
@@ -443,7 +443,7 @@
       break;
 
     default:
-      KeBugCheck(0);
+      DbgBreakPoint();
   }
 }
 

Modified: trunk/reactos/hal/halppc/generic/profil.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halppc/generic/profil.…
==============================================================================
--- trunk/reactos/hal/halppc/generic/profil.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halppc/generic/profil.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -21,7 +21,7 @@
 NTAPI
 HalStopProfileInterrupt(IN KPROFILE_SOURCE ProfileSource)
 {
-    KeBugCheck(0);
+    UNIMPLEMENTED;
     return;
 }
 
@@ -32,7 +32,7 @@
 NTAPI
 HalStartProfileInterrupt(IN KPROFILE_SOURCE ProfileSource)
 {
-    KeBugCheck(0);
+    UNIMPLEMENTED;
     return;
 }
 
@@ -43,7 +43,7 @@
 NTAPI
 HalSetProfileInterval(IN ULONG_PTR Interval)
 {
-    KeBugCheck(0);
+    UNIMPLEMENTED;
     return Interval;
 }
 

Modified: trunk/reactos/hal/halx86/generic/bios.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bios.c?…
==============================================================================
--- trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -109,7 +109,7 @@
     ULONG Handler;
     PHARDWARE_PTE IdtPte;
 
-    /* On i586, the first 7 entries of IDT are write-protected, unprotect them. */
+    /* On i586, the first 7 entries of IDT are write-protected, unprotect them. */ //
Nasty hto hack
     if (KeGetCurrentPrcb()->CpuType == 5)
     {
         IdtPte = GetPteAddress(((PKIPCR)KeGetPcr())->IDT);
@@ -197,6 +197,7 @@
         Pte = GetPteAddress((PVOID)i);
         Pte->Valid = 0;
         Pte->Write = 0;
+        //Pte->Owner = 0; // Missing this?
         Pte->PageFrameNumber = 0;
     }
     

Modified: trunk/reactos/hal/halx86/generic/profil.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/profil.…
==============================================================================
--- trunk/reactos/hal/halx86/generic/profil.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/generic/profil.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -21,7 +21,7 @@
 NTAPI
 HalStopProfileInterrupt(IN KPROFILE_SOURCE ProfileSource)
 {
-    ASSERT(FALSE);
+    UNIMPLEMENTED;
     return;
 }
 
@@ -32,7 +32,7 @@
 NTAPI
 HalStartProfileInterrupt(IN KPROFILE_SOURCE ProfileSource)
 {
-    ASSERT(FALSE);
+    UNIMPLEMENTED;
     return;
 }
 
@@ -43,6 +43,6 @@
 NTAPI
 HalSetProfileInterval(IN ULONG_PTR Interval)
 {
-    ASSERT(FALSE);
+    UNIMPLEMENTED;
     return Interval;
 }

Modified: trunk/reactos/hal/halx86/mp/mpconfig.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/mp/mpconfig.c?r…
==============================================================================
--- trunk/reactos/hal/halx86/mp/mpconfig.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/mp/mpconfig.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -271,7 +271,7 @@
        
        DPRINT1("Bad MP configuration block signature: %c%c%c%c\n",
 		pc[0], pc[1], pc[2], pc[3]);
-       KeBugCheckEx(0, pc[0], pc[1], pc[2], pc[3]);
+       KeBugCheckEx(HAL_INITIALIZATION_FAILED, pc[0], pc[1], pc[2], pc[3]);
        return FALSE;
      }
 

Modified: trunk/reactos/lib/drivers/ip/network/arp.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/ip/network/arp…
==============================================================================
--- trunk/reactos/lib/drivers/ip/network/arp.c [iso-8859-1] (original)
+++ trunk/reactos/lib/drivers/ip/network/arp.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -140,7 +140,7 @@
             break;
         default:
 	    TI_DbgPrint(DEBUG_ARP,("Bad Address Type %x\n", Address->Type));
-	    KeBugCheck(0);
+	    DbgBreakPoint();
             /* Should not happen */
             return FALSE;
     }

Modified: trunk/reactos/lib/drivers/oskittcp/include/oskitdebug.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/oskittcp/inclu…
==============================================================================
--- trunk/reactos/lib/drivers/oskittcp/include/oskitdebug.h [iso-8859-1] (original)
+++ trunk/reactos/lib/drivers/oskittcp/include/oskitdebug.h [iso-8859-1] Wed Oct 21
19:52:11 2009
@@ -59,18 +59,6 @@
 
 #endif /* _MSC_VER */
 
-#if 0
-#ifdef ASSERT
-#undef ASSERT
-#endif
-
-#ifdef NASSERT
-#define ASSERT(x)
-#else /* NASSERT */
-#define ASSERT(x) if (!(x)) { OS_DbgPrint(MIN_TRACE, ("Assertion "#x"
failed at %s:%d\n", __FILE__, __LINE__)); KeBugCheck(0); }
-#endif /* NASSERT */
-#endif
-
 #define ASSERT_IRQL(x) ASSERT(KeGetCurrentIrql() <= (x))
 
 #else /* DBG */

Modified: trunk/reactos/ntoskrnl/ke/powerpc/exp.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/powerpc/exp.c?…
==============================================================================
--- trunk/reactos/ntoskrnl/ke/powerpc/exp.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ke/powerpc/exp.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -88,7 +88,7 @@
     DbgPrint("EXCEPTION! Record %08x Frame %08x\n",
              ExceptionRecord, ExceptionFrame);
     MmuDumpMap();
-    KeBugCheck(0);
+    KeBugCheck(KMODE_EXCEPTION_NOT_HANDLED);
 }
 
 /*

Modified: trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/powerpc/kiinit…
==============================================================================
--- trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -352,6 +352,6 @@
 
 void abort()
 {
-    KeBugCheck(0);
+    KeBugCheck(KMODE_EXCEPTION_NOT_HANDLED);
     while(1);
 }

Modified: trunk/reactos/ntoskrnl/mm/ppool.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ppool.c?rev=43…
==============================================================================
--- trunk/reactos/ntoskrnl/mm/ppool.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/ppool.c [iso-8859-1] Wed Oct 21 19:52:11 2009
@@ -19,7 +19,7 @@
 #endif
 
 #undef ASSERT
-#define ASSERT(x) if (!(x)) {DbgPrint("Assertion "#x" failed at
%s:%d\n", __FILE__,__LINE__); KeBugCheck(0); }
+#define ASSERT(x) if (!(x)) {DbgPrint("Assertion "#x" failed at
%s:%d\n", __FILE__,__LINE__); DbgBreakPoint(); }
 
 // enable "magic"
 //#define R_MAGIC
@@ -27,7 +27,7 @@
 #define R_ACQUIRE_MUTEX(pool) /*DPRINT1("Acquiring PPool Mutex\n");*/
ExAcquireFastMutex(&pool->Mutex)
 #define R_RELEASE_MUTEX(pool) /*DPRINT1("Releasing PPool Mutex\n");*/
ExReleaseFastMutex(&pool->Mutex)
 #define R_PRINT_ADDRESS(addr) KeRosPrintAddress(addr)
-#define R_PANIC() KeBugCheck(0)
+#define R_PANIC() KeBugCheck(MEMORY_MANAGEMENT)
 #define R_DEBUG DbgPrint
 
 #ifdef _ARM_