[ros-diffs] [reactos] 01/01: [NTUSER] Remove a wrong check in MENU_MouseMove (#5736)

[Egor Ananyin]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e2d3aa7f4ac40e0d84c05…

commit e2d3aa7f4ac40e0d84c05aa98dd1554ba8c6c456
Author:     Egor Ananyin <ananinegor(a)gmail.com>
AuthorDate: Mon Oct 16 19:10:52 2023 +0300
Commit:     GitHub <noreply(a)github.com>
CommitDate: Mon Oct 16 19:10:52 2023 +0300

    [NTUSER] Remove a wrong check in MENU_MouseMove (#5736)
    
    This check doesn't seem to be correct in modern ReactOS. Furthermore, it
    actually hadn't been working for a long time until it was uncovered by
    the recent system menu changes.
    
    Reverts a hack introduced in 17a315285 (r72517), fixes CORE-19170.
    The initial bug described in CORE-2338 is not observed.
---
 win32ss/user/ntuser/menu.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/win32ss/user/ntuser/menu.c b/win32ss/user/ntuser/menu.c
index 869b9bb4cc4..6b2f242cc25 100644
--- a/win32ss/user/ntuser/menu.c
+++ b/win32ss/user/ntuser/menu.c
@@ -3683,20 +3683,7 @@ static BOOL FASTCALL MENU_MouseMove(MTRACKER *pmt, PMENU PtMenu,
UINT Flags)
   UINT Index = NO_SELECTED_ITEM;
 
   if ( PtMenu )
-  {
-      if (IS_SYSTEM_MENU(PtMenu))
-      {
-          Index = 0;
-          //// ReactOS only HACK: CORE-2338
-          // Windows tracks mouse moves to the system menu but does not open it.
-          // Only keyboard tracking can do that.
-          //
-          TRACE("SystemMenu\n");
-          return TRUE; // Stay inside the Loop!
-      }
-      else
-          MENU_FindItemByCoords( PtMenu, pmt->Pt, &Index );
-  }
+      MENU_FindItemByCoords( PtMenu, pmt->Pt, &Index );
 
   if (Index == NO_SELECTED_ITEM)
   {