[ros-diffs] [gadamopoulos] 55550: [win32k] - In reactos when an application tries to use a desktop or window station object we never check if it should have access to the object. However the only exception to ...

Author: gadamopoulos
Date: Sat Feb 11 22:17:46 2012
New Revision: 55550

URL: http://svn.reactos.org/svn/reactos?rev=55550&view=rev
Log:
[win32k]
- In reactos when an application tries to use a desktop or window station object we never
check if it should have access to the object. However the only exception to this is
NtUserGetObjectInformation. Since desktops and windows stations are a mess,
NtUserGetObjectInformation always fails. Ironically windows do such access checks
everywhere except NtUserGetObjectInformation. Fix NtUserGetObjectInformation by removing
access checks
- Note: access checks for every other place will be fixed soon

Modified:
    trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c

Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c [iso-8859-1] Sat Feb 11 22:17:46
2012
@@ -649,8 +649,8 @@
    TRACE("Trying to open window station 0x%x\n", hObject);
    Status = IntValidateWindowStationHandle(
                hObject,
-               UserMode,/*ExGetPreviousMode(),*/
-               GENERIC_READ, /* FIXME: is this ok? */
+               UserMode,
+               0,
                &WinStaObject);
 
 
@@ -667,8 +667,8 @@
       TRACE("Trying to open desktop 0x%x\n", hObject);
       Status = IntValidateDesktopHandle(
                   hObject,
-                  UserMode,/*ExGetPreviousMode(),*/
-                  GENERIC_READ, /* FIXME: is this ok? */
+                  UserMode,
+                  0, 
                   &DesktopObject);
       if (!NT_SUCCESS(Status))
       {