[ros-diffs] [ion] 22942: - Write some TODOs. I'm now done with I/O IRP APIs and File Object handling. Let me know of regressions. - Next up... driver loading.

Author: ion
Date: Sat Jul  8 23:41:20 2006
New Revision: 22942

URL: http://svn.reactos.org/svn/reactos?rev=22942&view=rev
Log:
- Write some TODOs. I'm now done with I/O IRP APIs and File Object handling. Let me
know of regressions.
- Next up... driver loading.

Modified:
    trunk/reactos/ntoskrnl/io/iomgr/file.c
    trunk/reactos/ntoskrnl/io/iomgr/iofunc.c

Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/file.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c Sat Jul  8 23:41:20 2006
@@ -14,6 +14,25 @@
 #include <ntoskrnl.h>
 #define NDEBUG
 #include <internal/debug.h>
+
+#if 0
+    IOTRACE(IO_IRP_DEBUG,
+            "%s - Queueing IRP %p\n",
+            __FUNCTION__,
+            Irp);
+#endif
+
+///
+//
+// TODO:
+// - Add support for Fast Dispatch I/O.
+// - Verify ShareAccess APIs, XP added some new semantics.
+// - Add Access Checks in IopParseDevice.
+// - Add validation checks in IoCreateFile.
+// - Add tracing.
+// - See why queueing IRPs and cancelling them causes crashes
+//
+///
 
 /* PRIVATE FUNCTIONS *********************************************************/
 
@@ -1638,7 +1657,6 @@
     }
 }
 
-
 /*
  * @implemented
  */
@@ -1819,7 +1837,6 @@
     UNIMPLEMENTED;
     return STATUS_NOT_IMPLEMENTED;
 }
-
 
 /*
  * @implemented

Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Sat Jul  8 23:41:20 2006
@@ -24,12 +24,13 @@
 ///
 //
 // TODO:
-// - Add SEH to some places where it's missing (MDLs, etc)
-// - Add a generic Cleanup/Exception Routine
-// - Add probe/alignment checks for Query/Set routines
-// - Add another parameter to IopCleanupFailedIrp
-// - Add support for Fast Dispatch I/O
-// - Add support for some fast-paths when querying/setting data
+// - Add SEH to some places where it's missing (MDLs, etc).
+// - Add a generic Cleanup/Exception Routine.
+// - Add probe/alignment checks for Query/Set routines.
+// - Add another parameter to IopCleanupFailedIrp.
+// - Add support for Fast Dispatch I/O.
+// - Add support for some fast-paths when querying/setting data.
+// - Add tracing.
 //
 ///