[ros-diffs] [reactos] 01/01: [SHELL32] ShellDispatch::ShellExecute must default to displaying the window (#6143)

[Whindmar Saksit]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=19a0f14bb19403e29d1a4…

commit 19a0f14bb19403e29d1a43757f7cf5dab4e397d8
Author:     Whindmar Saksit <whindsaks(a)proton.me>
AuthorDate: Sun Dec 17 13:48:24 2023 +0100
Commit:     GitHub <noreply(a)github.com>
CommitDate: Sun Dec 17 15:48:24 2023 +0300

    [SHELL32] ShellDispatch::ShellExecute must default to displaying the window (#6143)
    
    SW_HIDE is not the correct default show mode.
    
    This can be reproduced by simple script:
   
WScript.CreateObject("Shell.Application").ShellExecute("calc.exe");
---
 dll/win32/shell32/CShellDispatch.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dll/win32/shell32/CShellDispatch.cpp b/dll/win32/shell32/CShellDispatch.cpp
index d021bf5ea2b..7df94e0ae04 100644
--- a/dll/win32/shell32/CShellDispatch.cpp
+++ b/dll/win32/shell32/CShellDispatch.cpp
@@ -245,7 +245,7 @@ HRESULT STDMETHODCALLTYPE CShellDispatch::ShellExecute(BSTR file,
VARIANT v_args
 {
     CComVariant args_str, dir_str, op_str, show_int;
     WCHAR *args = NULL, *dir = NULL, *op = NULL;
-    INT show = 0;
+    INT show = SW_SHOW;
     HINSTANCE ret;
 
     TRACE("(%s, %s, %s, %s, %s)\n", debugstr_w(file),
debugstr_variant(&v_args),