[ros-diffs] [dchapyshev] 53516: - Fix typos, found by PVS-Studio

Author: dchapyshev
Date: Thu Sep  1 13:18:22 2011
New Revision: 53516

URL: http://svn.reactos.org/svn/reactos?rev=53516&view=rev
Log:
- Fix typos, found by PVS-Studio

Modified:
    trunk/reactos/dll/win32/netshell/lanstatusui.c
    trunk/reactos/dll/win32/opengl32/font.c
    trunk/reactos/dll/win32/shell32/autocomplete.c
    trunk/reactos/dll/win32/syssetup/wizard.c
    trunk/reactos/drivers/network/tdi/cte/events.c
    trunk/reactos/lib/3rdparty/adns/src/transmit.c
    trunk/reactos/lib/3rdparty/stlport/src/locale.cpp
    trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c

Modified: trunk/reactos/dll/win32/netshell/lanstatusui.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netshell/lanstat…
==============================================================================
--- trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] Thu Sep  1 13:18:22 2011
@@ -179,7 +179,7 @@
             pContext->Status = 3;
         }
     }
-    else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE ||
MIB_IF_OPER_STATUS_DISCONNECTED)
+    else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE |
MIB_IF_OPER_STATUS_DISCONNECTED)
     {
         if (pContext->Status != 4)
         {

Modified: trunk/reactos/dll/win32/opengl32/font.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/opengl32/font.c?…
==============================================================================
--- trunk/reactos/dll/win32/opengl32/font.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/opengl32/font.c [iso-8859-1] Thu Sep  1 13:18:22 2011
@@ -1081,7 +1081,7 @@
 
         glyphSize = GetGlyphOutline(hDC, glyphIndex, GGO_NATIVE, &glyphMetrics, 0,
NULL, &matrix);
 
-        if (glyphSize < 0)
+        if (glyphSize == GDI_ERROR)
             return FALSE; /*WGL_STATUS_FAILURE*/
 
         if (glyphSize > glyphBufSize)
@@ -1096,7 +1096,7 @@
         /*
         * Get the glyph's outlines.
         */
-        if (GetGlyphOutline(hDC, glyphIndex, GGO_NATIVE, &glyphMetrics, glyphBufSize,
glyphBuf, &matrix) < 0)
+        if (GetGlyphOutline(hDC, glyphIndex, GGO_NATIVE, &glyphMetrics, glyphBufSize,
glyphBuf, &matrix) == GDI_ERROR)
         {
             HeapFree(GetProcessHeap(), 0, glyphBuf);
             return FALSE; /*WGL_STATUS_FAILURE*/

Modified: trunk/reactos/dll/win32/shell32/autocomplete.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/autocomp…
==============================================================================
--- trunk/reactos/dll/win32/shell32/autocomplete.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/autocomplete.c [iso-8859-1] Thu Sep  1 13:18:22 2011
@@ -448,7 +448,7 @@
 	    ShowWindow(This->hwndListBox, SW_HIDE);
 	    break;
 	case WM_KILLFOCUS:
-	    if ((This->options && ACO_AUTOSUGGEST) &&
+	    if ((This->options & ACO_AUTOSUGGEST) &&
 		((HWND)wParam != This->hwndListBox))
 	    {
 		ShowWindow(This->hwndListBox, SW_HIDE);

Modified: trunk/reactos/dll/win32/syssetup/wizard.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/wizard.…
==============================================================================
--- trunk/reactos/dll/win32/syssetup/wizard.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/syssetup/wizard.c [iso-8859-1] Thu Sep  1 13:18:22 2011
@@ -1693,8 +1693,8 @@
         {
           if (0 == LoadStringW(hDllInstance, IDS_UNKNOWN_ERROR,
                                UnknownError,
-                               sizeof(UnknownError) / sizeof(UnknownError[0] -
-                               20)))
+                               sizeof(UnknownError) / sizeof(UnknownError[0]) -
+                               20))
             {
               wcscpy(UnknownError, L"Unknown error");
             }

Modified: trunk/reactos/drivers/network/tdi/cte/events.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tdi/cte/ev…
==============================================================================
--- trunk/reactos/drivers/network/tdi/cte/events.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/network/tdi/cte/events.c [iso-8859-1] Thu Sep  1 13:18:22 2011
@@ -123,7 +123,7 @@
     KeAcquireSpinLock(&Event->Lock, &OldIrql);
 
     /* Make sure it is queued */
-    if (!Event->Queued);
+    if (!Event->Queued)
     {
         /* Mark it as queued and set optional context pointer */
         Event->Queued = TRUE;

Modified: trunk/reactos/lib/3rdparty/adns/src/transmit.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/adns/src/tran…
==============================================================================
--- trunk/reactos/lib/3rdparty/adns/src/transmit.c [iso-8859-1] (original)
+++ trunk/reactos/lib/3rdparty/adns/src/transmit.c [iso-8859-1] Thu Sep  1 13:18:22 2011
@@ -200,7 +200,7 @@
     ADNS_CAPTURE_ERRNO;
     adns__sigpipe_unprotect(qu->ads);
     if (wr < 0) {
-      if (!(errno == EAGAIN || EWOULDBLOCK || errno == EINTR || errno == ENOSPC ||
+      if (!(errno == EAGAIN || errno == EWOULDBLOCK || errno == EINTR || errno == ENOSPC
||
 	    errno == ENOBUFS || errno == ENOMEM)) {
 	adns__tcp_broken(ads,"write",strerror(errno));
 	return;

Modified: trunk/reactos/lib/3rdparty/stlport/src/locale.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/stlport/src/l…
==============================================================================
--- trunk/reactos/lib/3rdparty/stlport/src/locale.cpp [iso-8859-1] (original)
+++ trunk/reactos/lib/3rdparty/stlport/src/locale.cpp [iso-8859-1] Thu Sep  1 13:18:22
2011
@@ -208,7 +208,7 @@
 static void _Stl_loc_combine_names(_Locale_impl* L,
                                    const char* name1, const char* name2,
                                    locale::category c) {
-  if ((c & locale::all) == 0 || strcmp(name1, name1) == 0)
+  if ((c & locale::all) == 0 || strcmp(name1, name2) == 0)
     L->name = name1;
   else if ((c & locale::all) == locale::all)
     L->name = name2;

Modified: trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c?…
==============================================================================
--- trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] Thu Sep  1 13:18:22 2011
@@ -1174,7 +1174,7 @@
             // Check if this page is in the PFN database
             //
             Pfn1 = MiGetPfnEntry(*MdlPages);
-            if (Pfn1);
+            if (Pfn1)
             {
                 /* Get the current entry and reference count */
                 OldRefCount = Pfn1->u3.e2.ReferenceCount;