[ros-diffs] [tkreuzer] 64173: [NTOSKRNL] - Add some DPRINTs on errors - Silence a DPRINT - Only DPRINT on unimplemented affinity support on SMP builds

Author: tkreuzer
Date: Tue Sep 16 21:46:56 2014
New Revision: 64173

URL: http://svn.reactos.org/svn/reactos?rev=64173&view=rev
Log:
[NTOSKRNL]
- Add some DPRINTs on errors
- Silence a DPRINT
- Only DPRINT on unimplemented affinity support on SMP builds

Modified:
    branches/kernel-fun/reactos/ntoskrnl/io/iomgr/file.c
    branches/kernel-fun/reactos/ntoskrnl/ke/thrdschd.c
    branches/kernel-fun/reactos/ntoskrnl/lpc/connect.c
    branches/kernel-fun/reactos/ntoskrnl/mm/ARM3/expool.c

Modified: branches/kernel-fun/reactos/ntoskrnl/io/iomgr/file.c
URL:
http://svn.reactos.org/svn/reactos/branches/kernel-fun/reactos/ntoskrnl/io/…
==============================================================================
--- branches/kernel-fun/reactos/ntoskrnl/io/iomgr/file.c	[iso-8859-1] (original)
+++ branches/kernel-fun/reactos/ntoskrnl/io/iomgr/file.c	[iso-8859-1] Tue Sep 16 21:46:56
2014
@@ -1600,6 +1600,8 @@
     if (OpenPacket.ParseCheck != TRUE)
     {
         /* Parse failed */
+        DPRINT1("IopQueryAttributesFile failed for '%wZ' with
0x%lx\n",
+                ObjectAttributes->ObjectName, Status);
         return Status;
     }
     else
@@ -1822,6 +1824,7 @@
             /* Make sure we have extra parameters */
             if (!ExtraCreateParameters)
             {
+                DPRINT1("Invalid parameter: ExtraCreateParameters == 0!\n");
                 return STATUS_INVALID_PARAMETER;
             }
 
@@ -1835,6 +1838,7 @@
                 (CreateOptions & ~FILE_VALID_PIPE_OPTION_FLAGS))
             {
                 /* Invalid named pipe create */
+                DPRINT1("Invalid named pipe create\n");
                 return STATUS_INVALID_PARAMETER;
             }
         }
@@ -1843,6 +1847,7 @@
             /* Make sure we have extra parameters */
             if (!ExtraCreateParameters)
             {
+                DPRINT1("Invalid parameter: ExtraCreateParameters == 0!\n");
                 return STATUS_INVALID_PARAMETER;
             }
 
@@ -1853,6 +1858,7 @@
                 (CreateOptions & ~FILE_VALID_MAILSLOT_OPTION_FLAGS))
             {
                 /* Invalid mailslot create */
+                DPRINT1("Invalid mailslot create\n");
                 return STATUS_INVALID_PARAMETER;
             }
         }
@@ -1956,6 +1962,7 @@
             if (!OpenPacket->EaBuffer)
             {
                 ExFreePool(OpenPacket);
+                DPRINT1("Failed to allocate open packet EA buffer\n");
                 return STATUS_INSUFFICIENT_RESOURCES;
             }
 

Modified: branches/kernel-fun/reactos/ntoskrnl/ke/thrdschd.c
URL:
http://svn.reactos.org/svn/reactos/branches/kernel-fun/reactos/ntoskrnl/ke/…
==============================================================================
--- branches/kernel-fun/reactos/ntoskrnl/ke/thrdschd.c	[iso-8859-1] (original)
+++ branches/kernel-fun/reactos/ntoskrnl/ke/thrdschd.c	[iso-8859-1] Tue Sep 16 21:46:56
2014
@@ -696,8 +696,10 @@
     /* Check if system affinity is disabled */
     if (!Thread->SystemAffinityActive)
     {
+#ifdef CONFIG_SMP
         /* FIXME: TODO */
         DPRINT1("Affinity support disabled!\n");
+#endif
     }
 
     /* Return the old affinity */

Modified: branches/kernel-fun/reactos/ntoskrnl/lpc/connect.c
URL:
http://svn.reactos.org/svn/reactos/branches/kernel-fun/reactos/ntoskrnl/lpc…
==============================================================================
--- branches/kernel-fun/reactos/ntoskrnl/lpc/connect.c	[iso-8859-1] (original)
+++ branches/kernel-fun/reactos/ntoskrnl/lpc/connect.c	[iso-8859-1] Tue Sep 16 21:46:56
2014
@@ -139,7 +139,11 @@
                                      PreviousMode,
                                      NULL,
                                      (PVOID *)&Port);
-    if (!NT_SUCCESS(Status)) return Status;
+    if (!NT_SUCCESS(Status))
+    {
+        DPRINT1("Failed to reference port '%wZ': 0x%lx\n", PortName,
Status);
+        return Status;
+    }
 
     /* This has to be a connection port */
     if ((Port->Flags & LPCP_PORT_TYPE_MASK) != LPCP_CONNECTION_PORT)
@@ -352,7 +356,7 @@
     ConnectMessage->SectionToMap = SectionToMap;
 
     /* Set the data for the connection request message */
-    Message->Request.u1.s1.DataLength = (CSHORT)ConnectionInfoLength + 
+    Message->Request.u1.s1.DataLength = (CSHORT)ConnectionInfoLength +
                                          sizeof(LPCP_CONNECTION_MESSAGE);
     Message->Request.u1.s1.TotalLength = sizeof(LPCP_MESSAGE) +
                                          Message->Request.u1.s1.DataLength;

Modified: branches/kernel-fun/reactos/ntoskrnl/mm/ARM3/expool.c
URL:
http://svn.reactos.org/svn/reactos/branches/kernel-fun/reactos/ntoskrnl/mm/…
==============================================================================
--- branches/kernel-fun/reactos/ntoskrnl/mm/ARM3/expool.c	[iso-8859-1] (original)
+++ branches/kernel-fun/reactos/ntoskrnl/mm/ARM3/expool.c	[iso-8859-1] Tue Sep 16 21:46:56
2014
@@ -1336,7 +1336,7 @@
             InterlockedIncrementUL(&ExpPoolBigEntriesInUse);
             if ((i >= 16) && (ExpPoolBigEntriesInUse > (TableSize / 4)))
             {
-                DPRINT1("Should attempt expansion since we now have %lu
entries\n",
+                DPRINT("Should attempt expansion since we now have %lu
entries\n",
                         ExpPoolBigEntriesInUse);
             }