[ros-diffs] [hbelusca] 59258: [WIN32K] Make F12 key working again on ReactOS. The problem was that it was hardcoded for activating a debugger and since we currently didn't activated a debugger, then nothing ha...

Author: hbelusca
Date: Tue Jun 18 23:51:14 2013
New Revision: 59258

URL: http://svn.reactos.org/svn/reactos?rev=59258&view=rev
Log:
[WIN32K]
Make F12 key working again on ReactOS. The problem was that it was hardcoded for
activating a debugger and since we currently didn't activated a debugger, then nothing
happened when pressing F12.
This key is in fact the default key (under some assumptions) for the UserDebuggerHotKey
option, which should be read from the registry. Temporarily disable the checking code
until someone implements a proper code for that.

Modified:
    trunk/reactos/win32ss/user/ntuser/hotkey.c

Modified: trunk/reactos/win32ss/user/ntuser/hotkey.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/hotkey…
==============================================================================
--- trunk/reactos/win32ss/user/ntuser/hotkey.c	[iso-8859-1] (original)
+++ trunk/reactos/win32ss/user/ntuser/hotkey.c	[iso-8859-1] Tue Jun 18 23:51:14 2013
@@ -18,7 +18,18 @@
 
 /* GLOBALS *******************************************************************/
 
-/* Hardcoded hotkeys. See http://ivanlef0u.fr/repo/windoz/VI20051005.html */
+/*
+ * Hardcoded hotkeys. See http://ivanlef0u.fr/repo/windoz/VI20051005.html
+ * or http://repo.meh.or.id/Windows/VI20051005.html .
+ *
+ * NOTE: The (Shift-)F12 keys are used only for the "UserDebuggerHotKey"
setting
+ * which enables setting a key shortcut which, when pressed, establishes a
+ * breakpoint in the code being debugged:
+ * see http://technet.microsoft.com/en-us/library/cc786263(v=ws.10).aspx
+ * and http://flylib.com/books/en/4.441.1.33/1/ for more details.
+ * By default the key is VK-F12 on a 101-key keyboard, and is VK_SUBTRACT
+ * (hyphen / substract sign) on a 82-key keyboard.
+ */
 /*                   thread hwnd  modifiers  vk      id  next */
 HOT_KEY hkF12 =      {NULL, NULL, 0,         VK_F12, IDHK_F12,      NULL};
 HOT_KEY hkShiftF12 = {NULL, NULL, MOD_SHIFT, VK_F12, IDHK_SHIFTF12, &hkF12};
@@ -171,7 +182,7 @@
         {
             TRACE("Hot key pressed (hWnd %p, id %d)\n", pHotKey->hWnd,
pHotKey->id);
 
-            /* WIN and F12 keys are hardcoded here. See:
http://ivanlef0u.fr/repo/windoz/VI20051005.html */
+            /* WIN and F12 keys are hardcoded here. See comments on top of this file. */
             if (pHotKey == &hkWinKey)
             {
                 if(bWinHotkeyActive == TRUE)
@@ -180,10 +191,12 @@
                     bWinHotkeyActive = FALSE;
                 }
             }
+#if 0 /* FIXME: See comment about "UserDebuggerHotKey" on top of this file. */
             else if (pHotKey == &hkF12 || pHotKey == &hkShiftF12)
             {
                 //co_ActivateDebugger(); // FIXME
             }
+#endif
             else if (pHotKey->id == IDHK_REACTOS && !pHotKey->pThread) //
FIXME: Those hotkeys doesn't depend on RegisterHotKey
             {
                 UserPostMessage(pHotKey->hWnd, WM_SYSCOMMAND, SC_HOTKEY,
(LPARAM)pHotKey->hWnd);