[ros-diffs] [reactos] 105/158: [WINESYNC] reg: Prevent buffer over-read when querying REG_NONE values with no data.

[winesync]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=64312c4fd44d2d1892d90…

commit 64312c4fd44d2d1892d9073c27d826b17b55af8d
Author:     winesync <ros-dev(a)reactos.org>
AuthorDate: Sun Jan 16 21:17:20 2022 +0100
Commit:     Thomas Csovcsity <thc.fr13nd(a)gmail.com>
CommitDate: Sun Jun 19 13:06:35 2022 +0200

    [WINESYNC] reg: Prevent buffer over-read when querying REG_NONE values with no data.
    
    Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com>
    Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>
    
    wine commit id 60c8dfdd0bbaff4a2369f884ec1a553a06735676 by Hugh McMaster
<hugh.mcmaster(a)outlook.com>
---
 base/applications/cmdutils/reg/query.c | 8 ++++++++
 sdk/tools/winesync/reg.cfg             | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/base/applications/cmdutils/reg/query.c
b/base/applications/cmdutils/reg/query.c
index 7e42719faf9..4886fb84bc1 100644
--- a/base/applications/cmdutils/reg/query.c
+++ b/base/applications/cmdutils/reg/query.c
@@ -50,7 +50,15 @@ static WCHAR *reg_data_to_wchar(DWORD type, const BYTE *src, DWORD
size_bytes)
             WCHAR *ptr;
 
             buffer = malloc((size_bytes * 2 + 1) * sizeof(WCHAR));
+
+            if (!size_bytes)
+            {
+                *buffer = 0;
+                break;
+            }
+
             ptr = buffer;
+
             for (i = 0; i < size_bytes; i++)
                 ptr += swprintf(ptr, 3, L"%02X", src[i]);
             break;
diff --git a/sdk/tools/winesync/reg.cfg b/sdk/tools/winesync/reg.cfg
index 0922b41dd80..3b85d966bea 100644
--- a/sdk/tools/winesync/reg.cfg
+++ b/sdk/tools/winesync/reg.cfg
@@ -4,4 +4,4 @@ directories:
 files:
   programs/reg/resource.h: base/applications/cmdutils/reg/resource.h
 tags:
-  wine: 1dd785d1490f64c33e89003453f7c82292d185d5
+  wine: 60c8dfdd0bbaff4a2369f884ec1a553a06735676