Author: akhaldi
Date: Thu Aug 1 14:29:03 2013
New Revision: 59609
URL:
http://svn.reactos.org/svn/reactos?rev=59609&view=rev
Log:
[MOUNTMGR]
* Properly mark some unreferenced parameters as such.
Modified:
trunk/reactos/drivers/filters/mountmgr/database.c
trunk/reactos/drivers/filters/mountmgr/device.c
trunk/reactos/drivers/filters/mountmgr/mountmgr.c
trunk/reactos/drivers/filters/mountmgr/notify.c
trunk/reactos/drivers/filters/mountmgr/symlink.c
Modified: trunk/reactos/drivers/filters/mountmgr/database.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/d…
==============================================================================
--- trunk/reactos/drivers/filters/mountmgr/database.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filters/mountmgr/database.c [iso-8859-1] Thu Aug 1 14:29:03
2013
@@ -298,6 +298,9 @@
{
PMOUNTDEV_UNIQUE_ID UniqueId = Context;
+ UNREFERENCED_PARAMETER(ValueType);
+ UNREFERENCED_PARAMETER(EntryContext);
+
/* Ensure it matches, and delete */
if ((UniqueId->UniqueIdLength == ValueLength) &&
(RtlCompareMemory(UniqueId->UniqueId, ValueData, ValueLength) ==
@@ -364,6 +367,7 @@
NTAPI
ReconcileThisDatabaseWithMasterWorker(IN PVOID Parameter)
{
+ UNREFERENCED_PARAMETER(Parameter);
return;
}
@@ -386,6 +390,8 @@
PDEVICE_EXTENSION DeviceExtension;
OBJECT_ATTRIBUTES ObjectAttributes;
+ UNREFERENCED_PARAMETER(DeviceObject);
+
InitializeObjectAttributes(&ObjectAttributes,
&SafeVolumes,
OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE,
@@ -508,6 +514,8 @@
OBJECT_ATTRIBUTES ObjectAttributes;
PFILE_NAME_INFORMATION FileNameInfo;
PREPARSE_DATA_BUFFER ReparseDataBuffer;
+
+ UNREFERENCED_PARAMETER(ReparsePointInformation);
if (!FileName)
{
@@ -902,6 +910,8 @@
OBJECT_ATTRIBUTES ObjectAttributes, MigrateAttributes;
#define TEMP_BUFFER_SIZE 0x200
+ UNREFERENCED_PARAMETER(DeviceObject);
+
/* Extract context */
WorkItem = Context;
DeviceInformation = WorkItem->DeviceInformation;
@@ -1220,6 +1230,10 @@
PMOUNTDEV_UNIQUE_ID IntUniqueId;
PMOUNTDEV_UNIQUE_ID * UniqueId;
+ UNREFERENCED_PARAMETER(ValueName);
+ UNREFERENCED_PARAMETER(ValueType);
+ UNREFERENCED_PARAMETER(EntryContext);
+
/* Sanity check */
if (ValueLength >= 0x10000)
{
@@ -1464,6 +1478,8 @@
PMOUNTDEV_UNIQUE_ID UniqueId;
UNICODE_STRING RegistryEntry;
+ UNREFERENCED_PARAMETER(EntryContext);
+
if (ValueType != REG_BINARY)
{
return STATUS_SUCCESS;
@@ -1527,6 +1543,8 @@
{
PMOUNTDEV_UNIQUE_ID UniqueId = Context;
+ UNREFERENCED_PARAMETER(EntryContext);
+
/* Ensure we have correct input */
if (ValueName[0] != L'#' || ValueType != REG_BINARY ||
UniqueId->UniqueIdLength != ValueLength)
Modified: trunk/reactos/drivers/filters/mountmgr/device.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/d…
==============================================================================
--- trunk/reactos/drivers/filters/mountmgr/device.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filters/mountmgr/device.c [iso-8859-1] Thu Aug 1 14:29:03 2013
@@ -292,6 +292,8 @@
PDEVICE_INFORMATION DeviceInformation;
NTSTATUS ArrivalStatus, Status = STATUS_SUCCESS;
+ UNREFERENCED_PARAMETER(Irp);
+
/* No offline volumes, nothing more to do */
if (IsListEmpty(&(DeviceExtension->OfflineDeviceListHead)))
{
@@ -690,6 +692,10 @@
UNICODE_STRING ValueString;
PUNICODE_STRING SystemVolumeName;
+ UNREFERENCED_PARAMETER(ValueName);
+ UNREFERENCED_PARAMETER(ValueLength);
+ UNREFERENCED_PARAMETER(EntryContext);
+
if (ValueType != REG_SZ)
{
return STATUS_SUCCESS;
@@ -819,6 +825,8 @@
MountMgrQueryDosVolumePath(IN PDEVICE_EXTENSION DeviceExtension,
IN PIRP Irp)
{
+ UNREFERENCED_PARAMETER(DeviceExtension);
+ UNREFERENCED_PARAMETER(Irp);
return STATUS_NOT_IMPLEMENTED;
}
@@ -826,6 +834,8 @@
MountMgrQueryDosVolumePaths(IN PDEVICE_EXTENSION DeviceExtension,
IN PIRP Irp)
{
+ UNREFERENCED_PARAMETER(DeviceExtension);
+ UNREFERENCED_PARAMETER(Irp);
return STATUS_NOT_IMPLEMENTED;
}
@@ -1460,6 +1470,9 @@
IN PIRP Irp,
IN NTSTATUS LockStatus)
{
+ UNREFERENCED_PARAMETER(DeviceExtension);
+ UNREFERENCED_PARAMETER(Irp);
+ UNREFERENCED_PARAMETER(LockStatus);
return STATUS_NOT_IMPLEMENTED;
}
@@ -1468,6 +1481,9 @@
IN PIRP Irp,
IN NTSTATUS LockStatus)
{
+ UNREFERENCED_PARAMETER(DeviceExtension);
+ UNREFERENCED_PARAMETER(Irp);
+ UNREFERENCED_PARAMETER(LockStatus);
return STATUS_NOT_IMPLEMENTED;
}
Modified: trunk/reactos/drivers/filters/mountmgr/mountmgr.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/m…
==============================================================================
--- trunk/reactos/drivers/filters/mountmgr/mountmgr.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filters/mountmgr/mountmgr.c [iso-8859-1] Thu Aug 1 14:29:03
2013
@@ -816,6 +816,8 @@
PDEVICE_INFORMATION DeviceInformation;
PSAVED_LINK_INFORMATION SavedLinkInformation;
+ UNREFERENCED_PARAMETER(DriverObject);
+
/* Don't get notification any longer */
IoUnregisterShutdownNotification(gdeviceObject);
@@ -1663,6 +1665,8 @@
PIO_STACK_LOCATION Stack;
NTSTATUS Status = STATUS_SUCCESS;
+ UNREFERENCED_PARAMETER(DeviceObject);
+
Stack = IoGetCurrentIrpStackLocation(Irp);
/* Allow driver opening for communication
@@ -1688,6 +1692,8 @@
MountMgrCancel(IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp)
{
+ UNREFERENCED_PARAMETER(DeviceObject);
+
RemoveEntryList(&(Irp->Tail.Overlay.ListEntry));
IoReleaseCancelSpinLock(Irp->CancelIrql);
Modified: trunk/reactos/drivers/filters/mountmgr/notify.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/n…
==============================================================================
--- trunk/reactos/drivers/filters/mountmgr/notify.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filters/mountmgr/notify.c [iso-8859-1] Thu Aug 1 14:29:03 2013
@@ -511,6 +511,8 @@
PMOUNTDEV_UNIQUE_ID OldUniqueId, NewUniqueId;
PMOUNTDEV_UNIQUE_ID_CHANGE_NOTIFY_OUTPUT UniqueIdChange;
+ UNREFERENCED_PARAMETER(DeviceObject);
+
/* Validate worker */
if (!NT_SUCCESS(WorkItem->Irp->IoStatus.Status))
{
@@ -566,6 +568,9 @@
IN PVOID Context)
{
PUNIQUE_ID_WORK_ITEM WorkItem = Context;
+
+ UNREFERENCED_PARAMETER(DeviceObject);
+ UNREFERENCED_PARAMETER(Irp);
/* Simply queue the work item */
IoQueueWorkItem(WorkItem->WorkItem,
Modified: trunk/reactos/drivers/filters/mountmgr/symlink.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/s…
==============================================================================
--- trunk/reactos/drivers/filters/mountmgr/symlink.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filters/mountmgr/symlink.c [iso-8859-1] Thu Aug 1 14:29:03
2013
@@ -119,6 +119,8 @@
NTSTATUS Status;
UNICODE_STRING GlobalName;
+ UNREFERENCED_PARAMETER(DeviceName);
+
/* First create the global string */
Status = CreateStringWithGlobal(DosName, &GlobalName);
if (!NT_SUCCESS(Status))
@@ -529,6 +531,8 @@
BOOLEAN WriteNew;
RTL_QUERY_REGISTRY_TABLE QueryTable[2];
+ UNREFERENCED_PARAMETER(DeviceExtension);
+
/* First of all, count links */
RtlZeroMemory(QueryTable, sizeof(QueryTable));
QueryTable[0].QueryRoutine = SymbolicLinkNamesFromUniqueIdCount;