[ros-diffs] [akhaldi] 61940: [SERENUM] * Do not include debug.h into the main header. * Improve the GUIDs situation. * Improve header inclusions. CORE-7716

Author: akhaldi
Date: Mon Feb  3 00:13:57 2014
New Revision: 61940

URL: http://svn.reactos.org/svn/reactos?rev=61940&view=rev
Log:
[SERENUM]
* Do not include debug.h into the main header.
* Improve the GUIDs situation.
* Improve header inclusions.
CORE-7716

Added:
    trunk/reactos/drivers/serial/serenum/guid.c   (with props)
Modified:
    trunk/reactos/drivers/serial/serenum/CMakeLists.txt
    trunk/reactos/drivers/serial/serenum/detect.c
    trunk/reactos/drivers/serial/serenum/fdo.c
    trunk/reactos/drivers/serial/serenum/misc.c
    trunk/reactos/drivers/serial/serenum/pdo.c
    trunk/reactos/drivers/serial/serenum/serenum.c
    trunk/reactos/drivers/serial/serenum/serenum.h

Modified: trunk/reactos/drivers/serial/serenum/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serenum/CMa…
==============================================================================
--- trunk/reactos/drivers/serial/serenum/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/serial/serenum/CMakeLists.txt	[iso-8859-1] Mon Feb  3 00:13:57
2014
@@ -5,6 +5,7 @@
     misc.c
     pdo.c
     serenum.c
+    guid.c
     serenum.rc)
 
 add_pch(serenum serenum.h)

Modified: trunk/reactos/drivers/serial/serenum/detect.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serenum/det…
==============================================================================
--- trunk/reactos/drivers/serial/serenum/detect.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/serial/serenum/detect.c	[iso-8859-1] Mon Feb  3 00:13:57 2014
@@ -10,6 +10,8 @@
  */
 
 #include "serenum.h"
+
+#include <debug.h>
 
 static NTSTATUS
 DeviceIoControl(

Modified: trunk/reactos/drivers/serial/serenum/fdo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serenum/fdo…
==============================================================================
--- trunk/reactos/drivers/serial/serenum/fdo.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/serial/serenum/fdo.c	[iso-8859-1] Mon Feb  3 00:13:57 2014
@@ -8,6 +8,8 @@
  */
 
 #include "serenum.h"
+
+#include <debug.h>
 
 NTSTATUS NTAPI
 SerenumAddDevice(

Added: trunk/reactos/drivers/serial/serenum/guid.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serenum/gui…
==============================================================================
--- trunk/reactos/drivers/serial/serenum/guid.c	(added)
+++ trunk/reactos/drivers/serial/serenum/guid.c	[iso-8859-1] Mon Feb  3 00:13:57 2014
@@ -0,0 +1,7 @@
+/* DO NOT USE THE PRECOMPILED HEADER FOR THIS FILE! */
+
+#include <ntdef.h>
+#include <initguid.h>
+#include <ntddser.h>
+
+/* NO CODE HERE, THIS IS JUST REQUIRED FOR THE GUID DEFINITIONS */

Propchange: trunk/reactos/drivers/serial/serenum/guid.c
------------------------------------------------------------------------------
    svn:eol-style = native

Modified: trunk/reactos/drivers/serial/serenum/misc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serenum/mis…
==============================================================================
--- trunk/reactos/drivers/serial/serenum/misc.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/serial/serenum/misc.c	[iso-8859-1] Mon Feb  3 00:13:57 2014
@@ -8,6 +8,8 @@
  */
 
 #include "serenum.h"
+
+#include <debug.h>
 
 static IO_COMPLETION_ROUTINE ForwardIrpAndWaitCompletion;
 

Modified: trunk/reactos/drivers/serial/serenum/pdo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serenum/pdo…
==============================================================================
--- trunk/reactos/drivers/serial/serenum/pdo.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/serial/serenum/pdo.c	[iso-8859-1] Mon Feb  3 00:13:57 2014
@@ -8,6 +8,8 @@
  */
 
 #include "serenum.h"
+
+#include <debug.h>
 
 static NTSTATUS
 SerenumPdoStartDevice(

Modified: trunk/reactos/drivers/serial/serenum/serenum.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serenum/ser…
==============================================================================
--- trunk/reactos/drivers/serial/serenum/serenum.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/serial/serenum/serenum.c	[iso-8859-1] Mon Feb  3 00:13:57 2014
@@ -7,8 +7,9 @@
  * PROGRAMMERS:     Hervé Poussineau (hpoussin(a)reactos.org)
  */
 
-#define INITGUID
 #include "serenum.h"
+
+#include <debug.h>
 
 static DRIVER_DISPATCH SerenumPnp;
 static DRIVER_DISPATCH IrpStub;

Modified: trunk/reactos/drivers/serial/serenum/serenum.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serenum/ser…
==============================================================================
--- trunk/reactos/drivers/serial/serenum/serenum.h	[iso-8859-1] (original)
+++ trunk/reactos/drivers/serial/serenum/serenum.h	[iso-8859-1] Mon Feb  3 00:13:57 2014
@@ -8,11 +8,7 @@
  */
 
 #include <ntifs.h>
-#include <ntddk.h>
 #include <ntddser.h>
-#include <stdio.h>
-#include <stdarg.h>
-#include <debug.h>
 
 typedef enum
 {