[ros-diffs] [reactos] 01/02: [SETUPLIB] SetupCreateSingleDirectory(): Remove '\.' trailing sequence handling hack

[Hermès Bélusca-Maïto]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=00ddae49d54ae74ae7e18…

commit 00ddae49d54ae74ae7e1858b9f51a9b58d455c4c
Author:     Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
AuthorDate: Thu Aug 22 18:07:18 2024 +0200
Commit:     Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
CommitDate: Thu Aug 22 20:40:34 2024 +0200

    [SETUPLIB] SetupCreateSingleDirectory(): Remove '\.' trailing sequence
handling hack
    
    It was introduced in commit 703eb5e8c9 (r7756) in order to hack around
    the "dot"-path added in the reactos.dff generator file by the earlier
    commit 3bd689f185 (r7269).
    Its aim was to describe the installation directory itself, instead of
    one of its sub-directories.
    
    That _invalid_ "dot"-path was removed later by commit 027e2bfa3a (r15423);
    however the '\.' hack stayed for quite a while in our code.
    
    The correct way to describe the installation directory itself is to use
    instead "\", compatible with Windows' setup, as was originally done in
    txtsetup.sif, and fixed in reactos.dff(.in) in commit 97bb83fcd9 (r66604).
---
 base/setup/lib/utils/filesup.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/base/setup/lib/utils/filesup.c b/base/setup/lib/utils/filesup.c
index 0ecf3fdcc32..5ddd641be34 100644
--- a/base/setup/lib/utils/filesup.c
+++ b/base/setup/lib/utils/filesup.c
@@ -38,14 +38,6 @@ SetupCreateSingleDirectory(
     if (!RtlCreateUnicodeString(&PathName, DirectoryName))
         return STATUS_NO_MEMORY;
 
-    if (PathName.Length > sizeof(WCHAR) &&
-        PathName.Buffer[PathName.Length / sizeof(WCHAR) - 2] == L'\\'
&&
-        PathName.Buffer[PathName.Length / sizeof(WCHAR) - 1] == L'.')
-    {
-        PathName.Length -= sizeof(WCHAR);
-        PathName.Buffer[PathName.Length / sizeof(WCHAR)] = UNICODE_NULL;
-    }
-
     if (PathName.Length > sizeof(WCHAR) &&
         PathName.Buffer[PathName.Length / sizeof(WCHAR) - 1] == L'\\')
     {