[ros-diffs] [hbelusca] 70413: [XDK] Correctly fix the definition of DRIVER_FS_NOTIFICATION (done the same way as the other DRIVER_xxx "callback" functions; by the way you'll notice they are all NTAPI aka. __st...

Author: hbelusca
Date: Wed Dec 23 16:15:08 2015
New Revision: 70413
URL: http://svn.reactos.org/svn/reactos?rev=70413&view=rev
Log:
[XDK]
Correctly fix the definition of DRIVER_FS_NOTIFICATION (done the same way as the other
DRIVER_xxx "callback" functions; by the way you'll notice they are all NTAPI
aka. __stdcall. This is not explicitely mentioned in the W(D)DK, because MS supposes you
compile all your kernel-mode code in stdcall convention, the WDK environment coming with
preset default compiler switches enabling that. But if you try changing them, you'll
run into big troubles. In our headers on the contrary we explicitely mention the calling
conventions).
[FLTMGR]
Fix FltpFsNotification to adhere to the correct DRIVER_FS_NOTIFICATION definition.
Addendum to r70410.
Modified:
    trunk/reactos/drivers/fs_minifilter/fltmgr/Interface.c
    trunk/reactos/include/xdk/iotypes.h
Modified: trunk/reactos/drivers/fs_minifilter/fltmgr/Interface.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/fs_minifilter/fltm…
==============================================================================
--- trunk/reactos/drivers/fs_minifilter/fltmgr/Interface.c      [iso-8859-1] (original)
+++ trunk/reactos/drivers/fs_minifilter/fltmgr/Interface.c      [iso-8859-1] Wed Dec 23
16:15:08 2015
@@ -66,6 +66,7 @@
 DRIVER_FS_NOTIFICATION FltpFsNotification;
 VOID
+NTAPI
 FltpFsNotification(
     _In_ PDEVICE_OBJECT DeviceObject,
     _In_ BOOLEAN FsActive
@@ -586,6 +587,7 @@
 DRIVER_FS_NOTIFICATION FltpFsNotification;
 VOID
+NTAPI
 FltpFsNotification(_In_ PDEVICE_OBJECT DeviceObject,
                    _In_ BOOLEAN FsActive)
 {
Modified: trunk/reactos/include/xdk/iotypes.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/iotypes.h?rev=…
==============================================================================
--- trunk/reactos/include/xdk/iotypes.h [iso-8859-1] (original)
+++ trunk/reactos/include/xdk/iotypes.h [iso-8859-1] Wed Dec 23 16:15:08 2015
@@ -6939,17 +6939,11 @@
 #define IO_STOP_ON_SYMLINK                  0x0008
 #define IO_MM_PAGING_FILE                   0x0010
-//typedef VOID
-//( *PDRIVER_FS_NOTIFICATION) (
-//  _In_ PDEVICE_OBJECT DeviceObject,
-//  _In_ BOOLEAN FsActive);
-
-typedef
-VOID
-DRIVER_FS_NOTIFICATION(
-    _In_ PDEVICE_OBJECT DeviceObject,
-    _In_ BOOLEAN FsActive
-);
+_Function_class_(DRIVER_FS_NOTIFICATION)
+typedef VOID
+(NTAPI DRIVER_FS_NOTIFICATION)(
+  _In_ PDEVICE_OBJECT DeviceObject,
+  _In_ BOOLEAN FsActive);
 typedef DRIVER_FS_NOTIFICATION *PDRIVER_FS_NOTIFICATION;
 typedef enum _FS_FILTER_SECTION_SYNC_TYPE {