[ros-diffs] [reactos] 01/01: [WIN32SS] Remove an ambiguous assert entirely CORE-16738

[Joachim Henze]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=bf164353035a2bc0f0d1d…

commit bf164353035a2bc0f0d1d679d09f2e4076498fa1
Author:     Joachim Henze <Joachim.Henze(a)reactos.org>
AuthorDate: Sat Feb 5 01:06:15 2022 +0100
Commit:     Joachim Henze <Joachim.Henze(a)reactos.org>
CommitDate: Sat Feb 5 01:06:15 2022 +0100

    [WIN32SS] Remove an ambiguous assert entirely CORE-16738
    
    It popped up very reliably when performing git-clone of the ros sources
    while having the taskmgr open in the processes-tab.
    Or when building 'ninja bootcd -j1' while having the taskmgr open in the
processes-tab.
    
    It is always possible to ignore it and then continue using ros for days without
    noticing any side effects.
    James Tabor judged the assert to have a "questionable logic".
    Giannis who once added it, was also ok with commenting it.
    
    His words:
    This assertion isn't something fatal,
    the worst thing that can happen from continuing on it would be
    to make the thread get awake more times than it should.
    
    It was commented out already on 2020-04-21 via
    0.4.14-dev-1519-g 87f6c82d854583f71546841f4432f57e4a2d6c99
---
 win32ss/user/ntuser/misc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/win32ss/user/ntuser/misc.c b/win32ss/user/ntuser/misc.c
index 00393431603..8fa8b0edb4d 100644
--- a/win32ss/user/ntuser/misc.c
+++ b/win32ss/user/ntuser/misc.c
@@ -749,8 +749,6 @@ void UserDbgAssertThreadInfo(BOOL showCaller)
     ASSERT(pci->ulClientDelta == DesktopHeapGetUserDelta());
     if (pti->pcti && pci->pDeskInfo)
         ASSERT(pci->pClientThreadInfo == (PVOID)((ULONG_PTR)pti->pcti -
pci->ulClientDelta));
-    //if (pti->pcti && IsListEmpty(&pti->SentMessagesListHead))
-    //    ASSERT((pti->pcti->fsChangeBits & QS_SENDMESSAGE) == 0);
     if (pti->KeyboardLayout)
         ASSERT(pci->hKL == pti->KeyboardLayout->hkl);
     if(pti->rpdesk != NULL)