[ros-diffs] [reactos] 01/01: [Printing] Fix Typos and Test Regressions

[James Tabor]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=3ca217621dc88cc9c584f…

commit 3ca217621dc88cc9c584f9da9ba47f34622c40f9
Author:     James Tabor <james.tabor(a)reactos.org>
AuthorDate: Tue Sep 8 13:15:16 2020 -0500
Commit:     James Tabor <james.tabor(a)reactos.org>
CommitDate: Tue Sep 8 13:15:16 2020 -0500

    [Printing] Fix Typos and Test Regressions
    
    Fix WinSpool API regressions.
    Fix typos and debug prints.
---
 win32ss/printing/base/winspool/printers.c  | 4 +++-
 win32ss/printing/monitors/localmon/xcv.c   | 4 ++--
 win32ss/printing/providers/localspl/main.c | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/win32ss/printing/base/winspool/printers.c
b/win32ss/printing/base/winspool/printers.c
index dfff8223a87..31865fd7afc 100644
--- a/win32ss/printing/base/winspool/printers.c
+++ b/win32ss/printing/base/winspool/printers.c
@@ -582,7 +582,7 @@ DeviceCapabilitiesW(LPCWSTR pDevice, LPCWSTR pPort, WORD fwCapability,
LPWSTR pO
     {
         if (!IsValidDevmodeNoSizeW( (PDEVMODEW)pDevMode ) )
         {
-            ERR("DeviceCapabilitiesW : Devode Invalid");
+            ERR("DeviceCapabilitiesW : Devode Invalid\n");
             return -1;
         }
     }
@@ -916,7 +916,9 @@ DocumentPropertySheets( PPROPSHEETUI_INFO pCPSUIInfo, LPARAM lparam )
 
                 if ( fpDocumentPropertySheets )
                 {
+                    FIXME("DPS : fpDocumentPropertySheets(%p, 0x%lx) pdmOut
%p\n", pCPSUIInfo, lparam, pdphdr->pdmOut);
                     Result = fpDocumentPropertySheets( pCPSUIInfo, lparam );
+                    FIXME("DPS : fpDocumentPropertySheets result %d cbOut
%d\n",Result, pdphdr->cbOut);
                 }
                 else
                 {
diff --git a/win32ss/printing/monitors/localmon/xcv.c
b/win32ss/printing/monitors/localmon/xcv.c
index 25635c37e7d..1aeb4abe466 100644
--- a/win32ss/printing/monitors/localmon/xcv.c
+++ b/win32ss/printing/monitors/localmon/xcv.c
@@ -513,7 +513,7 @@ LocalmonXcvClosePort(HANDLE hXcv)
     }
 
     // Remove it from the list and free the memory.
-    LeaveCriticalSection(&pXcv->pLocalmon->Section);
+    EnterCriticalSection(&pXcv->pLocalmon->Section);
     RemoveEntryList(&pXcv->Entry);
     LeaveCriticalSection(&pXcv->pLocalmon->Section);
     DllFreeSplMem(pXcv);
@@ -570,7 +570,7 @@ LocalmonXcvOpenPort(HANDLE hMonitor, PCWSTR pwszObject, ACCESS_MASK
GrantedAcces
     PLOCALMON_HANDLE pLocalmon = (PLOCALMON_HANDLE)hMonitor;
     PLOCALMON_XCV pXcv;
 
-    TRACE("LocalmonXcvOpenPort(%p, %S, %lu, %p)\n", hMonitor, pwszObject,
GrantedAccess, phXcv);
+    FIXME("LocalmonXcvOpenPort(%p, %S, %lu, %p)\n", hMonitor, pwszObject,
GrantedAccess, phXcv);
 
     // Sanity checks
     if (!pLocalmon || !phXcv)
diff --git a/win32ss/printing/providers/localspl/main.c
b/win32ss/printing/providers/localspl/main.c
index ba563a7c511..a8d6118e1bc 100644
--- a/win32ss/printing/providers/localspl/main.c
+++ b/win32ss/printing/providers/localspl/main.c
@@ -25,9 +25,9 @@ const DWORD dwSpoolerMinorVersion = 0;
 const WCHAR wszDefaultDocumentName[] = L"Local Downlevel Document";
 
 PCWSTR wszPrintProviderInfo[3] = {
-    L"Windows NT Local Printers",           // Description
     L"Windows NT Local Print Providor",     // Name
-    L"Locally connected Printers"           // Comment
+    L"Locally connected Printers",          // Comment
+    L"Windows NT Local Printers"            // Description
 };
 
 // Local Constants