[ros-diffs] [hbelusca] 58824: [KDCOM] - Use the UCHAR type directly instead of using a typedef for defining BYTE. - A little bit of header reorganization.

Author: hbelusca
Date: Sun Apr 21 23:56:15 2013
New Revision: 58824

URL: http://svn.reactos.org/svn/reactos?rev=58824&view=rev
Log:
[KDCOM]
- Use the UCHAR type directly instead of using a typedef for defining BYTE.
- A little bit of header reorganization.

Modified:
    trunk/reactos/drivers/base/kddll/kdcom.c
    trunk/reactos/drivers/base/kddll/kddll.c
    trunk/reactos/drivers/base/kddll/kddll.h
    trunk/reactos/drivers/base/kddll/kdserial.c

Modified: trunk/reactos/drivers/base/kddll/kdcom.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kddll/kdcom.c…
==============================================================================
--- trunk/reactos/drivers/base/kddll/kdcom.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/base/kddll/kdcom.c [iso-8859-1] Sun Apr 21 23:56:15 2013
@@ -8,6 +8,9 @@
 
 #include "kddll.h"
 #include <cportlib/cportlib.h>
+
+long atol(const char *str);
+
 
 /* Serial debug connection */
 #define DEFAULT_DEBUG_PORT      2 /* COM2 */
@@ -166,7 +169,7 @@
 
 VOID
 NTAPI
-KdpSendByte(IN BYTE Byte)
+KdpSendByte(IN UCHAR Byte)
 {
     /* Send the byte */
     CpPutByte(&KdDebugComPort, Byte);
@@ -174,7 +177,7 @@
 
 KDP_STATUS
 NTAPI
-KdpPollByte(OUT PBYTE OutByte)
+KdpPollByte(OUT PUCHAR OutByte)
 {
     /* Poll the byte */
     return (CpGetByte(&KdDebugComPort, OutByte, FALSE) == CP_GET_SUCCESS
@@ -184,7 +187,7 @@
 
 KDP_STATUS
 NTAPI
-KdpReceiveByte(OUT PBYTE OutByte)
+KdpReceiveByte(OUT PUCHAR OutByte)
 {
     /* Get the byte */
     return (CpGetByte(&KdDebugComPort, OutByte, TRUE) == CP_GET_SUCCESS

Modified: trunk/reactos/drivers/base/kddll/kddll.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kddll/kddll.c…
==============================================================================
--- trunk/reactos/drivers/base/kddll/kddll.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/base/kddll/kddll.c [iso-8859-1] Sun Apr 21 23:56:15 2013
@@ -415,3 +415,4 @@
     CurrentPacketId &= ~SYNC_PACKET_ID;
 }
 
+/* EOF */

Modified: trunk/reactos/drivers/base/kddll/kddll.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kddll/kddll.h…
==============================================================================
--- trunk/reactos/drivers/base/kddll/kddll.h [iso-8859-1] (original)
+++ trunk/reactos/drivers/base/kddll/kddll.h [iso-8859-1] Sun Apr 21 23:56:15 2013
@@ -8,26 +8,27 @@
 
 #pragma once
 
-//#define KDDEBUG /* uncomment to enable debugging this dll */
-
 #define NOEXTAPI
 #include <ntifs.h>
+#include <arc/arc.h>
 #include <halfuncs.h>
-#include "arc/arc.h"
-#include "windbgkd.h"
-
+#include <windbgkd.h>
 #include <wdbgexts.h>
 #include <ioaccess.h> /* port intrinsics */
 
 #define NDEBUG
 #include <debug.h>
 
-long atol(const char *str);
-
-typedef UCHAR BYTE, *PBYTE;
+//#define KDDEBUG /* uncomment to enable debugging this dll */
 
 typedef ULONG (*PFNDBGPRNT)(const char *Format, ...);
 extern PFNDBGPRNT KdpDbgPrint;
+
+#ifndef KDDEBUG
+#define KDDBGPRINT(...)
+#else
+#define KDDBGPRINT KdpDbgPrint
+#endif
 
 typedef enum
 {
@@ -35,12 +36,6 @@
     KDP_PACKET_TIMEOUT = 1,
     KDP_PACKET_RESEND = 2
 } KDP_STATUS;
-
-#ifndef KDDEBUG
-#define KDDBGPRINT(...)
-#else
-#define KDDBGPRINT KdpDbgPrint
-#endif
 
 VOID
 NTAPI
@@ -61,24 +56,18 @@
 
 VOID
 NTAPI
-KdpSendByte(IN BYTE Byte);
+KdpSendByte(IN UCHAR Byte);
 
 KDP_STATUS
 NTAPI
-KdpPollByte(OUT PBYTE OutByte);
+KdpPollByte(OUT PUCHAR OutByte);
 
 KDP_STATUS
 NTAPI
-KdpReceiveByte(OUT PBYTE OutByte);
+KdpReceiveByte(OUT PUCHAR OutByte);
 
 KDP_STATUS
 NTAPI
 KdpPollBreakIn(VOID);
 
-
-#if 0
-NTSTATUS
-NTAPI
-KdDebuggerInitialize0(
-    IN PLOADER_PARAMETER_BLOCK LoaderBlock OPTIONAL);
-#endif
+/* EOF */

Modified: trunk/reactos/drivers/base/kddll/kdserial.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kddll/kdseria…
==============================================================================
--- trunk/reactos/drivers/base/kddll/kdserial.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/base/kddll/kdserial.c [iso-8859-1] Sun Apr 21 23:56:15 2013
@@ -143,3 +143,4 @@
     return KDP_PACKET_RECEIVED;
 }
 
+/* EOF */