[ros-diffs] [akhaldi] 64114: [CMAKE] * Don't set -Wno-unused-but-set-variable until http://llvm.org/bugs/show_bug.cgi?id=20906 is fixed or the warnings are fixed upstream. CORE-8516

Author: akhaldi
Date: Thu Sep 11 10:43:57 2014
New Revision: 64114

URL: http://svn.reactos.org/svn/reactos?rev=64114&view=rev
Log:
[CMAKE]
* Don't set -Wno-unused-but-set-variable until
http://llvm.org/bugs/show_bug.cgi?id=20906 is fixed or the warnings are fixed upstream.
CORE-8516

Modified:
    trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt
    trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt
    trunk/reactos/dll/opengl/glu32/CMakeLists.txt
    trunk/reactos/dll/win32/browseui/CMakeLists.txt
    trunk/reactos/dll/win32/winmm/CMakeLists.txt
    trunk/reactos/drivers/bluetooth/fbtusb/CMakeLists.txt
    trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt
    trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt
    trunk/reactos/lib/3rdparty/adns/CMakeLists.txt
    trunk/reactos/lib/3rdparty/cardlib/CMakeLists.txt
    trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt
    trunk/reactos/lib/3rdparty/libmpg123/CMakeLists.txt

Modified: trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libtiff/CMake…
==============================================================================
--- trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57
2014
@@ -61,5 +61,7 @@
 
 if(NOT MSVC)
     allow_warnings(libtiff)
-    add_target_compile_flags(libtiff "-Wno-unused-but-set-variable")
+    if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
+        add_target_compile_flags(libtiff "-Wno-unused-but-set-variable")
+    endif()
 endif()

Modified: trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libxslt/CMake…
==============================================================================
--- trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57
2014
@@ -48,5 +48,8 @@
 add_cd_file(TARGET libxslt DESTINATION reactos/system32 FOR all)
 
 if(NOT MSVC)
-    add_target_compile_flags(libxslt "-Wno-pointer-sign -Wno-unused-but-set-variable
-Wno-unused-function")
+    add_target_compile_flags(libxslt "-Wno-pointer-sign -Wno-unused-function")
+    if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
+        add_target_compile_flags(libxslt "-Wno-unused-but-set-variable")
+    endif()
 endif()

Modified: trunk/reactos/dll/opengl/glu32/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/glu32/CMakeList…
==============================================================================
--- trunk/reactos/dll/opengl/glu32/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/opengl/glu32/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57 2014
@@ -113,11 +113,13 @@
 set_module_type(glu32 win32dll)
 
 if(NOT MSVC)
-    add_target_compile_flags(glu32 "-Wno-write-strings
-Wno-unused-but-set-variable")
+    add_target_compile_flags(glu32 "-Wno-write-strings")
     if(CMAKE_C_COMPILER_ID STREQUAL "Clang")
         target_link_libraries(glu32 mingwex)
         #FIXME: longjmp exists in both our msvcrt and mingwex
         add_target_link_flags(glu32 "-Wl,--allow-multiple-definition")
+    else()
+        add_target_compile_flags(glu32 "-Wno-unused-but-set-variable")
     endif()
 endif()
 

Modified: trunk/reactos/dll/win32/browseui/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/CMakeLi…
==============================================================================
--- trunk/reactos/dll/win32/browseui/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/win32/browseui/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57 2014
@@ -60,7 +60,9 @@
 add_cd_file(TARGET browseui DESTINATION reactos/system32 FOR all)
 
 if(NOT MSVC)
-    add_target_compile_flags(browseui "-Wno-unused-but-set-variable")
+    if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
+        add_target_compile_flags(browseui "-Wno-unused-but-set-variable")
+    endif()
 
     # Binutils linker bug
     if(LTCG)

Modified: trunk/reactos/dll/win32/winmm/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/winmm/CMakeLists…
==============================================================================
--- trunk/reactos/dll/win32/winmm/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/win32/winmm/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57 2014
@@ -29,6 +29,6 @@
 add_subdirectory(midimap)
 add_cd_file(TARGET winmm DESTINATION reactos/system32 FOR all)
 
-if(NOT MSVC)
+if((NOT MSVC) AND (NOT CMAKE_C_COMPILER_ID STREQUAL "Clang"))
     add_target_compile_flags(winmm "-Wno-unused-but-set-variable")
 endif()

Modified: trunk/reactos/drivers/bluetooth/fbtusb/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bluetooth/fbtusb/C…
==============================================================================
--- trunk/reactos/drivers/bluetooth/fbtusb/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/bluetooth/fbtusb/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57
2014
@@ -12,8 +12,8 @@
 
 add_library(fbtusb SHARED ${SOURCE} fbtusb.rc)
 
-if(NOT MSVC)
-    set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS
"-Wno-unused-but-set-variable")
+if((NOT MSVC) AND (NOT CMAKE_C_COMPILER_ID STREQUAL "Clang"))
+    add_target_compile_flags(fbtusb "-Wno-unused-but-set-variable")
 endif()
 
 set_module_type(fbtusb kernelmodedriver)

Modified: trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/C…
==============================================================================
--- trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57
2014
@@ -24,8 +24,8 @@
 
 add_library(ext2fs SHARED ${SOURCE})
 
-if(NOT MSVC)
-    add_compile_flags("-Wno-unused-but-set-variable")
+if((NOT MSVC) AND (NOT CMAKE_C_COMPILER_ID STREQUAL "Clang"))
+    add_target_compile_flags(ext2fs "-Wno-unused-but-set-variable")
 endif()
 
 target_link_libraries(ext2fs ${PSEH_LIB})

Modified: trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/uniata…
==============================================================================
--- trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt	[iso-8859-1] Thu Sep 11
10:43:57 2014
@@ -22,7 +22,10 @@
 
 
 if(NOT MSVC)
-    set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS
"-Wno-unused-but-set-variable -Wno-narrowing")
+    add_target_compile_flags(uniata "-Wno-narrowing")
+    if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
+        add_target_compile_flags(uniata "-Wno-unused-but-set-variable")
+    endif()
 endif()
 
 add_pch(uniata stdafx.h SOURCE)

Modified: trunk/reactos/lib/3rdparty/adns/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/adns/CMakeLis…
==============================================================================
--- trunk/reactos/lib/3rdparty/adns/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/3rdparty/adns/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57 2014
@@ -25,6 +25,6 @@
 add_dependencies(adns psdk)
 add_pch(adns src/internal.h SOURCE)
 
-if(NOT MSVC)
+if((NOT MSVC) AND (NOT CMAKE_C_COMPILER_ID STREQUAL "Clang"))
     add_target_compile_flags(adns "-Wno-unused-but-set-variable")
 endif()

Modified: trunk/reactos/lib/3rdparty/cardlib/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/cardlib/CMake…
==============================================================================
--- trunk/reactos/lib/3rdparty/cardlib/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/3rdparty/cardlib/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57
2014
@@ -19,6 +19,6 @@
 add_dependencies(cardlib psdk)
 add_pch(cardlib cardlib.h SOURCE)
 
-if(NOT MSVC AND (NOT CMAKE_C_COMPILER_ID STREQUAL "Clang"))
+if((NOT MSVC) AND (NOT CMAKE_C_COMPILER_ID STREQUAL "Clang"))
     add_target_compile_flags(cardlib "-Wno-unused-but-set-variable")
 endif()

Modified: trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/fullfat/CMake…
==============================================================================
--- trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57
2014
@@ -19,6 +19,6 @@
 add_library(fullfat ${SOURCE})
 add_dependencies(fullfat bugcodes)
 
-if(NOT MSVC)
+if((NOT MSVC) AND (NOT CMAKE_C_COMPILER_ID STREQUAL "Clang"))
     add_target_compile_flags(fullfat "-Wno-unused-but-set-variable")
 endif()

Modified: trunk/reactos/lib/3rdparty/libmpg123/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libmpg123/CMa…
==============================================================================
--- trunk/reactos/lib/3rdparty/libmpg123/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/3rdparty/libmpg123/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:43:57
2014
@@ -45,6 +45,6 @@
 add_dependencies(libmpg123 psdk)
 add_pch(libmpg123 precomp.h SOURCE)
 
-if(NOT MSVC)
+if((NOT MSVC) AND (NOT CMAKE_C_COMPILER_ID STREQUAL "Clang"))
     add_target_compile_flags(libmpg123 "-Wno-unused-but-set-variable")
 endif()