[ros-diffs] [tfaber] 59134: [NTOS:IO] - Do not dereference an unsafe ObjectAttributes pointer in IoCreateFile. Spotted by Aleksandar Andrejevic (I'm removing the OriginalAttributes assignment completely becaus...

Author: tfaber
Date: Sat Jun  1 20:50:13 2013
New Revision: 59134

URL: http://svn.reactos.org/svn/reactos?rev=59134&view=rev
Log:
[NTOS:IO]
- Do not dereference an unsafe ObjectAttributes pointer in IoCreateFile. Spotted by
Aleksandar Andrejevic
(I'm removing the OriginalAttributes assignment completely because it's never
used, and it generally makes no sense to copy this. ObOpenObjectByName already takes care
of everything in attributes)
CORE-7167

Modified:
    trunk/reactos/ntoskrnl/io/iomgr/file.c

Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/file.c	[iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c	[iso-8859-1] Sat Jun  1 20:50:13 2013
@@ -1761,7 +1761,7 @@
                 SystemEaBuffer = ExAllocatePoolWithTag(NonPagedPool,
                                                        EaLength,
                                                        TAG_EA);
-                if(!SystemEaBuffer)
+                if (!SystemEaBuffer)
                 {
                     _SEH2_YIELD(return STATUS_INSUFFICIENT_RESOURCES);
                 }
@@ -1840,7 +1840,6 @@
     RtlZeroMemory(&OpenPacket, sizeof(OPEN_PACKET));
     OpenPacket.Type = IO_TYPE_OPEN_PACKET;
     OpenPacket.Size = sizeof(OPEN_PACKET);
-    OpenPacket.OriginalAttributes = *ObjectAttributes;
     OpenPacket.AllocationSize = SafeAllocationSize;
     OpenPacket.CreateOptions = CreateOptions;
     OpenPacket.FileAttributes = (USHORT)FileAttributes;