[ros-diffs] [janderwald] 51372: [USBEHCI_NEW] - Fix bug in CDMAMemoryManager initialization, which calculated the bitmap length wrong - Create interface IUSBDevice, which will be used to abstract connected usb...

Author: janderwald
Date: Sun Apr 17 08:20:40 2011
New Revision: 51372

URL: http://svn.reactos.org/svn/reactos?rev=51372&view=rev
Log:
[USBEHCI_NEW]
- Fix bug in CDMAMemoryManager initialization, which calculated the bitmap length wrong
- Create interface IUSBDevice, which will be used to abstract connected usb devices
- Implement support functions for the device interface. 
- Implement USBHI_CreateUsbDevice, USBHI_InitializeUsbDevice, USBHI_GetUsbDescriptors,
USBHI_RemoveUsbDevice, USBHI_GetExtendedHubInformation, USBHI_RootHubInitNotification,
USBHI_SetDeviceHandleData, USBDI_GetUSBDIVersion, USBDI_IsDeviceHighSpeed
- Partly implement USBHI_QueryDeviceInformation
- Based on mjmartin usbehci 

Added:
    branches/usb-bringup/drivers/usb/usbehci_new/usb_device.cpp   (with props)
Modified:
    branches/usb-bringup/drivers/usb/usbehci_new/CMakeLists.txt
    branches/usb-bringup/drivers/usb/usbehci_new/hub_controller.cpp
    branches/usb-bringup/drivers/usb/usbehci_new/interfaces.h
    branches/usb-bringup/drivers/usb/usbehci_new/memory_manager.cpp
    branches/usb-bringup/drivers/usb/usbehci_new/usbehci.h

Modified: branches/usb-bringup/drivers/usb/usbehci_new/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/branches/usb-bringup/drivers/usb/usbehci…
==============================================================================
--- branches/usb-bringup/drivers/usb/usbehci_new/CMakeLists.txt [iso-8859-1] (original)
+++ branches/usb-bringup/drivers/usb/usbehci_new/CMakeLists.txt [iso-8859-1] Sun Apr 17
08:20:40 2011
@@ -6,6 +6,7 @@
 
 add_library(usbehci SHARED
     usbehci.cpp
+    usb_device.cpp
     hcd_controller.cpp
     hardware.cpp
     misc.cpp

Modified: branches/usb-bringup/drivers/usb/usbehci_new/hub_controller.cpp
URL:
http://svn.reactos.org/svn/reactos/branches/usb-bringup/drivers/usb/usbehci…
==============================================================================
--- branches/usb-bringup/drivers/usb/usbehci_new/hub_controller.cpp [iso-8859-1]
(original)
+++ branches/usb-bringup/drivers/usb/usbehci_new/hub_controller.cpp [iso-8859-1] Sun Apr
17 08:20:40 2011
@@ -47,6 +47,13 @@
     NTSTATUS SetDeviceInterface(BOOLEAN bEnable);
     NTSTATUS CreatePDO(PDRIVER_OBJECT DriverObject, PDEVICE_OBJECT * OutDeviceObject);
     NTSTATUS GetHubControllerDeviceObject(PDEVICE_OBJECT * HubDeviceObject);
+    PUSBHARDWAREDEVICE GetUsbHardware();
+    ULONG AcquireDeviceAddress();
+    VOID ReleaseDeviceAddress(ULONG DeviceAddress);
+    BOOLEAN ValidateUsbDevice(PUSBDEVICE UsbDevice);
+    NTSTATUS AddUsbDevice(PUSBDEVICE UsbDevice);
+    NTSTATUS RemoveUsbDevice(PUSBDEVICE UsbDevice);
+    VOID SetNotification(PVOID CallbackContext, PRH_INIT_CALLBACK CallbackRoutine);
 
     // constructor / destructor
     CHubController(IUnknown *OuterUnknown){}
@@ -63,7 +70,23 @@
     UNICODE_STRING m_HubDeviceInterfaceString;
     PDEVICE_OBJECT m_HubControllerDeviceObject;
     PDRIVER_OBJECT m_DriverObject;
+
+    PVOID m_HubCallbackContext; 
+    PRH_INIT_CALLBACK m_HubCallbackRoutine;
+
+
+    KSPIN_LOCK m_Lock;
+    RTL_BITMAP m_DeviceAddressBitmap;
+    PULONG m_DeviceAddressBitmapBuffer;
+    LIST_ENTRY m_UsbDeviceList;
 };
+
+typedef struct
+{
+    LIST_ENTRY Entry;
+    PUSBDEVICE Device;
+}USBDEVICE_ENTRY, *PUSBDEVICE_ENTRY;
+
 

//----------------------------------------------------------------------------------------
 NTSTATUS
@@ -96,6 +119,26 @@
     m_IsRootHubDevice = IsRootHubDevice;
     m_DeviceAddress = DeviceAddress;
     m_DriverObject = DriverObject;
+    KeInitializeSpinLock(&m_Lock);
+
+    //
+    // allocate device address bitmap buffer
+    //
+    m_DeviceAddressBitmapBuffer = (PULONG)ExAllocatePoolWithTag(NonPagedPool, 16,
TAG_USBEHCI);
+    if (!m_DeviceAddressBitmapBuffer)
+    {
+        //
+        // no memory
+        //
+        return STATUS_INSUFFICIENT_RESOURCES;
+    }
+
+    //
+    // initialize device address bitmap
+    //
+    RtlInitializeBitMap(&m_DeviceAddressBitmap, m_DeviceAddressBitmapBuffer, 128);
+    RtlClearAllBits(&m_DeviceAddressBitmap);
+
 
     //
     // create PDO
@@ -197,9 +240,7 @@
                     //
                     Status = m_Hardware->GetDeviceDetails(&VendorID,
&DeviceID, &NumPorts, &HiSpeed);
 
-                    HiSpeed = TRUE;
-
-                    if (HiSpeed)
+                    if (HiSpeed == 0x200)
                     {
                         //
                         // USB 2.0 hub
@@ -261,8 +302,6 @@
                     //
                     Status = m_Hardware->GetDeviceDetails(&VendorID,
&DeviceID, &NumPorts, &HiSpeed);
 
-                    HiSpeed = TRUE;
-
                     if (!NT_SUCCESS(Status))
                     {
                          DPRINT1("CHubController::HandlePnp> failed to get
hardware id %x\n", Status);
@@ -270,7 +309,7 @@
                          DeviceID = 0x3A37;
                     }
 
-                    if (HiSpeed)
+                    if (HiSpeed == 0x200)
                     {
                         //
                         // USB 2.0 hub
@@ -479,6 +518,7 @@
 {
     PIO_STACK_LOCATION IoStack;
     PCOMMON_DEVICE_EXTENSION DeviceExtension;
+    PURB Urb;
     NTSTATUS Status = STATUS_NOT_IMPLEMENTED;
 
     //
@@ -505,7 +545,13 @@
     {
         case IOCTL_INTERNAL_USB_SUBMIT_URB:
         {
-            DPRINT1("IOCTL_INTERNAL_USB_SUBMIT_URB UNIMPLEMENTED\n");
+            //
+            // get urb
+            //
+            Urb = (PURB)IoStack->Parameters.Others.Argument1;
+            PC_ASSERT(Urb);
+
+            DPRINT1("IOCTL_INTERNAL_USB_SUBMIT_URB Function %x Length %lu Status %x
Handle %p Flags %x UNIMPLEMENTED\n", Urb->UrbHeader.Function,
Urb->UrbHeader.Length, Urb->UrbHeader.Status, Urb->UrbHeader.UsbdDeviceHandle,
Urb->UrbHeader.UsbdFlags);
 
             //
             // request completed
@@ -597,6 +643,283 @@
     return Status;
 }
 
+//-----------------------------------------------------------------------------------------
+PUSBHARDWAREDEVICE
+CHubController::GetUsbHardware()
+{
+    return m_Hardware;
+}
+
+//-----------------------------------------------------------------------------------------
+ULONG
+CHubController::AcquireDeviceAddress()
+{
+    KIRQL OldLevel;
+    ULONG DeviceAddress;
+
+    //
+    // acquire device lock
+    //
+    KeAcquireSpinLock(&m_Lock, &OldLevel);
+
+    //
+    // find address
+    //
+    DeviceAddress = RtlFindClearBits(&m_DeviceAddressBitmap, 1, 0);
+    if (DeviceAddress != MAXULONG)
+    {
+        //
+        // reserve address
+        //
+        RtlSetBit(&m_DeviceAddressBitmap, DeviceAddress);
+
+        //
+        // device addresses start from 0x1 - 0xFF
+        //
+        DeviceAddress++;
+    }
+
+    //
+    // release spin lock
+    //
+    KeReleaseSpinLock(&m_Lock, OldLevel);
+
+    //
+    // return device address
+    //
+    return DeviceAddress;
+}
+//-----------------------------------------------------------------------------------------
+VOID
+CHubController::ReleaseDeviceAddress(
+    ULONG DeviceAddress)
+{
+    KIRQL OldLevel;
+
+    //
+    // acquire device lock
+    //
+    KeAcquireSpinLock(&m_Lock, &OldLevel);
+
+    //
+    // sanity check
+    //
+    PC_ASSERT(DeviceAddress != 0);
+
+    //
+    // convert back to bit number
+    //
+    DeviceAddress--;
+
+    //
+    // clear bit
+    //
+    RtlClearBit(&m_DeviceAddressBitmap, DeviceAddress);
+
+    //
+    // release lock
+    //
+    KeReleaseSpinLock(&m_Lock, OldLevel);
+}
+//-----------------------------------------------------------------------------------------
+NTSTATUS
+CHubController::RemoveUsbDevice(
+    PUSBDEVICE UsbDevice)
+{
+    PUSBDEVICE_ENTRY DeviceEntry;
+    PLIST_ENTRY Entry;
+    NTSTATUS Status = STATUS_UNSUCCESSFUL;
+    KIRQL OldLevel;
+
+    //
+    // acquire lock
+    //
+    KeAcquireSpinLock(&m_Lock, &OldLevel);
+
+    //
+    // point to first entry
+    //
+    Entry = m_UsbDeviceList.Flink;
+
+    //
+    // find matching entry
+    //
+    while(Entry != &m_UsbDeviceList)
+    {
+        //
+        // get entry
+        //
+        DeviceEntry = (PUSBDEVICE_ENTRY)CONTAINING_RECORD(Entry, USBDEVICE_ENTRY,
Entry);
+
+        //
+        // is it current entry
+        //
+        if (DeviceEntry->Device == UsbDevice)
+        {
+            //
+            // remove entry
+            //
+            RemoveEntryList(Entry);
+
+            //
+            // free entry
+            //
+            ExFreePoolWithTag(DeviceEntry, TAG_USBEHCI);
+
+            //
+            // done
+            //
+            Status = STATUS_SUCCESS;
+            break;
+        }
+
+        //
+        // goto next device
+        //
+        Entry = Entry->Flink;
+    }
+
+    //
+    // release lock
+    //
+    KeReleaseSpinLock(&m_Lock, OldLevel);
+
+    //
+    // return result
+    //
+    return Status;
+}
+//-----------------------------------------------------------------------------------------
+BOOLEAN
+CHubController::ValidateUsbDevice(PUSBDEVICE UsbDevice)
+{
+    PUSBDEVICE_ENTRY DeviceEntry;
+    PLIST_ENTRY Entry;
+    KIRQL OldLevel;
+    BOOLEAN Result = FALSE;
+
+    //
+    // acquire lock
+    //
+    KeAcquireSpinLock(&m_Lock, &OldLevel);
+
+    //
+    // point to first entry
+    //
+    Entry = m_UsbDeviceList.Flink;
+
+    //
+    // find matching entry
+    //
+    while(Entry != &m_UsbDeviceList)
+    {
+        //
+        // get entry
+        //
+        DeviceEntry = (PUSBDEVICE_ENTRY)CONTAINING_RECORD(Entry, USBDEVICE_ENTRY,
Entry);
+
+        //
+        // is it current entry
+        //
+        if (DeviceEntry->Device == UsbDevice)
+        {
+            //
+            // device is valid
+            //
+            Result = TRUE;
+            break;
+        }
+
+        //
+        // goto next device
+        //
+        Entry = Entry->Flink;
+    }
+
+    //
+    // release lock
+    //
+    KeReleaseSpinLock(&m_Lock, OldLevel);
+
+    //
+    // return result
+    //
+    return Result;
+
+}
+
+//-----------------------------------------------------------------------------------------
+NTSTATUS
+CHubController::AddUsbDevice(
+    PUSBDEVICE UsbDevice)
+{
+    PUSBDEVICE_ENTRY DeviceEntry;
+    NTSTATUS Status;
+    KIRQL OldLevel;
+
+    //
+    // allocate device entry
+    //
+    DeviceEntry = (PUSBDEVICE_ENTRY)ExAllocatePoolWithTag(NonPagedPool,
sizeof(USBDEVICE_ENTRY), TAG_USBEHCI);
+    if (!DeviceEntry)
+    {
+        //
+        // no memory
+        //
+        return STATUS_INSUFFICIENT_RESOURCES;
+    }
+
+    //
+    // initialize entry
+    //
+    DeviceEntry->Device = UsbDevice;
+
+    //
+    // acquire lock
+    //
+    KeAcquireSpinLock(&m_Lock, &OldLevel);
+
+    //
+    // insert entry
+    //
+    InsertTailList(&m_UsbDeviceList, &DeviceEntry->Entry);
+
+    //
+    // release spin lock
+    //
+    KeReleaseSpinLock(&m_Lock, OldLevel);
+
+    //
+    // done
+    //
+    return STATUS_SUCCESS;
+}
+
+//-----------------------------------------------------------------------------------------
+VOID
+CHubController::SetNotification(
+    PVOID CallbackContext,
+    PRH_INIT_CALLBACK CallbackRoutine)
+{
+    KIRQL OldLevel;
+
+    //
+    // acquire hub controller lock
+    //
+    KeAcquireSpinLock(&m_Lock, &OldLevel);
+
+    //
+    // now set the callback routine and context of the hub
+    //
+    m_HubCallbackContext = CallbackContext;
+    m_HubCallbackRoutine = CallbackRoutine;
+
+   //
+   // release hub controller lock
+   //
+   KeReleaseSpinLock(&m_Lock, OldLevel);
+}
+

//=================================================================================================
 //
 // Generic Interface functions
@@ -643,8 +966,86 @@
     USHORT PortStatus,
     USHORT PortNumber)
 {
-    UNIMPLEMENTED
-    return STATUS_NOT_IMPLEMENTED;
+    PUSBDEVICE NewUsbDevice;
+    CHubController * Controller;
+    NTSTATUS Status;
+
+    DPRINT1("USBHI_CreateUsbDevice\n");
+
+    //
+    // first get hub controller
+    //
+    Controller = (CHubController *)BusContext;
+
+    //
+    // sanity check
+    //
+    PC_ASSERT(Controller);
+    PC_ASSERT(BusContext == HubDeviceHandle);
+
+    //
+    // now allocate usb device
+    //
+    Status = CreateUSBDevice(&NewUsbDevice);
+
+    //
+    // check for success
+    //
+    if (!NT_SUCCESS(Status))
+    {
+        //
+        // release controller
+        //
+        Controller->Release();
+        DPRINT1("USBHI_CreateUsbDevice: failed to create usb device %x\n",
Status);
+        return Status;
+    }
+
+    //
+    // now initialize device
+    //
+    Status = NewUsbDevice->Initialize(PHUBCONTROLLER(Controller),
Controller->GetUsbHardware(),PVOID(Controller), PortNumber);
+
+    //
+    // check for success
+    //
+    if (!NT_SUCCESS(Status))
+    {
+        //
+        // release usb device
+        //
+        NewUsbDevice->Release();
+        DPRINT1("USBHI_CreateUsbDevice: failed to initialize usb device %x\n",
Status);
+        return Status;
+    }
+
+    //
+    // insert into list
+    //
+    Status = Controller->AddUsbDevice(NewUsbDevice);
+    //
+    // check for success
+    //
+    if (!NT_SUCCESS(Status))
+    {
+        //
+        // release usb device
+        //
+        NewUsbDevice->Release();
+
+        DPRINT1("USBHI_CreateUsbDevice: failed to add usb device %x\n",
Status);
+        return Status;
+    }
+
+    //
+    // store the handle
+    //
+    *NewDevice = NewUsbDevice;
+
+    //
+    // done
+    //
+    return STATUS_SUCCESS;
 }
 
 NTSTATUS
@@ -653,8 +1054,93 @@
     PVOID BusContext,
     PUSB_DEVICE_HANDLE DeviceHandle)
 {
-    UNIMPLEMENTED
-    return STATUS_NOT_IMPLEMENTED;
+    PUSBDEVICE UsbDevice;
+    CHubController * Controller;
+    ULONG DeviceAddress;
+    NTSTATUS Status;
+    ULONG Index = 0;
+
+    DPRINT1("USBHI_InitializeUsbDevice\n");
+
+    //
+    // first get controller
+    //
+    Controller = (CHubController *)BusContext;
+    PC_ASSERT(Controller);
+
+    //
+    // get device object
+    //
+    UsbDevice = (PUSBDEVICE)DeviceHandle;
+    PC_ASSERT(UsbDevice);
+
+    //
+    // validate device handle
+    //
+    if (!Controller->ValidateUsbDevice(UsbDevice))
+    {
+        DPRINT1("USBHI_InitializeUsbDevice invalid device handle %p\n",
DeviceHandle);
+
+        //
+        // invalid device handle
+        //
+        return STATUS_DEVICE_NOT_CONNECTED;
+    }
+
+    //
+    // now reserve an address
+    //
+    DeviceAddress = Controller->AcquireDeviceAddress();
+
+    //
+    // is the device address valid
+    //
+    if (DeviceAddress == MAXULONG)
+    {
+        //
+        // failed to get an device address from the device address pool
+        //
+        DPRINT1("USBHI_InitializeUsbDevice failed to get device address\n");
+        return STATUS_DEVICE_DATA_ERROR;
+    }
+
+    do
+    {
+        //
+        // now set the device address
+        //
+        Status = UsbDevice->SetDeviceAddress(DeviceAddress);
+
+        if (NT_SUCCESS(Status))
+            break;
+
+    }while(Index++ < 3	);
+
+    //
+    // check for failure
+    //
+    if (!NT_SUCCESS(Status))
+    {
+        //
+        // failed to set device address
+        //
+        DPRINT1("USBHI_InitializeUsbDevice failed to set address with %x\n",
Status);
+
+        //
+        // release address
+        //
+        Controller->ReleaseDeviceAddress(DeviceAddress);
+
+        //
+        // return error
+        //
+        return STATUS_DEVICE_DATA_ERROR;
+    }
+
+    //
+    // done
+    //
+    return STATUS_SUCCESS;
 }
 
 NTSTATUS
@@ -667,8 +1153,103 @@
     PUCHAR ConfigDescriptorBuffer,
     PULONG ConfigDescriptorBufferLength)
 {
-    UNIMPLEMENTED
-    return STATUS_NOT_IMPLEMENTED;
+    PUSBDEVICE UsbDevice;
+    CHubController * Controller;
+    NTSTATUS Status;
+    PURB Urb;
+
+    DPRINT1("USBHI_GetUsbDescriptors\n");
+
+    //
+    // sanity check
+    //
+    PC_ASSERT(DeviceDescriptorBuffer);
+    PC_ASSERT(*DeviceDescriptorBufferLength >= sizeof(USB_DEVICE_DESCRIPTOR));
+
+    //
+    // first get controller
+    //
+    Controller = (CHubController *)BusContext;
+    PC_ASSERT(Controller);
+
+
+    //
+    // get device object
+    //
+    UsbDevice = (PUSBDEVICE)DeviceHandle;
+    PC_ASSERT(UsbDevice);
+
+    //
+    // validate device handle
+    //
+    if (!Controller->ValidateUsbDevice(UsbDevice))
+    {
+        DPRINT1("USBHI_GetUsbDescriptors invalid device handle %p\n",
DeviceHandle);
+
+        //
+        // invalid device handle
+        //
+        return STATUS_DEVICE_NOT_CONNECTED;
+    }
+
+    //
+    // get device descriptor
+    //
+    UsbDevice->GetDeviceDescriptor((PUSB_DEVICE_DESCRIPTOR)DeviceDescriptorBuffer);
+
+    //
+    // store result length
+    //
+    *DeviceDescriptorBufferLength = sizeof(USB_DEVICE_DESCRIPTOR);
+
+    //
+    // allocate urb
+    //
+    Urb = (PURB)ExAllocatePoolWithTag(NonPagedPool, sizeof(URB), TAG_USBEHCI);
+    if (!Urb)
+    {
+        //
+        // no memory
+        // 
+        return STATUS_INSUFFICIENT_RESOURCES;
+    }
+
+    //
+    // zero request
+    //
+    RtlZeroMemory(Urb, sizeof(URB));
+
+    //
+    // initialize request
+    //
+    Urb->UrbHeader.Function = URB_FUNCTION_GET_DESCRIPTOR_FROM_DEVICE;
+    Urb->UrbHeader.Length = sizeof(_URB_CONTROL_DESCRIPTOR_REQUEST);
+    Urb->UrbControlDescriptorRequest.DescriptorType =
USB_CONFIGURATION_DESCRIPTOR_TYPE;
+    Urb->UrbControlDescriptorRequest.TransferBuffer = ConfigDescriptorBuffer;
+    Urb->UrbControlDescriptorRequest.TransferBufferLength =
*ConfigDescriptorBufferLength;
+
+    //
+    // submit urb
+    //
+    Status = UsbDevice->SubmitUrb(Urb);
+
+    if (NT_SUCCESS(Status))
+    {
+        //
+        // TransferBufferLength holds the number of bytes transferred
+        //
+        *ConfigDescriptorBufferLength =
Urb->UrbControlDescriptorRequest.TransferBufferLength;
+    }
+
+    //
+    // free urb
+    //
+    ExFreePoolWithTag(Urb, TAG_USBEHCI);
+
+    //
+    // complete the request
+    //
+    return Status;
 }
 
 NTSTATUS
@@ -678,8 +1259,71 @@
     PUSB_DEVICE_HANDLE DeviceHandle,
     ULONG Flags)
 {
-    UNIMPLEMENTED
-    return STATUS_NOT_IMPLEMENTED;
+    PUSBDEVICE UsbDevice;
+    CHubController * Controller;
+    NTSTATUS Status;
+
+    DPRINT1("USBHI_RemoveUsbDevice\n");
+
+    //
+    // first get controller
+    //
+    Controller = (CHubController *)BusContext;
+    PC_ASSERT(Controller);
+
+    //
+    // get device object
+    //
+    UsbDevice = (PUSBDEVICE)DeviceHandle;
+    PC_ASSERT(UsbDevice);
+
+    //
+    // validate device handle
+    //
+    if (!Controller->ValidateUsbDevice(UsbDevice))
+    {
+        DPRINT1("USBHI_RemoveUsbDevice invalid device handle %p\n",
DeviceHandle);
+
+        //
+        // invalid device handle
+        //
+        return STATUS_DEVICE_NOT_CONNECTED;
+    }
+
+    //
+    // check if there were flags passed
+    //
+    if (Flags & USBD_KEEP_DEVICE_DATA || Flags  & USBD_MARK_DEVICE_BUSY)
+    {
+        //
+        // ignore flags for now
+        //
+        return STATUS_SUCCESS;
+    }
+
+    //
+    // remove device
+    //
+    Status = Controller->RemoveUsbDevice(UsbDevice);
+    if (!NT_SUCCESS(Status))
+    {
+        //
+        // invalid device handle
+        //
+        DPRINT1("USBHI_RemoveUsbDevice Invalid device handle %p\n",
UsbDevice);
+        PC_ASSERT(0);
+        return STATUS_DEVICE_NOT_CONNECTED;
+    }
+
+    //
+    // release usb device
+    //
+    UsbDevice->Release();
+
+    //
+    // done
+    //
+    return STATUS_SUCCESS;
 }
 
 NTSTATUS
@@ -712,8 +1356,78 @@
     ULONG DeviceInformationBufferLength,
     PULONG LengthReturned)
 {
-    UNIMPLEMENTED
-    return STATUS_NOT_IMPLEMENTED;
+    PUSB_DEVICE_INFORMATION_0 DeviceInfo;
+    PUSBDEVICE UsbDevice;
+    CHubController * Controller;
+    NTSTATUS Status;
+
+    DPRINT1("USBHI_QueryDeviceInformation\n");
+
+    //
+    // sanity check
+    //
+    PC_ASSERT(DeviceInformationBufferLength >= sizeof(USB_DEVICE_INFORMATION_0));
+    PC_ASSERT(DeviceInformationBuffer);
+    PC_ASSERT(LengthReturned);
+
+    //
+    // get controller object
+    //
+    Controller = (CHubController*)BusContext;
+    PC_ASSERT(Controller);
+
+    //
+    // get device object
+    //
+    UsbDevice = (PUSBDEVICE)DeviceHandle;
+    PC_ASSERT(UsbDevice);
+
+    //
+    // validate device handle
+    //
+    if (!Controller->ValidateUsbDevice(UsbDevice))
+    {
+        DPRINT1("USBHI_QueryDeviceInformation invalid device handle %p\n",
DeviceHandle);
+
+        //
+        // invalid device handle
+        //
+        return STATUS_DEVICE_NOT_CONNECTED;
+    }
+
+    //
+    // access information buffer
+    //
+    DeviceInfo = (PUSB_DEVICE_INFORMATION_0)DeviceInformationBuffer;
+
+    //
+    // initialize with default values
+    //
+    DeviceInfo->InformationLevel = 0;
+    DeviceInfo->ActualLength = sizeof(USB_DEVICE_INFORMATION_0);
+    DeviceInfo->PortNumber = UsbDevice->GetPort();
+    DeviceInfo->CurrentConfigurationValue = UsbDevice->GetConfigurationValue();
+    DeviceInfo->DeviceAddress = 0; UsbDevice->GetDeviceAddress();
+    DeviceInfo->HubAddress = 0; //FIXME
+    DeviceInfo->DeviceSpeed = UsbDevice->GetSpeed();
+    DeviceInfo->DeviceType = UsbDevice->GetType();
+    DeviceInfo->NumberOfOpenPipes = 0; //FIXME
+
+    //
+    // get device descriptor
+    //
+    UsbDevice->GetDeviceDescriptor(&DeviceInfo->DeviceDescriptor);
+
+    //
+    // FIXME return pipe information
+    //
+
+    //
+    // store result length
+    //
+    *LengthReturned = sizeof(USB_DEVICE_INFORMATION_0);
+
+    return STATUS_SUCCESS;
 }
 
 NTSTATUS
@@ -747,8 +1461,87 @@
     ULONG HubInformationBufferLength,
     PULONG LengthReturned)
 {
-    UNIMPLEMENTED
-    return STATUS_NOT_IMPLEMENTED;
+    PUSB_EXTHUB_INFORMATION_0 HubInfo;
+    CHubController * Controller;
+    PUSBHARDWAREDEVICE Hardware;
+    ULONG Index;
+    ULONG NumPort, Dummy2;
+    USHORT Dummy1;
+    NTSTATUS Status;
+
+    DPRINT1("USBHI_GetExtendedHubInformation\n");
+
+    //
+    // sanity checks
+    // 
+    PC_ASSERT(HubInformationBuffer);
+    PC_ASSERT(HubInformationBufferLength == sizeof(USB_EXTHUB_INFORMATION_0));
+    PC_ASSERT(LengthReturned);
+
+    //
+    // get hub controller
+    //
+    Controller = (CHubController *)BusContext;
+    PC_ASSERT(Controller);
+
+    //
+    // get usb hardware device
+    //
+    Hardware = Controller->GetUsbHardware();
+
+    //
+    // retrieve number of ports
+    //
+    Status = Hardware->GetDeviceDetails(&Dummy1, &Dummy1, &NumPort,
&Dummy2);
+    if (!NT_SUCCESS(Status))
+    {
+        //
+        // failed to get hardware details, ouch ;)
+        //
+        DPRINT1("USBHI_GetExtendedHubInformation failed to get hardware details with
%x\n", Status);
+        return Status;
+    }
+
+    //
+    // get hub information buffer
+    //
+    HubInfo = (PUSB_EXTHUB_INFORMATION_0)HubInformationBuffer;
+
+    //
+    // initialize hub information
+    //
+    HubInfo->InformationLevel = 0;
+
+    //
+    // store port count
+    //
+    HubInfo->NumberOfPorts = NumPort;
+
+    //
+    // initialize port information
+    //
+    for(Index = 0; Index < NumPort; Index++)
+    {
+        HubInfo->Port[Index].PhysicalPortNumber = Index + 1;
+        HubInfo->Port[Index].PortLabelNumber = Index + 1;
+        HubInfo->Port[Index].VidOverride = 0;
+        HubInfo->Port[Index].PidOverride = 0;
+        HubInfo->Port[Index].PortAttributes = USB_PORTATTR_SHARED_USB2; //FIXME
+    }
+
+    //
+    // store result length
+    //
+#ifdef _MSC_VER
+    *LengthReturned = FIELD_OFFSET(USB_EXTHUB_INFORMATION_0,
Port[HubInfo->NumberOfPorts]);
+#else
+    *LengthReturned = FIELD_OFFSET(USB_EXTHUB_INFORMATION_0, Port) +
sizeof(USB_EXTPORT_INFORMATION_0) * HubInfo->NumberOfPorts;
+#endif
+
+    //
+    // done
+    //
+    return STATUS_SUCCESS;
 }
 
 NTSTATUS
@@ -791,8 +1584,25 @@
     PVOID CallbackContext,
     PRH_INIT_CALLBACK CallbackRoutine)
 {
-    UNIMPLEMENTED
-    return STATUS_NOT_IMPLEMENTED;
+    CHubController * Controller;
+
+    DPRINT1("USBHI_RootHubInitNotification\n");
+
+    //
+    // get controller object
+    //
+    Controller = (CHubController*)BusContext;
+    PC_ASSERT(Controller);
+
+    //
+    // set notification routine
+    //
+    Controller->SetNotification(CallbackContext, CallbackRoutine);
+
+    //
+    // done
+    //
+    return STATUS_SUCCESS;
 }
 
 VOID
@@ -811,7 +1621,37 @@
     PVOID DeviceHandle,
     PDEVICE_OBJECT UsbDevicePdo)
 {
-    UNIMPLEMENTED
+    PUSBDEVICE UsbDevice;
+    CHubController * Controller;
+
+    //
+    // get controller
+    //
+    Controller = (CHubController *)BusContext;
+    PC_ASSERT(Controller);
+
+    //
+    // get device handle
+    //
+    UsbDevice = (PUSBDEVICE)DeviceHandle;
+
+    //
+    // validate device handle
+    //
+    if (!Controller->ValidateUsbDevice(UsbDevice))
+    {
+        DPRINT1("USBHI_SetDeviceHandleData DeviceHandle %p is invalid\n",
DeviceHandle);
+
+        //
+        // invalid handle
+        //
+        return;
+    }
+
+    //
+    // set device handle data
+    //
+    UsbDevice->SetDeviceHandleData(UsbDevicePdo);
 }
 

//=================================================================================================
@@ -826,7 +1666,46 @@
     PUSBD_VERSION_INFORMATION VersionInformation,
     PULONG HcdCapabilites)
 {
-    UNIMPLEMENTED
+    CHubController * Controller;
+    PUSBHARDWAREDEVICE Device;
+    ULONG Speed, Dummy2;
+    USHORT Dummy1;
+
+    DPRINT1("USBDI_GetUSBDIVersion\n");
+
+    //
+    // get controller
+    //
+    Controller = (CHubController*)BusContext;
+
+    //
+    // get usb hardware
+    //
+    Device = Controller->GetUsbHardware();
+    PC_ASSERT(Device);
+
+    if (VersionInformation)
+    {
+        //
+        // windows xp supported
+        //
+        VersionInformation->USBDI_Version = 0x00000500;
+
+        //
+        // get device speed
+        //
+        Device->GetDeviceDetails(&Dummy1, &Dummy1, &Dummy2, &Speed);
+
+        //
+        // store speed details
+        //
+        VersionInformation->Supported_USB_Version = Speed;
+    }
+
+    //
+    // no flags supported
+    //
+    *HcdCapabilites = 0;
 }
 
 NTSTATUS
@@ -867,8 +1746,33 @@
 USBDI_IsDeviceHighSpeed(
     PVOID BusContext)
 {
-    UNIMPLEMENTED
-    return TRUE;
+    CHubController * Controller;
+    PUSBHARDWAREDEVICE Device;
+    ULONG Speed, Dummy2;
+    USHORT Dummy1;
+
+    DPRINT1("USBDI_IsDeviceHighSpeed\n");
+
+    //
+    // get controller
+    //
+    Controller = (CHubController*)BusContext;
+
+    //
+    // get usb hardware
+    //
+    Device = Controller->GetUsbHardware();
+    PC_ASSERT(Device);
+
+    //
+    // get device speed
+    //
+    Device->GetDeviceDetails(&Dummy1, &Dummy1, &Dummy2, &Speed);
+
+    //
+    // USB 2.0 equals 0x200
+    //
+    return (Speed == 0x200);
 }
 
 NTSTATUS

Modified: branches/usb-bringup/drivers/usb/usbehci_new/interfaces.h
URL:
http://svn.reactos.org/svn/reactos/branches/usb-bringup/drivers/usb/usbehci…
==============================================================================
--- branches/usb-bringup/drivers/usb/usbehci_new/interfaces.h [iso-8859-1] (original)
+++ branches/usb-bringup/drivers/usb/usbehci_new/interfaces.h [iso-8859-1] Sun Apr 17
08:20:40 2011
@@ -475,4 +475,127 @@
 
 typedef IDispatchIrp *PDISPATCHIRP;
 
+//=========================================================================================
+//
+// class IUSBDevice
+//
+// Description: This class is used to abstract details of a usb device
+// 
+
+DECLARE_INTERFACE_(IUSBDevice, IUnknown)
+{
+    DEFINE_ABSTRACT_UNKNOWN()
+
+//----------------------------------------------------------------------------------------
+//
+// Initialize
+//
+// Description: Initializes the usb device
+
+    virtual NTSTATUS Initialize(IN PHUBCONTROLLER HubController,
+                                IN PUSBHARDWAREDEVICE Device,
+                                IN PVOID Parent,
+                                IN ULONG Port) = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// IsHub
+//
+// Description: returns true when device is a hub
+
+    virtual BOOLEAN IsHub() = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// GetParent
+//
+// Description: gets the parent device of the this device
+
+    virtual NTSTATUS GetParent(PVOID * Parent) = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// GetDeviceAddress
+//
+// Description: gets the device address of the this device
+
+    virtual ULONG GetDeviceAddress() = 0;
+
+
+//-----------------------------------------------------------------------------------------
+//
+// GetPort
+//
+// Description: gets the port to which this device is connected
+
+    virtual ULONG GetPort() = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// GetSpeed
+//
+// Description: gets the speed of the device
+
+    virtual USB_DEVICE_SPEED GetSpeed() = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// GetType
+//
+// Description: gets the type of the device, either 1.1 or 2.0 device
+
+    virtual USB_DEVICE_TYPE GetType() = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// GetState
+//
+// Description: gets the device state
+
+    virtual ULONG GetState() = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// SetDeviceHandleData
+//
+// Description: sets device handle data
+
+    virtual void SetDeviceHandleData(PVOID Data) = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// SetDeviceAddress
+//
+// Description: sets device handle data
+
+    virtual NTSTATUS SetDeviceAddress(ULONG DeviceAddress) = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// GetDeviceDescriptor
+//
+// Description: sets device handle data
+
+    virtual void GetDeviceDescriptor(PUSB_DEVICE_DESCRIPTOR DeviceDescriptor) = 0;
+
+//-----------------------------------------------------------------------------------------
+//
+// GetConfigurationValue
+//
+// Description: gets current selected configuration index
+
+   virtual UCHAR GetConfigurationValue();
+
+//-----------------------------------------------------------------------------------------
+//
+// SubmitUrb
+//
+// Description: submits an urb
+
+    virtual NTSTATUS SubmitUrb(PURB Urb) = 0;
+
+};
+
+typedef IUSBDevice *PUSBDEVICE;
+
 #endif

Modified: branches/usb-bringup/drivers/usb/usbehci_new/memory_manager.cpp
URL:
http://svn.reactos.org/svn/reactos/branches/usb-bringup/drivers/usb/usbehci…
==============================================================================
--- branches/usb-bringup/drivers/usb/usbehci_new/memory_manager.cpp [iso-8859-1]
(original)
+++ branches/usb-bringup/drivers/usb/usbehci_new/memory_manager.cpp [iso-8859-1] Sun Apr
17 08:20:40 2011
@@ -85,7 +85,7 @@
     //
     // calculate bitmap length
     //
-    BitmapLength = (DmaBufferSize / DefaultBlockSize) / sizeof(ULONG);
+    BitmapLength = (DmaBufferSize / DefaultBlockSize) / 8;
 
     //
     // allocate bitmap buffer
@@ -102,7 +102,7 @@
     //
     // initialize bitmap
     //
-    RtlInitializeBitMap(&m_Bitmap, m_BitmapBuffer, BitmapLength);
+    RtlInitializeBitMap(&m_Bitmap, m_BitmapBuffer, BitmapLength * 8);
 
     //
     // clear all bits

Added: branches/usb-bringup/drivers/usb/usbehci_new/usb_device.cpp
URL:
http://svn.reactos.org/svn/reactos/branches/usb-bringup/drivers/usb/usbehci…
==============================================================================
--- branches/usb-bringup/drivers/usb/usbehci_new/usb_device.cpp (added)
+++ branches/usb-bringup/drivers/usb/usbehci_new/usb_device.cpp [iso-8859-1] Sun Apr 17
08:20:40 2011
@@ -1,0 +1,22 @@
+/*
+ * PROJECT:     ReactOS Universal Serial Bus Bulk Enhanced Host Controller Interface
+ * LICENSE:     GPL - See COPYING in the top level directory
+ * FILE:        drivers/usb/usbehci/usb_device.cpp
+ * PURPOSE:     USB EHCI device driver.
+ * PROGRAMMERS:
+ *              Michael Martin (michael.martin(a)reactos.org)
+ *              Johannes Anderwald (johannes.anderwald(a)reactos.org)
+ */
+
+#define INITGUID
+#include "usbehci.h"
+
+
+NTSTATUS
+CreateUSBDevice(
+    PUSBDEVICE *OutDevice)
+{
+    UNIMPLEMENTED
+    return STATUS_NOT_IMPLEMENTED;
+}
+

Propchange: branches/usb-bringup/drivers/usb/usbehci_new/usb_device.cpp
------------------------------------------------------------------------------
    svn:eol-style = native

Modified: branches/usb-bringup/drivers/usb/usbehci_new/usbehci.h
URL:
http://svn.reactos.org/svn/reactos/branches/usb-bringup/drivers/usb/usbehci…
==============================================================================
--- branches/usb-bringup/drivers/usb/usbehci_new/usbehci.h [iso-8859-1] (original)
+++ branches/usb-bringup/drivers/usb/usbehci_new/usbehci.h [iso-8859-1] Sun Apr 17
08:20:40 2011
@@ -54,7 +54,6 @@
 // misc.cpp
 //
 NTSTATUS NTAPI SyncForwardIrp(PDEVICE_OBJECT DeviceObject, PIRP Irp);
-
 NTSTATUS NTAPI GetBusInterface(PDEVICE_OBJECT DeviceObject, PBUS_INTERFACE_STANDARD
busInterface);
 
 //
@@ -67,4 +66,10 @@
 //
 NTSTATUS CreateDMAMemoryManager(PDMAMEMORYMANAGER *OutMemoryManager);
 
+
+//
+// usb_device.cpp
+//
+NTSTATUS CreateUSBDevice(PUSBDEVICE *OutDevice);
+
 #endif