[ros-diffs] [ion] 26248: - Revert 26244, 26245, 26246, 26247. - Stop committing on crack. - Read IRC logs and use your head. - GCC 3.4.5 is buggy, don't use. Don't break good code to hide compiler bugs.

2 Apr 2007

Author: ion
Date: Mon Apr  2 19:08:54 2007
New Revision: 26248

URL: http://svn.reactos.org/svn/reactos?rev=26248&view=rev
Log:
- Revert 26244, 26245, 26246, 26247.
- Stop committing on crack.
- Read IRC logs and use your head.
- GCC 3.4.5 is buggy, don't use. Don't break good code to hide compiler bugs.

Modified:
    trunk/reactos/drivers/network/afd/afd/tdi.c
    trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c
    trunk/reactos/ntoskrnl/cm/ntfunc.c
    trunk/reactos/ntoskrnl/ex/sysinfo.c
    trunk/reactos/ntoskrnl/ex/timer.c
    trunk/reactos/ntoskrnl/fsrtl/fastio.c
    trunk/reactos/ntoskrnl/io/iomgr/driver.c
    trunk/reactos/ntoskrnl/io/iomgr/file.c
    trunk/reactos/ntoskrnl/io/iomgr/iofunc.c
    trunk/reactos/ntoskrnl/io/iomgr/irp.c
    trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c
    trunk/reactos/ntoskrnl/ke/i386/usercall.c
    trunk/reactos/ntoskrnl/ke/thrdobj.c
    trunk/reactos/ntoskrnl/mm/section.c
    trunk/reactos/ntoskrnl/mm/virtual.c
    trunk/reactos/ntoskrnl/ob/obdir.c
    trunk/reactos/ntoskrnl/ob/obhandle.c
    trunk/reactos/ntoskrnl/ob/obwait.c
    trunk/reactos/ntoskrnl/ps/job.c
    trunk/reactos/ntoskrnl/ps/query.c
    trunk/reactos/ntoskrnl/ps/thread.c
    trunk/reactos/ntoskrnl/se/acl.c
    trunk/reactos/ntoskrnl/se/priv.c
    trunk/reactos/ntoskrnl/se/sd.c
    trunk/reactos/ntoskrnl/se/sid.c
    trunk/reactos/ntoskrnl/se/token.c
    trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c
    trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c
    trunk/reactos/subsystems/win32/win32k/ntuser/class.c
    trunk/reactos/subsystems/win32/win32k/objects/brush.c
    trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c
    trunk/reactos/subsystems/win32/win32k/objects/coord.c
    trunk/reactos/subsystems/win32/win32k/objects/dc.c
    trunk/reactos/subsystems/win32/win32k/objects/dibobj.c
    trunk/reactos/subsystems/win32/win32k/objects/fillshap.c
    trunk/reactos/subsystems/win32/win32k/objects/line.c
    trunk/reactos/subsystems/win32/win32k/objects/print.c
    trunk/reactos/subsystems/win32/win32k/objects/rect.c
    trunk/reactos/subsystems/win32/win32k/objects/region.c

Modified: trunk/reactos/drivers/network/afd/afd/tdi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/afd/td…
==============================================================================

--- trunk/reactos/drivers/network/afd/afd/tdi.c (original)
+++ trunk/reactos/drivers/network/afd/afd/tdi.c Mon Apr  2 19:08:54 2007
@@ -766,9 +766,9 @@
   PIO_COMPLETION_ROUTINE CompletionRoutine,
   PVOID CompletionContext )
 {
-    PDEVICE_OBJECT DeviceObject = NULL;
+    PDEVICE_OBJECT DeviceObject;
     NTSTATUS Status = STATUS_SUCCESS;
-    PMDL Mdl = NULL;
+    PMDL Mdl;
 
     DeviceObject = IoGetRelatedDeviceObject(TransportObject);
     if (!DeviceObject) {
@@ -843,8 +843,8 @@
     PVOID CompletionContext)
 {
     NTSTATUS Status = STATUS_SUCCESS;
-    PDEVICE_OBJECT DeviceObject = NULL;
-    PMDL Mdl = NULL;
+    PDEVICE_OBJECT DeviceObject;
+    PMDL Mdl;
 
     DeviceObject = IoGetRelatedDeviceObject(TransportObject);
     if (!DeviceObject) {

Modified: trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/tcpi…
==============================================================================
--- trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c (original)
+++ trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c Mon Apr  2 19:08:54 2007
@@ -1265,9 +1265,9 @@
  *     Status of operation
  */
 {
-    PTCP_REQUEST_QUERY_INFORMATION_EX InputBuffer = NULL;
+    PTCP_REQUEST_QUERY_INFORMATION_EX InputBuffer;
     PTRANSPORT_CONTEXT TranContext;
-    PTI_QUERY_CONTEXT QueryContext = NULL;
+    PTI_QUERY_CONTEXT QueryContext;
     PVOID OutputBuffer;
     TDI_REQUEST Request;
     UINT Size;

Modified: trunk/reactos/ntoskrnl/cm/ntfunc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cm/ntfunc.c?rev=2…
==============================================================================
--- trunk/reactos/ntoskrnl/cm/ntfunc.c (original)
+++ trunk/reactos/ntoskrnl/cm/ntfunc.c Mon Apr  2 19:08:54 2007
@@ -299,7 +299,7 @@
   unsigned i;
   REG_PRE_CREATE_KEY_INFORMATION PreCreateKeyInfo;
   REG_POST_CREATE_KEY_INFORMATION PostCreateKeyInfo;
-  KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   UNICODE_STRING CapturedClass = {0};
   HANDLE hKey;
 
@@ -1308,7 +1308,7 @@
 	  IN POBJECT_ATTRIBUTES ObjectAttributes)
 {
   UNICODE_STRING RemainingPath;
-  KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   PVOID Object = NULL;
   HANDLE hKey = NULL;
   NTSTATUS Status = STATUS_SUCCESS;
@@ -2145,7 +2145,7 @@
   NTSTATUS Status;
   REG_DELETE_VALUE_KEY_INFORMATION DeleteValueKeyInfo;
   REG_POST_OPERATION_INFORMATION PostOperationInfo;
-  KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   UNICODE_STRING CapturedValueName;
 
   PAGED_CODE();

Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sysinfo.c?rev=…
==============================================================================
--- trunk/reactos/ntoskrnl/ex/sysinfo.c (original)
+++ trunk/reactos/ntoskrnl/ex/sysinfo.c Mon Apr  2 19:08:54 2007
@@ -232,10 +232,10 @@
   ANSI_STRING AName;
   UNICODE_STRING WName;
   BOOLEAN Result;
-  PCH Value = NULL;
+  PCH Value;
   ANSI_STRING AValue;
   UNICODE_STRING WValue;
-  KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();
@@ -378,7 +378,7 @@
 {
   UNICODE_STRING CapturedName, CapturedValue;
   ANSI_STRING AName, AValue;
-  KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   NTSTATUS Status;
 
   PAGED_CODE();

Modified: trunk/reactos/ntoskrnl/ex/timer.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/timer.c?rev=26…
==============================================================================
--- trunk/reactos/ntoskrnl/ex/timer.c (original)
+++ trunk/reactos/ntoskrnl/ex/timer.c Mon Apr  2 19:08:54 2007
@@ -510,7 +510,7 @@
 {
     PETIMER Timer;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
-    NTSTATUS Status = STATUS_UNSUCCESSFUL;
+    NTSTATUS Status;
     PTIMER_BASIC_INFORMATION BasicInfo = TimerInformation;
     PAGED_CODE();
 

Modified: trunk/reactos/ntoskrnl/fsrtl/fastio.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/fastio.c?re…
==============================================================================
--- trunk/reactos/ntoskrnl/fsrtl/fastio.c (original)
+++ trunk/reactos/ntoskrnl/fsrtl/fastio.c Mon Apr  2 19:08:54 2007
@@ -83,7 +83,7 @@
               IN PDEVICE_OBJECT DeviceObject)
 {
 
-    PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL;
+    PFSRTL_COMMON_FCB_HEADER FcbHeader;
     LARGE_INTEGER Offset;
     PFAST_IO_DISPATCH FastIoDispatch;
     PDEVICE_OBJECT Device;
@@ -258,7 +258,7 @@
     BOOLEAN Result = TRUE;
     PFAST_IO_DISPATCH FastIoDispatch;
     PDEVICE_OBJECT Device;
-    PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL;
+    PFSRTL_COMMON_FCB_HEADER FcbHeader;
 
     /* WDK doc. Offset=0xffffffffffffffff indicates append to the end of file */
     BOOLEAN FileOffsetAppend = ((FileOffset->HighPart == 0xffffffff) &&
(FileOffset->LowPart == 0xffffffff));
@@ -915,7 +915,7 @@
                 OUT PIO_STATUS_BLOCK IoStatus,
                 IN PDEVICE_OBJECT DeviceObject)
 {
-    PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL;
+    PFSRTL_COMMON_FCB_HEADER FcbHeader;
     BOOLEAN Result = TRUE;
     LARGE_INTEGER Offset;
     PFAST_IO_DISPATCH FastIoDispatch;
@@ -1159,7 +1159,7 @@
     BOOLEAN Result = TRUE;
     PFAST_IO_DISPATCH FastIoDispatch;
     PDEVICE_OBJECT Device;
-    PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL;
+    PFSRTL_COMMON_FCB_HEADER FcbHeader;
     
     LARGE_INTEGER OldFileSize;
     LARGE_INTEGER OldValidDataLength;

Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/driver.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/driver.c Mon Apr  2 19:08:54 2007
@@ -1475,7 +1475,7 @@
    UNICODE_STRING ImagePath;
    UNICODE_STRING ServiceName;
    UNICODE_STRING CapturedDriverServiceName = {0};
-   KPROCESSOR_MODE PreviousMode = {0};
+   KPROCESSOR_MODE PreviousMode;
    NTSTATUS Status;
    ULONG Type;
    PDEVICE_NODE DeviceNode;

Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/file.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c Mon Apr  2 19:08:54 2007
@@ -1629,7 +1629,7 @@
              IN PVOID ExtraCreateParameters OPTIONAL,
              IN ULONG Options)
 {
-    KPROCESSOR_MODE AccessMode = {0};
+    KPROCESSOR_MODE AccessMode;
     HANDLE LocalHandle = 0;
     LARGE_INTEGER SafeAllocationSize;
     PVOID SystemEaBuffer = NULL;

Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Mon Apr  2 19:08:54 2007
@@ -198,12 +198,12 @@
 {
     NTSTATUS Status = STATUS_SUCCESS;
     PFILE_OBJECT FileObject;
-    PDEVICE_OBJECT DeviceObject = NULL;
-    PIRP Irp = NULL;
+    PDEVICE_OBJECT DeviceObject;
+    PIRP Irp;
     PIO_STACK_LOCATION StackPtr;
     PKEVENT EventObject = NULL;
     BOOLEAN LockedForSynch = FALSE;
-    ULONG AccessType = 0;
+    ULONG AccessType;
     OBJECT_HANDLE_INFORMATION HandleInformation;
     ACCESS_MASK DesiredAccess;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
@@ -1212,9 +1212,9 @@
 {
     PFILE_OBJECT FileObject;
     PLARGE_INTEGER LocalLength = NULL;
-    PIRP Irp = NULL;
-    PIO_STACK_LOCATION StackPtr = NULL;
-    PDEVICE_OBJECT DeviceObject = NULL;
+    PIRP Irp;
+    PIO_STACK_LOCATION StackPtr;
+    PDEVICE_OBJECT DeviceObject;
     PKEVENT Event = NULL;
     BOOLEAN LockedForSync = FALSE;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
@@ -1386,8 +1386,8 @@
                      IN PUNICODE_STRING FileName OPTIONAL,
                      IN BOOLEAN RestartScan)
 {
-    PIRP Irp = NULL;
-    PDEVICE_OBJECT DeviceObject = NULL;
+    PIRP Irp;
+    PDEVICE_OBJECT DeviceObject;
     PFILE_OBJECT FileObject;
     PIO_STACK_LOCATION StackPtr;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
@@ -1627,9 +1627,9 @@
     OBJECT_HANDLE_INFORMATION HandleInformation;
     PFILE_OBJECT FileObject;
     NTSTATUS Status = STATUS_SUCCESS;
-    PIRP Irp = NULL;
-    PDEVICE_OBJECT DeviceObject = NULL;
-    PIO_STACK_LOCATION StackPtr = NULL;
+    PIRP Irp;
+    PDEVICE_OBJECT DeviceObject;
+    PIO_STACK_LOCATION StackPtr;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
@@ -1938,8 +1938,8 @@
 {
     NTSTATUS Status = STATUS_SUCCESS;
     PFILE_OBJECT FileObject;
-    PIRP Irp = NULL;
-    PDEVICE_OBJECT DeviceObject = NULL;
+    PIRP Irp;
+    PDEVICE_OBJECT DeviceObject;
     PIO_STACK_LOCATION StackPtr;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
     PKEVENT EventObject = NULL;
@@ -2197,9 +2197,9 @@
 {
     PFILE_OBJECT FileObject;
     NTSTATUS Status = STATUS_SUCCESS;
-    PIRP Irp = NULL;
-    PDEVICE_OBJECT DeviceObject = NULL;
-    PIO_STACK_LOCATION StackPtr = NULL;
+    PIRP Irp;
+    PDEVICE_OBJECT DeviceObject;
+    PIO_STACK_LOCATION StackPtr;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
@@ -2576,9 +2576,9 @@
 {
     PFILE_OBJECT FileObject;
     PLARGE_INTEGER LocalLength = NULL;
-    PIRP Irp = NULL;
-    PIO_STACK_LOCATION StackPtr = NULL;
-    PDEVICE_OBJECT DeviceObject = NULL;
+    PIRP Irp;
+    PIO_STACK_LOCATION StackPtr;
+    PDEVICE_OBJECT DeviceObject;
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
@@ -2760,8 +2760,8 @@
 {
     NTSTATUS Status = STATUS_SUCCESS;
     PFILE_OBJECT FileObject;
-    PIRP Irp = NULL;
-    PDEVICE_OBJECT DeviceObject = NULL;
+    PIRP Irp;
+    PDEVICE_OBJECT DeviceObject;
     PIO_STACK_LOCATION StackPtr;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
     PKEVENT EventObject = NULL;
@@ -3027,9 +3027,9 @@
                              IN FS_INFORMATION_CLASS FsInformationClass)
 {
     PFILE_OBJECT FileObject;
-    PIRP Irp = NULL;
-    PIO_STACK_LOCATION StackPtr = NULL;
-    PDEVICE_OBJECT DeviceObject = NULL;
+    PIRP Irp;
+    PIO_STACK_LOCATION StackPtr;
+    PDEVICE_OBJECT DeviceObject;
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
@@ -3190,9 +3190,9 @@
                            IN FS_INFORMATION_CLASS FsInformationClass)
 {
     PFILE_OBJECT FileObject;
-    PIRP Irp = NULL;
-    PIO_STACK_LOCATION StackPtr = NULL;
-    PDEVICE_OBJECT DeviceObject = NULL;
+    PIRP Irp;
+    PIO_STACK_LOCATION StackPtr;
+    PDEVICE_OBJECT DeviceObject;
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();

Modified: trunk/reactos/ntoskrnl/io/iomgr/irp.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/irp.c?re…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/irp.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/irp.c Mon Apr  2 19:08:54 2007
@@ -610,8 +610,8 @@
                               IN PLARGE_INTEGER StartingOffset,
                               IN PIO_STATUS_BLOCK IoStatusBlock)
 {
-    PIRP Irp = NULL;
-    PIO_STACK_LOCATION StackPtr = NULL;
+    PIRP Irp;
+    PIO_STACK_LOCATION StackPtr;
 
     /* Allocate IRP */
     Irp = IoAllocateIrp(DeviceObject->StackSize, FALSE);
@@ -745,7 +745,7 @@
                               IN PKEVENT Event,
                               IN PIO_STATUS_BLOCK IoStatusBlock)
 {
-    PIRP Irp = NULL;
+    PIRP Irp;
     PIO_STACK_LOCATION StackPtr;
     ULONG BufferLength;
 

Modified: trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/plugpla…
==============================================================================
--- trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c (original)
+++ trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c Mon Apr  2 19:08:54 2007
@@ -443,7 +443,7 @@
     UNICODE_STRING DeviceInstance;
     ULONG BufferSize;
     ULONG Property = 0;
-    PVOID Buffer = NULL;
+    PVOID Buffer;
 
     DPRINT("IopGetDeviceProperty() called\n");
     DPRINT("Device name: %wZ\n", &PropertyData->DeviceInstance);

Modified: trunk/reactos/ntoskrnl/ke/i386/usercall.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/usercall.…
==============================================================================
--- trunk/reactos/ntoskrnl/ke/i386/usercall.c (original)
+++ trunk/reactos/ntoskrnl/ke/i386/usercall.c Mon Apr  2 19:08:54 2007
@@ -148,8 +148,8 @@
                    OUT PVOID *Result,
                    OUT PULONG ResultLength)
 {
-    ULONG_PTR NewStack =0, OldStack = 0;
-    PULONG UserEsp = NULL;
+    ULONG_PTR NewStack, OldStack;
+    PULONG UserEsp;
     NTSTATUS CallbackStatus = STATUS_SUCCESS;
     PEXCEPTION_REGISTRATION_RECORD ExceptionList;
     PTEB Teb;

Modified: trunk/reactos/ntoskrnl/ke/thrdobj.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/thrdobj.c?rev=…
==============================================================================
--- trunk/reactos/ntoskrnl/ke/thrdobj.c (original)
+++ trunk/reactos/ntoskrnl/ke/thrdobj.c Mon Apr  2 19:08:54 2007
@@ -723,7 +723,7 @@
     ULONG i;
     PKWAIT_BLOCK TimerWaitBlock;
     PKTIMER Timer;
-    NTSTATUS Status = STATUS_UNSUCCESSFUL;
+    NTSTATUS Status;
 
     /* Initalize the Dispatcher Header */
     KeInitializeDispatcherHeader(&Thread->DispatcherHeader,

Modified: trunk/reactos/ntoskrnl/mm/section.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=…
==============================================================================
--- trunk/reactos/ntoskrnl/mm/section.c (original)
+++ trunk/reactos/ntoskrnl/mm/section.c Mon Apr  2 19:08:54 2007
@@ -3670,7 +3670,7 @@
    SIZE_T SafeViewSize;
    PROS_SECTION_OBJECT Section;
    PEPROCESS Process;
-   KPROCESSOR_MODE PreviousMode = {0};
+   KPROCESSOR_MODE PreviousMode;
    PMADDRESS_SPACE AddressSpace;
    NTSTATUS Status = STATUS_SUCCESS;
    ULONG tmpProtect;

Modified: trunk/reactos/ntoskrnl/mm/virtual.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/virtual.c?rev=…
==============================================================================
--- trunk/reactos/ntoskrnl/mm/virtual.c (original)
+++ trunk/reactos/ntoskrnl/mm/virtual.c Mon Apr  2 19:08:54 2007
@@ -554,10 +554,10 @@
                     IN ULONG NumberOfBytesToRead,
                     OUT PULONG NumberOfBytesRead OPTIONAL)
 {
-   PMDL Mdl = NULL;
+   PMDL Mdl;
    PVOID SystemAddress;
-   KPROCESSOR_MODE PreviousMode = {0};
-   PEPROCESS Process, CurrentProcess = NULL;
+   KPROCESSOR_MODE PreviousMode;
+   PEPROCESS Process, CurrentProcess;
    NTSTATUS Status = STATUS_SUCCESS;
 
    PAGED_CODE();
@@ -769,11 +769,11 @@
                      IN ULONG NumberOfBytesToWrite,
                      OUT PULONG NumberOfBytesWritten  OPTIONAL)
 {
-   PMDL Mdl = NULL;
-   PVOID SystemAddress = NULL;
+   PMDL Mdl;
+   PVOID SystemAddress;
    PEPROCESS Process;
-   KPROCESSOR_MODE PreviousMode = {0};
-   NTSTATUS CopyStatus = STATUS_SUCCESS, Status = STATUS_SUCCESS;
+   KPROCESSOR_MODE PreviousMode;
+   NTSTATUS CopyStatus, Status = STATUS_SUCCESS;
 
    DPRINT("NtWriteVirtualMemory(ProcessHandle %x, BaseAddress %x, "
           "Buffer %x, NumberOfBytesToWrite %d)\n",ProcessHandle,BaseAddress,

Modified: trunk/reactos/ntoskrnl/ob/obdir.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obdir.c?rev=26…
==============================================================================
--- trunk/reactos/ntoskrnl/ob/obdir.c (original)
+++ trunk/reactos/ntoskrnl/ob/obdir.c Mon Apr  2 19:08:54 2007
@@ -466,7 +466,7 @@
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     ULONG SkipEntries = 0;
     NTSTATUS Status = STATUS_SUCCESS;
-    PVOID LocalBuffer = NULL;
+    PVOID LocalBuffer;
     POBJECT_DIRECTORY_INFORMATION DirectoryInfo;
     ULONG Length, TotalLength;
     ULONG Count, CurrentEntry;

Modified: trunk/reactos/ntoskrnl/ob/obhandle.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev…
==============================================================================
--- trunk/reactos/ntoskrnl/ob/obhandle.c (original)
+++ trunk/reactos/ntoskrnl/ob/obhandle.c Mon Apr  2 19:08:54 2007
@@ -3150,7 +3150,7 @@
                   IN ULONG HandleAttributes,
                   IN ULONG Options)
 {
-    PEPROCESS SourceProcess, TargetProcess, Target = NULL;
+    PEPROCESS SourceProcess, TargetProcess, Target;
     HANDLE hTarget;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     NTSTATUS Status = STATUS_SUCCESS;

Modified: trunk/reactos/ntoskrnl/ob/obwait.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obwait.c?rev=2…
==============================================================================
--- trunk/reactos/ntoskrnl/ob/obwait.c (original)
+++ trunk/reactos/ntoskrnl/ob/obwait.c Mon Apr  2 19:08:54 2007
@@ -56,7 +56,7 @@
     ULONG i = 0, ReferencedObjects = 0, j;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     LARGE_INTEGER SafeTimeOut;
-    BOOLEAN LockInUse = FALSE;
+    BOOLEAN LockInUse;
     PHANDLE_TABLE_ENTRY HandleEntry;
     POBJECT_HEADER ObjectHeader;
     PHANDLE_TABLE HandleTable;
@@ -457,7 +457,7 @@
 {
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     POBJECT_TYPE Type;
-    PVOID SignalObj, WaitObj, WaitableObject = NULL;
+    PVOID SignalObj, WaitObj, WaitableObject;
     LARGE_INTEGER SafeTimeOut;
     OBJECT_HANDLE_INFORMATION HandleInfo;
     NTSTATUS Status = STATUS_SUCCESS;

Modified: trunk/reactos/ntoskrnl/ps/job.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/job.c?rev=2624…
==============================================================================
--- trunk/reactos/ntoskrnl/ps/job.c (original)
+++ trunk/reactos/ntoskrnl/ps/job.c Mon Apr  2 19:08:54 2007
@@ -225,8 +225,8 @@
 {
     HANDLE hJob;
     PEJOB Job;
-    KPROCESSOR_MODE PreviousMode = {0};
-    PEPROCESS CurrentProcess = NULL;
+    KPROCESSOR_MODE PreviousMode;
+    PEPROCESS CurrentProcess;
     NTSTATUS Status = STATUS_SUCCESS;
 
     PAGED_CODE();
@@ -396,7 +396,7 @@
     ACCESS_MASK DesiredAccess,
     POBJECT_ATTRIBUTES ObjectAttributes)
 {
-    KPROCESSOR_MODE PreviousMode = {0};
+    KPROCESSOR_MODE PreviousMode;
     HANDLE hJob;
     NTSTATUS Status = STATUS_SUCCESS;
 

Modified: trunk/reactos/ntoskrnl/ps/query.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/query.c?rev=26…
==============================================================================
--- trunk/reactos/ntoskrnl/ps/query.c (original)
+++ trunk/reactos/ntoskrnl/ps/query.c Mon Apr  2 19:08:54 2007
@@ -484,7 +484,7 @@
     PEPROCESS Process;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     ACCESS_MASK Access;
-    NTSTATUS Status = STATUS_NOT_IMPLEMENTED;
+    NTSTATUS Status;
     HANDLE PortHandle = NULL;
     HANDLE TokenHandle = NULL;
     PROCESS_SESSION_INFORMATION SessionInfo = {0};
@@ -719,7 +719,7 @@
     PETHREAD Thread;
     ULONG Access;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
-    NTSTATUS Status = STATUS_INVALID_PARAMETER;
+    NTSTATUS Status;
     HANDLE TokenHandle = NULL;
     KPRIORITY Priority = 0;
     KAFFINITY Affinity = 0, CombinedAffinity;

Modified: trunk/reactos/ntoskrnl/ps/thread.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/thread.c?rev=2…
==============================================================================
--- trunk/reactos/ntoskrnl/ps/thread.c (original)
+++ trunk/reactos/ntoskrnl/ps/thread.c Mon Apr  2 19:08:54 2007
@@ -141,7 +141,7 @@
 PspSystemThreadStartup(IN PKSTART_ROUTINE StartRoutine,
                        IN PVOID StartContext)
 {
-    PETHREAD Thread = NULL;
+    PETHREAD Thread;
     PSTRACE(PS_THREAD_DEBUG,
             "StartRoutine: %p StartContext: %p\n", StartRoutine,
StartContext);
 

Modified: trunk/reactos/ntoskrnl/se/acl.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/acl.c?rev=2624…
==============================================================================
--- trunk/reactos/ntoskrnl/se/acl.c (original)
+++ trunk/reactos/ntoskrnl/se/acl.c Mon Apr  2 19:08:54 2007
@@ -275,7 +275,7 @@
               IN BOOLEAN CaptureIfKernel,
               OUT PACL *CapturedAcl)
 {
-  PACL NewAcl = NULL;
+  PACL NewAcl;
   ULONG AclSize = 0;
   NTSTATUS Status = STATUS_SUCCESS;
 

Modified: trunk/reactos/ntoskrnl/se/priv.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/priv.c?rev=262…
==============================================================================
--- trunk/reactos/ntoskrnl/se/priv.c (original)
+++ trunk/reactos/ntoskrnl/se/priv.c Mon Apr  2 19:08:54 2007
@@ -184,7 +184,7 @@
 				 PLUID_AND_ATTRIBUTES* Dest,
 				 PULONG Length)
 {
-    ULONG BufferSize = 0;
+    ULONG BufferSize;
     NTSTATUS Status = STATUS_SUCCESS;
 
     PAGED_CODE();
@@ -300,7 +300,7 @@
   ULONG PrivilegeControl = 0;
   ULONG Length;
   BOOLEAN CheckResult;
-  KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();

Modified: trunk/reactos/ntoskrnl/se/sd.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sd.c?rev=26248…
==============================================================================
--- trunk/reactos/ntoskrnl/se/sd.c (original)
+++ trunk/reactos/ntoskrnl/se/sd.c Mon Apr  2 19:08:54 2007
@@ -394,7 +394,7 @@
 {
   PISECURITY_DESCRIPTOR OriginalSecurityDescriptor = _OriginalSecurityDescriptor;
   SECURITY_DESCRIPTOR DescriptorCopy;
-  PISECURITY_DESCRIPTOR NewDescriptor = NULL;
+  PISECURITY_DESCRIPTOR NewDescriptor;
   ULONG OwnerSAC = 0, GroupSAC = 0;
   ULONG OwnerSize = 0, GroupSize = 0;
   ULONG SaclSize = 0, DaclSize = 0;

Modified: trunk/reactos/ntoskrnl/se/sid.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sid.c?rev=2624…
==============================================================================
--- trunk/reactos/ntoskrnl/se/sid.c (original)
+++ trunk/reactos/ntoskrnl/se/sid.c Mon Apr  2 19:08:54 2007
@@ -236,7 +236,7 @@
               OUT PSID *CapturedSid)
 {
   ULONG SidSize = 0;
-  PISID NewSid = NULL, Sid = (PISID)InputSid;
+  PISID NewSid, Sid = (PISID)InputSid;
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();

Modified: trunk/reactos/ntoskrnl/se/token.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/token.c?rev=26…
==============================================================================
--- trunk/reactos/ntoskrnl/se/token.c (original)
+++ trunk/reactos/ntoskrnl/se/token.c Mon Apr  2 19:08:54 2007
@@ -669,8 +669,8 @@
     ULONG Ulong;
   } Unused;
   PTOKEN Token;
-  ULONG RequiredLength = 0;
-  KPROCESSOR_MODE PreviousMode = {0};
+  ULONG RequiredLength;
+  KPROCESSOR_MODE PreviousMode;
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();
@@ -1253,7 +1253,7 @@
 		      IN ULONG TokenInformationLength)
 {
   PTOKEN Token;
-  KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   ULONG NeededAccess = TOKEN_ADJUST_DEFAULT;
   NTSTATUS Status = STATUS_SUCCESS;
 
@@ -1496,7 +1496,7 @@
                  IN TOKEN_TYPE TokenType,
                  OUT PHANDLE NewTokenHandle)
 {
-    KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   HANDLE hToken;
   PTOKEN Token;
   PTOKEN NewToken;
@@ -2134,7 +2134,7 @@
   PVOID EndMem;
   ULONG uLength;
   ULONG i;
-  KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   ULONG nTokenPrivileges = 0;
   LARGE_INTEGER LocalExpirationTime = {{0}};
   NTSTATUS Status = STATUS_SUCCESS;
@@ -2464,7 +2464,7 @@
   OBJECT_ATTRIBUTES ObjectAttributes;
   SECURITY_DESCRIPTOR SecurityDescriptor;
   PACL Dacl = NULL;
-  KPROCESSOR_MODE PreviousMode = {0};
+  KPROCESSOR_MODE PreviousMode;
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();
@@ -2661,7 +2661,7 @@
                 IN HANDLE SecondTokenHandle,
                 OUT PBOOLEAN Equal)
 {
-    KPROCESSOR_MODE PreviousMode = {0};
+    KPROCESSOR_MODE PreviousMode;
     PTOKEN FirstToken, SecondToken;
     BOOLEAN IsEqual;
     NTSTATUS Status = STATUS_SUCCESS;

Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c (original)
+++ trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c Mon Apr  2 19:08:54 2007
@@ -40,11 +40,11 @@
     HANDLE *puhSurface
 )
 {
-    INT i = 0;
+    INT i;
     DWORD  ddRVal = DDHAL_DRIVER_NOTHANDLED;
     NTSTATUS Status = FALSE;
-    PDD_DIRECTDRAW pDirectDraw = NULL;
-    PDD_SURFACE phsurface = NULL;
+    PDD_DIRECTDRAW pDirectDraw;
+    PDD_SURFACE phsurface;
 
     PDD_SURFACE_LOCAL pLocal;
     PDD_SURFACE_MORE pMore;
@@ -53,7 +53,7 @@
     DD_CREATESURFACEDATA CreateSurfaceData;
 
     /* FIXME alloc so mayne we need */
-    PHANDLE *myhSurface = NULL;
+    PHANDLE *myhSurface;
 
     /* GCC4  warnns on value are unisitaed,
        but they are initated in seh 
@@ -508,7 +508,7 @@
 {
     DWORD  ddRVal = DDHAL_DRIVER_NOTHANDLED;
     DD_GETSCANLINEDATA GetScanLineData;
-    PDD_DIRECTDRAW pDirectDraw = NULL;
+    PDD_DIRECTDRAW pDirectDraw;
     NTSTATUS Status = FALSE;
 
     DPRINT1("NtGdiDdGetScanLine\n");

Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c (original)
+++ trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c Mon Apr  2 19:08:54 2007
@@ -292,7 +292,7 @@
     DWORD *puFourCC
 )
 {
-    PDD_DIRECTDRAW pDirectDraw = NULL;
+    PDD_DIRECTDRAW pDirectDraw;
     NTSTATUS Status = FALSE;
     BOOL Ret=FALSE;
 
@@ -549,7 +549,7 @@
 {
     BOOL Ret=FALSE;
     NTSTATUS Status = FALSE;
-    PDD_DIRECTDRAW pDirectDraw = NULL;
+    PDD_DIRECTDRAW pDirectDraw;
 
     if (hDirectDrawLocal == NULL)
     {

Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Mon Apr  2 19:08:54 2007
@@ -1137,7 +1137,7 @@
                   IN DWORD dwFlags)
 {
     PW32THREADINFO ti;
-    PW32PROCESSINFO pi = NULL;
+    PW32PROCESSINFO pi;
     PWINDOWCLASS Class;
     RTL_ATOM ClassAtom;
     RTL_ATOM Ret = (RTL_ATOM)0;
@@ -1484,7 +1484,7 @@
     if (MenuName->Length != 0)
     {
         ANSI_STRING AnsiString;
-        PWSTR strBufW = NULL;
+        PWSTR strBufW;
 
         AnsiString.MaximumLength = RtlUnicodeStringToAnsiSize(MenuName);
 

Modified: trunk/reactos/subsystems/win32/win32k/objects/brush.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/brush.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/brush.c Mon Apr  2 19:08:54 2007
@@ -628,7 +628,7 @@
    IN BOOL bPen,
    IN PVOID PackedDIB)
 {
-   BITMAPINFO *SafeBitmapInfoAndData = NULL;
+   BITMAPINFO *SafeBitmapInfoAndData;
    NTSTATUS Status = STATUS_SUCCESS;
    HBRUSH hBrush;
 

Modified: trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c Mon Apr  2 19:08:54 2007
@@ -203,7 +203,7 @@
 int STDCALL NtGdiGetClipBox(HDC  hDC,
 			   LPRECT  rc)
 {
-  int Ret = FALSE;
+  int Ret;
   NTSTATUS Status = STATUS_SUCCESS;
   RECT Saferect;
 

Modified: trunk/reactos/subsystems/win32/win32k/objects/coord.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/coord.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/coord.c Mon Apr  2 19:08:54 2007
@@ -82,7 +82,7 @@
   XFORM  xformTemp;
   XFORM  xform1 = {0}, xform2 = {0};
   NTSTATUS Status = STATUS_SUCCESS;
-  BOOL Ret = FALSE;
+  BOOL Ret;
 
   _SEH_TRY
   {
@@ -170,10 +170,10 @@
 	   LPPOINT  UnsafePoints,
 	   int  Count)
 {
-   PDC dc = NULL;
+   PDC dc;
    NTSTATUS Status = STATUS_SUCCESS;
-   LPPOINT Points = NULL;
-   ULONG Size = 0;
+   LPPOINT Points;
+   ULONG Size;
 
    dc = DC_LockDc(hDC);
    if (!dc)
@@ -320,7 +320,7 @@
 NtGdiGetWorldTransform(HDC  hDC,
                       LPXFORM  XForm)
 {
-  PDC  dc = NULL;
+  PDC  dc;
   NTSTATUS Status = STATUS_SUCCESS;
 
   dc = DC_LockDc ( hDC );
@@ -393,10 +393,10 @@
 BOOL STDCALL
 NtGdiLPtoDP ( HDC hDC, LPPOINT UnsafePoints, INT Count )
 {
-   PDC dc = NULL;
+   PDC dc;
    NTSTATUS Status = STATUS_SUCCESS;
-   LPPOINT Points = NULL;
-   ULONG Size = 0;
+   LPPOINT Points;
+   ULONG Size;
 
    dc = DC_LockDc(hDC);
    if (!dc)
@@ -479,7 +479,7 @@
                           CONST LPXFORM  UnsafeXForm,
                           DWORD Mode)
 {
-   PDC dc = NULL;
+   PDC dc;
    XFORM SafeXForm;
    BOOL Ret = FALSE;
 
@@ -520,7 +520,7 @@
                         int YOffset,
                         LPPOINT UnsafePoint)
 {
-  PDC      dc = NULL;
+  PDC      dc;
   NTSTATUS Status = STATUS_SUCCESS;
 
   dc = DC_LockDc ( hDC );
@@ -569,7 +569,7 @@
                       int  YOffset,
                       LPPOINT  Point)
 {
-  PDC dc = NULL;
+  PDC dc;
 
   dc = DC_LockDc(hDC);
   if (!dc)
@@ -758,7 +758,7 @@
                       int  YExtent,
                       LPSIZE  Size)
 {
-  PDC dc = NULL;
+  PDC dc;
 
   dc = DC_LockDc(hDC);
   if ( !dc )
@@ -830,7 +830,7 @@
                      int  Y,
                      LPPOINT  Point)
 {
-  PDC dc = NULL;
+  PDC dc;
 
   dc = DC_LockDc(hDC);
   if (!dc)
@@ -881,7 +881,7 @@
                    int  YExtent,
                    LPSIZE  Size)
 {
-  PDC dc = NULL;
+  PDC dc;
 
   dc = DC_LockDc(hDC);
   if (!dc)
@@ -944,7 +944,7 @@
                    int  Y,
                    LPPOINT  Point)
 {
-  PDC dc = NULL;
+  PDC dc;
 
   dc = DC_LockDc(hDC);
   if (!dc)
@@ -993,7 +993,7 @@
 NtGdiSetWorldTransform(HDC  hDC,
                       CONST LPXFORM  XForm)
 {
-  PDC  dc = NULL;
+  PDC  dc;
   NTSTATUS Status = STATUS_SUCCESS;
 
   dc = DC_LockDc (hDC);

Modified: trunk/reactos/subsystems/win32/win32k/objects/dc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/dc.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/dc.c Mon Apr  2 19:08:54 2007
@@ -1249,8 +1249,8 @@
 BOOL STDCALL
 NtGdiGetDCOrgEx(HDC  hDC, LPPOINT  Point)
 {
-  BOOL Ret = FALSE;
-  DC *dc = NULL;
+  BOOL Ret;
+  DC *dc;
   POINT SafePoint;
   NTSTATUS Status = STATUS_SUCCESS;
 
@@ -1812,7 +1812,7 @@
 NtGdiGetObject(HANDLE handle, INT count, LPVOID buffer)
 {
   INT Ret = 0;
-  LPVOID SafeBuf = NULL;
+  LPVOID SafeBuf;
   NTSTATUS Status = STATUS_SUCCESS;
   INT RetCount = 0;
 

Modified: trunk/reactos/subsystems/win32/win32k/objects/dibobj.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/dibobj.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/dibobj.c Mon Apr  2 19:08:54 2007
@@ -27,9 +27,9 @@
 UINT STDCALL
 NtGdiSetDIBColorTable(HDC hDC, UINT StartIndex, UINT Entries, CONST RGBQUAD *Colors)
 {
-   PDC dc = NULL;
-   PBITMAPOBJ BitmapObj = NULL;
-   PPALGDI PalGDI = NULL;
+   PDC dc;
+   PBITMAPOBJ BitmapObj;
+   PPALGDI PalGDI;
    UINT Index;
 
    if (!(dc = DC_LockDc(hDC))) return 0;
@@ -92,9 +92,9 @@
 UINT STDCALL
 NtGdiGetDIBColorTable(HDC hDC, UINT StartIndex, UINT Entries, RGBQUAD *Colors)
 {
-   PDC dc = NULL;
-   PBITMAPOBJ BitmapObj = NULL;
-   PPALGDI PalGDI = NULL;
+   PDC dc;
+   PBITMAPOBJ BitmapObj;
+   PPALGDI PalGDI;
    UINT Index;
 
    if (!(dc = DC_LockDc(hDC))) return 0;

Modified: trunk/reactos/subsystems/win32/win32k/objects/fillshap.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/fillshap.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/fillshap.c Mon Apr  2 19:08:54 2007
@@ -827,8 +827,8 @@
              CONST PPOINT UnsafePoints,
              int          Count)
 {
-  DC *dc = NULL;
-  LPPOINT Safept = NULL;
+  DC *dc;
+  LPPOINT Safept;
   NTSTATUS Status = STATUS_SUCCESS;
   BOOL Ret = FALSE;
 
@@ -906,9 +906,9 @@
                  CONST LPINT   PolyCounts,
                  int           Count)
 {
-  DC *dc = NULL;
-  LPPOINT Safept = NULL;
-  LPINT SafePolyPoints = NULL;
+  DC *dc;
+  LPPOINT Safept;
+  LPINT SafePolyPoints;
   NTSTATUS Status = STATUS_SUCCESS;
   BOOL Ret;
 
@@ -1559,11 +1559,11 @@
   ULONG uMesh,
   ULONG ulMode)
 {
-  DC *dc = NULL;
+  DC *dc;
   BOOL Ret;
-  PTRIVERTEX SafeVertex = NULL;
-  PVOID SafeMesh = NULL;
-  ULONG SizeMesh = 0;
+  PTRIVERTEX SafeVertex;
+  PVOID SafeMesh;
+  ULONG SizeMesh;
   NTSTATUS Status = STATUS_SUCCESS;
 
   dc = DC_LockDc(hdc);

Modified: trunk/reactos/subsystems/win32/win32k/objects/line.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/line.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/line.c Mon Apr  2 19:08:54 2007
@@ -501,7 +501,7 @@
              int      Y,
              LPPOINT  Point)
 {
-  DC *dc = NULL;
+  DC *dc;
   POINT SafePoint;
   NTSTATUS Status = STATUS_SUCCESS;
   BOOL Ret;
@@ -554,8 +554,8 @@
                CONST LPPOINT  pt,
                DWORD          Count)
 {
-  DC *dc = NULL;
-  LPPOINT Safept = NULL;
+  DC *dc;
+  LPPOINT Safept;
   NTSTATUS Status = STATUS_SUCCESS;
   BOOL Ret;
 
@@ -642,8 +642,8 @@
                  CONST LPPOINT  pt,
                  DWORD  Count)
 {
-  DC *dc = NULL;
-  LPPOINT Safept = NULL;
+  DC *dc;
+  LPPOINT Safept;
   NTSTATUS Status = STATUS_SUCCESS;
   BOOL Ret;
 
@@ -732,7 +732,7 @@
     IN LPBYTE lpbTypes,
     IN ULONG cCount)
 {
-    PDC dc = NULL;
+    PDC dc;
     BOOL result = FALSE;
     POINT lastmove;
     unsigned int i;
@@ -806,8 +806,8 @@
              CONST LPPOINT  pt,
              int            Count)
 {
-  DC *dc = NULL;
-  LPPOINT Safept = NULL;
+  DC *dc;
+  LPPOINT Safept;
   NTSTATUS Status = STATUS_SUCCESS;
   BOOL Ret;
 
@@ -894,8 +894,8 @@
                CONST LPPOINT  pt,
                DWORD          Count)
 {
-  DC *dc = NULL;
-  LPPOINT Safept = NULL;
+  DC *dc;
+  LPPOINT Safept;
   NTSTATUS Status = STATUS_SUCCESS;
   BOOL Ret;
 
@@ -983,9 +983,9 @@
                  CONST LPDWORD  PolyPoints,
                  DWORD          Count)
 {
-  DC *dc = NULL;
-  LPPOINT Safept = NULL;
-  LPDWORD SafePolyPoints = NULL;
+  DC *dc;
+  LPPOINT Safept;
+  LPDWORD SafePolyPoints;
   NTSTATUS Status = STATUS_SUCCESS;
   BOOL Ret;
 

Modified: trunk/reactos/subsystems/win32/win32k/objects/print.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/print.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/print.c Mon Apr  2 19:08:54 2007
@@ -160,7 +160,7 @@
    LPVOID   SafeInData = NULL;
    LPVOID   SafeOutData = NULL;
    NTSTATUS Status = STATUS_SUCCESS;
-   INT      Result = 0;
+   INT      Result;
 
    if ( pDC == NULL )
    {

Modified: trunk/reactos/subsystems/win32/win32k/objects/rect.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/rect.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/rect.c Mon Apr  2 19:08:54 2007
@@ -188,7 +188,7 @@
 {
     RECT Dest, Src1 = {0}, Src2 = {0};
   NTSTATUS Status = STATUS_SUCCESS;
-  BOOL Ret = FALSE;
+  BOOL Ret;
 
   _SEH_TRY
   {
@@ -300,7 +300,7 @@
 {
   RECT Dest, Src1, Src2 = {0};
   NTSTATUS Status = STATUS_SUCCESS;
-  BOOL Ret = FALSE;
+  BOOL Ret;
 
   _SEH_TRY
   {

Modified: trunk/reactos/subsystems/win32/win32k/objects/region.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/region.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/region.c Mon Apr  2 19:08:54 2007
@@ -2253,8 +2253,8 @@
                           DWORD Count,
                           LPRGNDATA RgnData)
 {
-   HRGN hRgn = 0;
-   PROSRGNDATA Region = NULL;
+   HRGN hRgn;
+   PROSRGNDATA Region;
    DWORD nCount = 0;
    NTSTATUS Status = STATUS_SUCCESS;
 
@@ -2404,7 +2404,7 @@
 {
   PROSRGNDATA  Rgn;
   RECT SafeRect;
-  DWORD ret = 0;
+  DWORD ret;
   NTSTATUS Status = STATUS_SUCCESS;
 
   if (!(Rgn = RGNDATA_LockRgn(hRgn)))
@@ -2637,7 +2637,7 @@
 NtGdiRectInRegion(HRGN  hRgn,
                        CONST LPRECT  unsaferc)
 {
-  PROSRGNDATA Rgn = NULL;
+  PROSRGNDATA Rgn;
   RECT rc = {0};
   BOOL Ret;
   NTSTATUS Status = STATUS_SUCCESS;
@@ -2713,7 +2713,7 @@
 NtGdiUnionRectWithRgn(HRGN hDest, CONST PRECT UnsafeRect)
 {
   RECT SafeRect;
-  PROSRGNDATA Rgn = NULL;
+  PROSRGNDATA Rgn;
   NTSTATUS Status = STATUS_SUCCESS;
 
   if(!(Rgn = (PROSRGNDATA)RGNDATA_LockRgn(hDest)))
@@ -2759,7 +2759,7 @@
  */
 DWORD STDCALL NtGdiGetRegionData(HRGN hrgn, DWORD count, LPRGNDATA rgndata)
 {
-    DWORD size = 0;
+    DWORD size;
     PROSRGNDATA obj = RGNDATA_LockRgn( hrgn );
     NTSTATUS Status = STATUS_SUCCESS;
 
@@ -3399,7 +3399,7 @@
                       INT  Count,
                       INT  PolyFillMode)
 {
-   POINT *SafePoints = NULL;
+   POINT *SafePoints;
    NTSTATUS Status = STATUS_SUCCESS;
    HRGN hRgn;
 
@@ -3495,9 +3495,9 @@
                           INT  Count,
                           INT  PolyFillMode)
 {
-   POINT *Safept = NULL;
-   INT *SafePolyCounts = NULL;
-   INT nPoints = 0, nEmpty, nInvalid, i;
+   POINT *Safept;
+   INT *SafePolyCounts;
+   INT nPoints, nEmpty, nInvalid, i;
    HRGN hRgn;
    NTSTATUS Status = STATUS_SUCCESS;
 



    

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

[ros-diffs] [ion] 26248: - Revert 26244, 26245, 26246, 26247. - Stop committing on crack. - Read IRC logs and use your head. - GCC 3.4.5 is buggy, don't use. Don't break good code to hide compiler bugs.