[ros-diffs] [hbelusca] 73518: [USERENV] - Split the huge "InitializeProfiles" function into itself and a helper "CreateStandardProfile", the latter is called to set up the "Default User" and "All Users" profil...

Author: hbelusca
Date: Tue Jan 10 15:28:49 2017
New Revision: 73518

URL: http://svn.reactos.org/svn/reactos?rev=73518&view=rev
Log:
[USERENV]
- Split the huge "InitializeProfiles" function into itself and a helper
"CreateStandardProfile", the latter is called to set up the "Default
User" and "All Users" profile directories & registry settings.
- Use StringSafe functions where needed.
- Some of the shell registry values (the multimedia ones in particular) and the Fonts
folder path, are not set by userenv.dll but are set by shell32.dll when it is registered
during 2nd stage setup.

[SHELL32]: The above-mentioned shell reg vals are already there, but few have different
translations than the ones that were in userenv. Translators, please review & fix if
needed!

[SYSSETUP]: It is syssetup.dll which sets up the 'Program Files' & 'Common
Files' directories & registry values at 2nd stage setup, as done on Windows'
setup. Move the code that did this from our userenv to syssetup.

Added:
    trunk/reactos/dll/win32/syssetup/lang/da-DK.rc   (with props)
    trunk/reactos/dll/win32/syssetup/lang/fi-FI.rc   (with props)
    trunk/reactos/dll/win32/syssetup/lang/lt-LT.rc   (with props)
    trunk/reactos/dll/win32/syssetup/lang/sv-SE.rc   (with props)
    trunk/reactos/dll/win32/syssetup/lang/th-TH.rc   (with props)
Modified:
    trunk/reactos/dll/win32/shell32/lang/bg-BG.rc
    trunk/reactos/dll/win32/shell32/lang/fi-FI.rc
    trunk/reactos/dll/win32/shell32/lang/he-IL.rc
    trunk/reactos/dll/win32/shell32/lang/hu-HU.rc
    trunk/reactos/dll/win32/shell32/lang/nl-NL.rc
    trunk/reactos/dll/win32/shell32/lang/sq-AL.rc
    trunk/reactos/dll/win32/shell32/lang/uk-UA.rc
    trunk/reactos/dll/win32/syssetup/install.c
    trunk/reactos/dll/win32/syssetup/lang/bg-BG.rc
    trunk/reactos/dll/win32/syssetup/lang/cs-CZ.rc
    trunk/reactos/dll/win32/syssetup/lang/de-DE.rc
    trunk/reactos/dll/win32/syssetup/lang/el-GR.rc
    trunk/reactos/dll/win32/syssetup/lang/en-US.rc
    trunk/reactos/dll/win32/syssetup/lang/es-ES.rc
    trunk/reactos/dll/win32/syssetup/lang/et-EE.rc
    trunk/reactos/dll/win32/syssetup/lang/fr-FR.rc
    trunk/reactos/dll/win32/syssetup/lang/he-IL.rc
    trunk/reactos/dll/win32/syssetup/lang/hu-HU.rc
    trunk/reactos/dll/win32/syssetup/lang/id-ID.rc
    trunk/reactos/dll/win32/syssetup/lang/it-IT.rc
    trunk/reactos/dll/win32/syssetup/lang/ja-JP.rc
    trunk/reactos/dll/win32/syssetup/lang/nl-NL.rc
    trunk/reactos/dll/win32/syssetup/lang/no-NO.rc
    trunk/reactos/dll/win32/syssetup/lang/pl-PL.rc
    trunk/reactos/dll/win32/syssetup/lang/pt-BR.rc
    trunk/reactos/dll/win32/syssetup/lang/ro-RO.rc
    trunk/reactos/dll/win32/syssetup/lang/ru-RU.rc
    trunk/reactos/dll/win32/syssetup/lang/sk-SK.rc
    trunk/reactos/dll/win32/syssetup/lang/sq-AL.rc
    trunk/reactos/dll/win32/syssetup/lang/tr-TR.rc
    trunk/reactos/dll/win32/syssetup/lang/uk-UA.rc
    trunk/reactos/dll/win32/syssetup/lang/zh-CN.rc
    trunk/reactos/dll/win32/syssetup/lang/zh-TW.rc
    trunk/reactos/dll/win32/syssetup/resource.h
    trunk/reactos/dll/win32/syssetup/syssetup.rc
    trunk/reactos/dll/win32/userenv/lang/bg-BG.rc
    trunk/reactos/dll/win32/userenv/lang/cs-CZ.rc
    trunk/reactos/dll/win32/userenv/lang/da-DK.rc
    trunk/reactos/dll/win32/userenv/lang/de-DE.rc
    trunk/reactos/dll/win32/userenv/lang/el-GR.rc
    trunk/reactos/dll/win32/userenv/lang/en-US.rc
    trunk/reactos/dll/win32/userenv/lang/es-ES.rc
    trunk/reactos/dll/win32/userenv/lang/fi-FI.rc
    trunk/reactos/dll/win32/userenv/lang/fr-FR.rc
    trunk/reactos/dll/win32/userenv/lang/he-IL.rc
    trunk/reactos/dll/win32/userenv/lang/hu-HU.rc
    trunk/reactos/dll/win32/userenv/lang/id-ID.rc
    trunk/reactos/dll/win32/userenv/lang/it-IT.rc
    trunk/reactos/dll/win32/userenv/lang/ja-JP.rc
    trunk/reactos/dll/win32/userenv/lang/lt-LT.rc
    trunk/reactos/dll/win32/userenv/lang/nl-NL.rc
    trunk/reactos/dll/win32/userenv/lang/no-NO.rc
    trunk/reactos/dll/win32/userenv/lang/pl-PL.rc
    trunk/reactos/dll/win32/userenv/lang/pt-BR.rc
    trunk/reactos/dll/win32/userenv/lang/ro-RO.rc
    trunk/reactos/dll/win32/userenv/lang/ru-RU.rc
    trunk/reactos/dll/win32/userenv/lang/sk-SK.rc
    trunk/reactos/dll/win32/userenv/lang/sq-AL.rc
    trunk/reactos/dll/win32/userenv/lang/sv-SE.rc
    trunk/reactos/dll/win32/userenv/lang/th-TH.rc
    trunk/reactos/dll/win32/userenv/lang/tr-TR.rc
    trunk/reactos/dll/win32/userenv/lang/uk-UA.rc
    trunk/reactos/dll/win32/userenv/lang/zh-CN.rc
    trunk/reactos/dll/win32/userenv/resources.h
    trunk/reactos/dll/win32/userenv/setup.c

[This mail would be too long, it was shortened to contain the URLs only.]

Modified: trunk/reactos/dll/win32/shell32/lang/bg-BG.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/bg-…

Modified: trunk/reactos/dll/win32/shell32/lang/fi-FI.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/fi-…

Modified: trunk/reactos/dll/win32/shell32/lang/he-IL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/he-…

Modified: trunk/reactos/dll/win32/shell32/lang/hu-HU.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/hu-…

Modified: trunk/reactos/dll/win32/shell32/lang/nl-NL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/nl-…

Modified: trunk/reactos/dll/win32/shell32/lang/sq-AL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sq-…

Modified: trunk/reactos/dll/win32/shell32/lang/uk-UA.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/uk-…

Modified: trunk/reactos/dll/win32/syssetup/install.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/install…

Modified: trunk/reactos/dll/win32/syssetup/lang/bg-BG.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/bg…

Modified: trunk/reactos/dll/win32/syssetup/lang/cs-CZ.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/cs…

Added: trunk/reactos/dll/win32/syssetup/lang/da-DK.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/da…

Modified: trunk/reactos/dll/win32/syssetup/lang/de-DE.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/de…

Modified: trunk/reactos/dll/win32/syssetup/lang/el-GR.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/el…

Modified: trunk/reactos/dll/win32/syssetup/lang/en-US.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/en…

Modified: trunk/reactos/dll/win32/syssetup/lang/es-ES.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/es…

Modified: trunk/reactos/dll/win32/syssetup/lang/et-EE.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/et…

Added: trunk/reactos/dll/win32/syssetup/lang/fi-FI.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/fi…

Modified: trunk/reactos/dll/win32/syssetup/lang/fr-FR.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/fr…

Modified: trunk/reactos/dll/win32/syssetup/lang/he-IL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/he…

Modified: trunk/reactos/dll/win32/syssetup/lang/hu-HU.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/hu…

Modified: trunk/reactos/dll/win32/syssetup/lang/id-ID.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/id…

Modified: trunk/reactos/dll/win32/syssetup/lang/it-IT.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/it…

Modified: trunk/reactos/dll/win32/syssetup/lang/ja-JP.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/ja…

Added: trunk/reactos/dll/win32/syssetup/lang/lt-LT.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/lt…

Modified: trunk/reactos/dll/win32/syssetup/lang/nl-NL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/nl…

Modified: trunk/reactos/dll/win32/syssetup/lang/no-NO.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/no…

Modified: trunk/reactos/dll/win32/syssetup/lang/pl-PL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/pl…

Modified: trunk/reactos/dll/win32/syssetup/lang/pt-BR.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/pt…

Modified: trunk/reactos/dll/win32/syssetup/lang/ro-RO.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/ro…

Modified: trunk/reactos/dll/win32/syssetup/lang/ru-RU.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/ru…

Modified: trunk/reactos/dll/win32/syssetup/lang/sk-SK.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/sk…

Modified: trunk/reactos/dll/win32/syssetup/lang/sq-AL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/sq…

Added: trunk/reactos/dll/win32/syssetup/lang/sv-SE.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/sv…

Added: trunk/reactos/dll/win32/syssetup/lang/th-TH.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/th…

Modified: trunk/reactos/dll/win32/syssetup/lang/tr-TR.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/tr…

Modified: trunk/reactos/dll/win32/syssetup/lang/uk-UA.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/uk…

Modified: trunk/reactos/dll/win32/syssetup/lang/zh-CN.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/zh…

Modified: trunk/reactos/dll/win32/syssetup/lang/zh-TW.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/zh…

Modified: trunk/reactos/dll/win32/syssetup/resource.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/resourc…

Modified: trunk/reactos/dll/win32/syssetup/syssetup.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/syssetu…

Modified: trunk/reactos/dll/win32/userenv/lang/bg-BG.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/bg-…

Modified: trunk/reactos/dll/win32/userenv/lang/cs-CZ.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/cs-…

Modified: trunk/reactos/dll/win32/userenv/lang/da-DK.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/da-…

Modified: trunk/reactos/dll/win32/userenv/lang/de-DE.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/de-…

Modified: trunk/reactos/dll/win32/userenv/lang/el-GR.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/el-…

Modified: trunk/reactos/dll/win32/userenv/lang/en-US.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/en-…

Modified: trunk/reactos/dll/win32/userenv/lang/es-ES.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/es-…

Modified: trunk/reactos/dll/win32/userenv/lang/fi-FI.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/fi-…

Modified: trunk/reactos/dll/win32/userenv/lang/fr-FR.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/fr-…

Modified: trunk/reactos/dll/win32/userenv/lang/he-IL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/he-…

Modified: trunk/reactos/dll/win32/userenv/lang/hu-HU.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/hu-…

Modified: trunk/reactos/dll/win32/userenv/lang/id-ID.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/id-…

Modified: trunk/reactos/dll/win32/userenv/lang/it-IT.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/it-…

Modified: trunk/reactos/dll/win32/userenv/lang/ja-JP.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/ja-…

Modified: trunk/reactos/dll/win32/userenv/lang/lt-LT.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/lt-…

Modified: trunk/reactos/dll/win32/userenv/lang/nl-NL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/nl-…

Modified: trunk/reactos/dll/win32/userenv/lang/no-NO.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/no-…

Modified: trunk/reactos/dll/win32/userenv/lang/pl-PL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/pl-…

Modified: trunk/reactos/dll/win32/userenv/lang/pt-BR.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/pt-…

Modified: trunk/reactos/dll/win32/userenv/lang/ro-RO.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/ro-…

Modified: trunk/reactos/dll/win32/userenv/lang/ru-RU.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/ru-…

Modified: trunk/reactos/dll/win32/userenv/lang/sk-SK.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/sk-…

Modified: trunk/reactos/dll/win32/userenv/lang/sq-AL.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/sq-…

Modified: trunk/reactos/dll/win32/userenv/lang/sv-SE.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/sv-…

Modified: trunk/reactos/dll/win32/userenv/lang/th-TH.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/th-…

Modified: trunk/reactos/dll/win32/userenv/lang/tr-TR.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/tr-…

Modified: trunk/reactos/dll/win32/userenv/lang/uk-UA.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/uk-…

Modified: trunk/reactos/dll/win32/userenv/lang/zh-CN.rc
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/zh-…

Modified: trunk/reactos/dll/win32/userenv/resources.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/resource…

Modified: trunk/reactos/dll/win32/userenv/setup.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/setup.c?…