[ros-diffs] [reactos] 01/01: [ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code

[Joachim Henze]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=30dcc229f06f395e55f3f…

commit 30dcc229f06f395e55f3f94df5db310afdf56a42
Author:     Joachim Henze <Joachim.Henze(a)reactos.org>
AuthorDate: Mon Mar 30 17:18:16 2020 +0200
Commit:     Joachim Henze <Joachim.Henze(a)reactos.org>
CommitDate: Mon Mar 30 17:18:16 2020 +0200

    [ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code
    
    Just to satisfy static code analysis. No change in behavior expected.
    
    The same way as the external applications maintainers
    fixed it in their latest version
    https://sourceforge.net/projects/pice/files/pICE%20source/build_20/
    
    By killing the whole function ScrollUp() with the disabled code.
    Like the original authors I left the functions unused declaration
    existing within hardware.h
---
 .../sysutils/utils/pice/module/hardware.c          | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c
b/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c
index 65864a0373e..7d49b793eda 100644
--- a/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c
+++ b/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c
@@ -664,27 +664,6 @@ void ClrLine(ULONG line)
     ohandlers.ClrLine(line);
 }
 
-//*************************************************************************
-// ScrollUp()
-//
-// Scroll a specific window up one line
-//*************************************************************************
-void ScrollUp(USHORT Window)
-{
-    USHORT i;
-
-    return;
-
-	if(!wWindow[Window].bScrollDisabled)
-	{
-		for(i=1;i<wWindow[Window].cy;i++)
-		{
-			CopyLineTo((USHORT)(wWindow[Window].y+i-1),(USHORT)(wWindow[Window].y+i));
-		}
-		ClrLine((USHORT)(wWindow[Window].y+wWindow[Window].cy-1));
-	}
-}
-
 //*************************************************************************
 // Home()
 //
@@ -848,7 +827,6 @@ void Print(USHORT Window,LPSTR p)
 				if(wWindow[Window].usCurY>=wWindow[Window].cy)
 				{
 					wWindow[Window].usCurY=wWindow[Window].cy-1;
-					ScrollUp(Window);
 				}
                 if(wWindow[Window].bScrollDisabled==TRUE)break;
 			}