[ros-diffs] [ion] 55697: [CSRSRV]: No longer accept connections from unknown processes.

Author: ion
Date: Sun Feb 19 04:18:33 2012
New Revision: 55697

URL: http://svn.reactos.org/svn/reactos?rev=55697&view=rev
Log:
[CSRSRV]: No longer accept connections from unknown processes.

Modified:
    trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c

Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr…
==============================================================================
--- trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1] Sun Feb 19
04:18:33 2012
@@ -743,11 +743,10 @@
     NTSTATUS Status;
     HANDLE ServerPort = NULL, ServerThread = NULL;
     PCSR_PROCESS ProcessData = NULL;
-    REMOTE_PORT_VIEW LpcRead;
+    REMOTE_PORT_VIEW RemotePortView;
     CLIENT_ID ClientId;
     BOOLEAN AllowConnection = FALSE;
     PCSR_CONNECTION_INFO ConnectInfo;
-    LpcRead.Length = sizeof(LpcRead);
     ServerPort = NULL;
 
     DPRINT("CSR: %s: Handling: %p\n", __FUNCTION__, Request);
@@ -756,19 +755,17 @@
 
     /* Save the process ID */
     RtlZeroMemory(ConnectInfo, sizeof(CSR_CONNECTION_INFO));
-    ConnectInfo->ProcessId = NtCurrentTeb()->ClientId.UniqueProcess;
 
     ProcessData = CsrGetProcessData(Request->ClientId.UniqueProcess);
-    if (ProcessData == NULL)
-    {
-        ProcessData = CsrCreateProcessData(Request->ClientId.UniqueProcess);
-        if (ProcessData == NULL)
-        {
-            DPRINT1("Unable to allocate or find data for process 0x%x\n",
-                    Request->ClientId.UniqueProcess);
-        }
-    }
-
+    if (!ProcessData)
+    {
+        DPRINT1("CSRSRV: Unknown process: %lx. Will be rejecting
connection\n",
+                Request->ClientId.UniqueProcess);
+    }
+
+    /* Acquire the Process Lock */
+    CsrAcquireProcessLock();
+    
     if ((ProcessData) && (ProcessData != CsrRootProcess))
     {
         /* Attach the Shared Section */
@@ -788,28 +785,59 @@
         AllowConnection = TRUE;
     }
 
+    /* Release the lock */
+    CsrReleaseProcessLock();
+
+    /* Setup the Port View Structure */
+    RemotePortView.Length = sizeof(REMOTE_PORT_VIEW);
+    RemotePortView.ViewSize = 0;
+    RemotePortView.ViewBase = NULL;
+
+    /* Save the Process ID */
+    ConnectInfo->ProcessId = NtCurrentTeb()->ClientId.UniqueProcess;
+
     Status = NtAcceptConnectPort(&ServerPort,
-                                 NULL,
+                                 AllowConnection ?
UlongToPtr(ProcessData->SequenceNumber) : 0,
                                  Request,
                                  AllowConnection,
-                                 0,
-                                 & LpcRead);
+                                 NULL,
+                                 &RemotePortView);
     if (!NT_SUCCESS(Status))
     {
-        DPRINT1("CSR: NtAcceptConnectPort() failed\n");
-        return Status;
-    }
-
-    ProcessData->ClientViewBase = (ULONG_PTR)LpcRead.ViewBase;
-    ProcessData->ClientViewBounds = LpcRead.ViewSize;
-    ProcessData->ClientPort = ServerPort;
-
-    if (AllowConnection) Status = NtCompleteConnectPort(ServerPort);
-    if (!NT_SUCCESS(Status))
-    {
-        DPRINT1("CSR: NtCompleteConnectPort() failed\n");
-        return Status;
-    }
+         DPRINT1("CSRSS: NtAcceptConnectPort - failed.  Status == %X\n",
Status);
+    }
+    else if (AllowConnection)
+    {
+        if (CsrDebug & 2)
+        {
+            DPRINT1("CSRSS: ClientId: %lx.%lx has ClientView: Base=%p,
Size=%lx\n",
+                    Request->ClientId.UniqueProcess,
+                    Request->ClientId.UniqueThread,
+                    RemotePortView.ViewBase,
+                    RemotePortView.ViewSize);
+        }
+
+        /* Set some Port Data in the Process */
+        ProcessData->ClientPort = ServerPort;
+        ProcessData->ClientViewBase = (ULONG_PTR)RemotePortView.ViewBase;
+        ProcessData->ClientViewBounds = (ULONG_PTR)((ULONG_PTR)RemotePortView.ViewBase
+
+                                                    (ULONG_PTR)RemotePortView.ViewSize);
+
+        /* Complete the connection */
+        Status = NtCompleteConnectPort(ServerPort);
+        if (!NT_SUCCESS(Status))
+        {
+            DPRINT1("CSRSS: NtCompleteConnectPort - failed.  Status == %X\n",
Status);
+        }
+    }
+    else
+    {
+        DPRINT1("CSRSS: Rejecting Connection Request from ClientId:
%lx.%lx\n",
+                Request->ClientId.UniqueProcess,
+                Request->ClientId.UniqueThread);
+    }
+    
+    if (!NT_SUCCESS(Status)) return Status;
 
     Status = RtlCreateUserThread(NtCurrentProcess(),
                                  NULL,