[ros-diffs] [akhaldi] 61578: [INCLUDES] * Do not mix ReactOS and Wine style debugging. [SPEC2DEF] * Use DbgPrint instead of DPRINT1 for the stub functions. [ACTIVEDS] * Cleanup the stubs file. CORE-7716

Author: akhaldi
Date: Fri Jan 10 18:58:31 2014
New Revision: 61578

URL: http://svn.reactos.org/svn/reactos?rev=61578&view=rev
Log:
[INCLUDES]
* Do not mix ReactOS and Wine style debugging.
[SPEC2DEF]
* Use DbgPrint instead of DPRINT1 for the stub functions.
[ACTIVEDS]
* Cleanup the stubs file.
CORE-7716

Modified:
    trunk/reactos/dll/win32/activeds/stubs.c
    trunk/reactos/include/reactos/stubs.h
    trunk/reactos/tools/spec2def/spec2def.c

Modified: trunk/reactos/dll/win32/activeds/stubs.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/activeds/stubs.c?...
==============================================================================
--- trunk/reactos/dll/win32/activeds/stubs.c	[iso-8859-1] (original)
+++ trunk/reactos/dll/win32/activeds/stubs.c	[iso-8859-1] Fri Jan 10 18:58:31 2014
@@ -19,7 +19,7 @@
     PADSVALUE *ppAdsValues,
     PDWORD pdwNumValues)
 {
-    UNIMPLEMENTED;
+    DbgPrint("ACTIVEDS: %s is unimplemented, please try again later.\n", __FUNCTION__);
     return E_NOTIMPL;
 }

@@ -30,7 +30,7 @@
     DWORD dwNumValues,
     VARIANT * pVariant)
 {
-    UNIMPLEMENTED;
+    DbgPrint("ACTIVEDS: %s is unimplemented, please try again later.\n", __FUNCTION__);
     return E_NOTIMPL;
 }

@@ -40,7 +40,7 @@
     PADSVALUE pAdsValues,
     DWORD dwNumValues)
 {
-    UNIMPLEMENTED;
+    DbgPrint("ACTIVEDS: %s is unimplemented, please try again later.\n", __FUNCTION__);
 }

HRESULT
@@ -50,34 +50,34 @@
    PBYTE  *ppbDestData,
    ULONG  *pdwDestLen)
 {
-    UNIMPLEMENTED;
+    DbgPrint("ACTIVEDS: %s is unimplemented, please try again later.\n", __FUNCTION__);
     return E_NOTIMPL;
 }

int AdsTypeToPropVariant2()
 {
-    DPRINT1("WARNING: calling stub AdsTypeToPropVariant2()\n");
+    DbgPrint("WARNING: calling stub AdsTypeToPropVariant2()\n");
     __wine_spec_unimplemented_stub("activeds.dll", __FUNCTION__);
     return 0;
 }

int PropVariantToAdsType2()
 {
-    DPRINT1("WARNING: calling stub PropVariantToAdsType2()\n");
+    DbgPrint("WARNING: calling stub PropVariantToAdsType2()\n");
     __wine_spec_unimplemented_stub("activeds.dll", __FUNCTION__);
     return 0;
 }

int ConvertSecDescriptorToVariant()
 {
-    DPRINT1("WARNING: calling stub ConvertSecDescriptorToVariant()\n");
+    DbgPrint("WARNING: calling stub ConvertSecDescriptorToVariant()\n");
     __wine_spec_unimplemented_stub("activeds.dll", __FUNCTION__);
     return 0;
 }

int ConvertSecurityDescriptorToSecDes()
 {
-    DPRINT1("WARNING: calling stub ConvertSecurityDescriptorToSecDes()\n");
+    DbgPrint("WARNING: calling stub ConvertSecurityDescriptorToSecDes()\n");
     __wine_spec_unimplemented_stub("activeds.dll", __FUNCTION__);
     return 0;
 }

Modified: trunk/reactos/include/reactos/stubs.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/stubs.h?rev...
==============================================================================
--- trunk/reactos/include/reactos/stubs.h	[iso-8859-1] (original)
+++ trunk/reactos/include/reactos/stubs.h	[iso-8859-1] Fri Jan 10 18:58:31 2014
@@ -1,11 +1,11 @@
+#include <stdarg.h>
+#include <windef.h>
+#include <winbase.h>

-#include <stdarg.h>
-#include "windef.h"
-#include "winbase.h"
-#include "wine/config.h"
-#include "wine/exception.h"
+#include <wine/config.h>
+#include <wine/exception.h>

-#include <reactos/debug.h>
+ULONG __cdecl DbgPrint(_In_z_ _Printf_format_string_ PCSTR Format, ...);

#define __wine_spec_unimplemented_stub(module, function) \
 { \

Modified: trunk/reactos/tools/spec2def/spec2def.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/spec2def/spec2def.c?r...
==============================================================================
--- trunk/reactos/tools/spec2def/spec2def.c	[iso-8859-1] (original)
+++ trunk/reactos/tools/spec2def/spec2def.c	[iso-8859-1] Fri Jan 10 18:58:31 2014
@@ -204,7 +204,7 @@
         }
         fprintf(file, " a%d", i);
     }
-    fprintf(file, ")\n{\n\tDPRINT1("WARNING: calling stub %.*s(",
+    fprintf(file, ")\n{\n\tDbgPrint("WARNING: calling stub %.*s(",
             pexp->strName.len, pexp->strName.buf);

for (i = 0; i < pexp->nArgCount; i++)