[ros-diffs] [janderwald] 55830: [USBUHCI] - Fix initialization bugs in real hardware

Author: janderwald
Date: Thu Feb 23 03:22:57 2012
New Revision: 55830

URL: http://svn.reactos.org/svn/reactos?rev=55830&view=rev
Log:
[USBUHCI]
- Fix initialization bugs in real hardware

Modified:
    trunk/reactos/drivers/usb/usbuhci/hardware.cpp

Modified: trunk/reactos/drivers/usb/usbuhci/hardware.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbuhci/hardwa…
==============================================================================
--- trunk/reactos/drivers/usb/usbuhci/hardware.cpp [iso-8859-1] (original)
+++ trunk/reactos/drivers/usb/usbuhci/hardware.cpp [iso-8859-1] Thu Feb 23 03:22:57 2012
@@ -585,15 +585,13 @@
     //
     // perform global reset
     //
-    WRITE_PORT_USHORT((PUSHORT)((ULONG)m_Base + UHCI_USBCMD), UHCI_USBCMD_GRESET);
-
-    KeStallExecutionProcessor(100);
-
-    //
-    // clear command register
-    //
-    WRITE_PORT_USHORT((PUSHORT)((ULONG)m_Base + UHCI_USBCMD), 0);
-
+    WriteRegister16(UHCI_USBCMD, ReadRegister16(UHCI_USBCMD) | UHCI_USBCMD_GRESET);
+    KeStallExecutionProcessor(20);
+
+    //
+    // clear global reset bit
+    //
+    WriteRegister16(UHCI_USBCMD, ReadRegister16(UHCI_USBCMD) & ~UHCI_USBCMD_GRESET);
     KeStallExecutionProcessor(10);
 
 
@@ -638,11 +636,18 @@
     //
     // reclaim ownership from BIOS
     //
-    Value = PCI_LEGSUP_USBPIRQDEN | PCI_LEGSUP_CLEAR_SMI;
+    Value = 0;
+    BusInterface.GetBusData(BusInterface.Context, PCI_WHICHSPACE_CONFIG, &Value,
PCI_LEGSUP, sizeof(USHORT));
+    DPRINT1("[USBUHCI] LEGSUP %x\n", Value);
+
+    Value = PCI_LEGSUP_USBPIRQDEN;
     BusInterface.SetBusData(BusInterface.Context, PCI_WHICHSPACE_CONFIG, &Value,
PCI_LEGSUP, sizeof(USHORT));
 
     DPRINT1("[USBUHCI] Acquired ownership\n");
-
+    Value = 0;
+    BusInterface.GetBusData(BusInterface.Context, PCI_WHICHSPACE_CONFIG, &Value,
0x60, sizeof(UCHAR));
+    DPRINT1("[USBUHCI] SBRN %x\n", Value);
+    ASSERT(FALSE);
 
     //
     // perform global reset
@@ -714,6 +719,7 @@
         //
         m_QueueHead[Index]->PhysicalAddress = Address.LowPart;
         m_QueueHead[Index]->ElementPhysical = QH_TERMINATE;
+        m_QueueHead[Index]->LinkPhysical = QH_TERMINATE;
 
         if (Index > 0)
         {
@@ -852,6 +858,19 @@
     ULONG Count = 0;
     USHORT Status;
 
+    // clear run bit
+    WriteRegister16(UHCI_USBCMD, ReadRegister16(UHCI_USBCMD) & ~UHCI_USBCMD_RS);
+
+    // wait for the controller to stop
+    while((ReadRegister16(UHCI_USBSTS) & UHCI_USBSTS_HCHALT) == 0)
+    {
+        DPRINT1("[UHCI] Waiting for the controller to halt\n");
+        KeStallExecutionProcessor(10);
+    }
+
+    // clear configure bit
+    WriteRegister16(UHCI_USBCMD, ReadRegister16(UHCI_USBCMD) & ~UHCI_USBCMD_CF);
+
     //
     // reset controller
     //