[ros-diffs] [ion] 19459: - I wish svn delete would..delete the file -before- committing to that testing before a commit would actually be useful. Fix wdmguid.c build

- I wish svn delete would..delete the file -before- committing to that
testing before a commit would actually be useful. Fix wdmguid.c build
- Update NDK text files.
Modified: trunk/reactos/include/ndk/fixmes.txt
Modified: trunk/reactos/include/ndk/readme.txt
Modified: trunk/reactos/lib/wdmguid/wdmguid.c
  _____  

Modified: trunk/reactos/include/ndk/fixmes.txt
--- trunk/reactos/include/ndk/fixmes.txt	2005-11-22 08:20:55 UTC
(rev 19458)
+++ trunk/reactos/include/ndk/fixmes.txt	2005-11-22 08:21:42 UTC
(rev 19459)
@@ -1,8 +1,135 @@

 Complete list of NDK Fixmes before 1.0 Release (Nov 25th 2005)
 --------------------------------------------------------------
+_______________________________________________________________________
_______________
+[CRITICAL]	- Breaking compatibility with official structures.
+|pstypes.h	- EPROCESS has ReactOS only fields. Includes ReactOS
Internal header.
+|pstypes.h	- W32_CALLOUT_DATA has ReactOS only fields.
+|obtypes.h	- Object callbacks are ReactOS only definitions.
+|obtypes.h	- Object Header includes ReactOS only type.
+|mmtypes.h	- _MADDRESS_SPACE is ReactOS only field.
+|ketypes.h	- _KPROFILE needs to be updated with new definitions.
+|ketypes.h	- _KINTERRUPT needs to be verified with new definitions.
+|haltypes.h	- Loader Parameter Block is ReactOS Version, not NT.
+|
+[MAJOR]		- Using incorrect, missing, or invalid names or
definitions.
+|i386/ketypes.h	- _KTRAP_FRAME definition is broken.
+|i386/ketypes.h	- _KTSSNOIOPM is not an official type.
+|rtltypes.h	- PPF_ Defines don't seem to be the real names (try to
find them).
+|rtltypes.h	- _RTL_PROCESS_BACKTRACE_INFORMATION isn't done.
+|haltypes.h	- Multi-Boot flags are ReactOS Only.
+|extypes.h	- SystemPowerInformation in SYSTEM_INFORMATION_CLASS
causes conflict.
+|extypes.h	- _RUNDOWN_DESCRIPTOR is possibly incorrect/unofficial.
+|asm.h		- Selector names are not official.
+|extypes.h	- Class 42 (SYSTEM_POWER_INFORMATION causes conflict).
+|extypes.h	- Classes 13, 20, 30, 31, 49, 51, 52, 54+ are undefined.
+|
+[MINOR]		- Related to location of functions, comments,
etc.
+|arch/ketypes.h	- _KDPC_DATA, PP_LOOKASIDE_LIST shouldn't be
there.
+|zwfuncs.h	- APIs are not organized.
+|pstypes.h	- Check if _PAGEFAULT_HISTORY shouldn't go in mmtypes.h
instead.
+|lpctypes.h	- Consider moving _HARDERROR_MSG to extypes.h?
+|lpctypes.h	- Consider moving _CLIENT_DIED_MSG to pstypes.h?
+|ketypes.h	- Consider moving KNODE to mmtypes.h?
+|ketypes.h	- Consider moving NtBuildNumber to extypes.h?
+|extypes.h	- consider moving PORT_ALL_ACCESS to lpctypes.h
+|GENERIC	- Make sure that all files can be included in
standalone!
+|______________________________________________________________________
_______________
 
 
 List of ReactOS Applications compiling with the NDK
+(verify, fix, and optimize their usage)
 --------------------------------------------------------------
 
-
+apps\utils\ps\ps.c: #include <ndk/ntndk.h>
+drivers\dd\blue\blue.c: #include <ndk/halfuncs.h>
+drivers\dd\bootvid\bootvid.c: #include <ndk/ldrfuncs.h>
+drivers\storage\diskdump\diskdump.c: #include <ndk/extypes.h>
+drivers\storage\diskdump\diskdump.c: #include <ndk/rtlfuncs.h>
+hal\hal\hal.c: #include <ndk/halfuncs.h>
+hal\hal\hal.c: #include <ndk/kdfuncs.h>
+lib\crt\except\unwind.c: #include <ndk/umtypes.h>
+lib\crt\except\unwind.c: #include <ndk/extypes.h>
+lib\crt\except\unwind.c: #include <ndk/rtlfuncs.h>
+lib\dnsapi\dnsapi\stubs.c: #include <ndk/ntndk.h>
+lib\epsapi\enum\drivers.c: #include <ndk/ntndk.h>
+lib\epsapi\enum\modules.c: #include <ndk/ntndk.h>
+lib\epsapi\enum\processes.c: #include <ndk/ntndk.h>
+lib\lsasrv\lsaport.c: #include <ndk/ntndk.h>
+lib\lsasrv\lsasrv.c: #include <ndk/ntndk.h>
+lib\nt\entry_point.c: #include <ndk/ntndk.h>
+lib\samlib\samlib.c: #include <ndk/ntndk.h>
+lib\samsrv\samsrv.c: #include <ndk/ntndk.h>
+lib\smdll\query.c: #include <ndk/ntndk.h>
+lib\string\mbstowcs.c: #include <ndk/umtypes.h>
+lib\string\mbstowcs.c: #include <ndk/rtlfuncs.h>
+lib\string\sscanf.c: #include <ndk/umtypes.h>
+lib\string\sscanf.c: #include <ndk/rtlfuncs.h>
+lib\string\wcstombs.c: #include <ndk/umtypes.h>
+lib\string\wcstombs.c: #include <ndk/rtlfuncs.h>
+lib\syssetup\install.c: #include <ndk/ntndk.h>
+lib\syssetup\logfile.c: #include <ndk/ntndk.h>
+lib\wdmguid\wdmguid.c: #include <ndk/sysguid.h>
+regtests\shared\regtests.c: #include <ndk/ntndk.h>
+services\umpnpmgr\umpnpmgr.c: #include <ndk/ntndk.h>
+subsys\csr\main.c: #include <ndk/ntndk.h>
+subsys\ntvdm\ntvdm.c: #include <ndk/ntndk.h>
+subsys\system\autochk\autochk.c: #include <ndk/ntndk.h>
+subsys\system\lsass\lsass.c: #include <ndk/ntndk.h>
+subsys\system\setup\setup.c: #include <ndk/ntndk.h>
+subsys\system\sm\sm.c: #include <ndk/ntndk.h>
+boot\freeldr\freeldr\include\freeldr.h: #include <ndk/ntndk.h>
+drivers\fs\ms\msfs.h: #include <ndk/ntndk.h>
+drivers\fs\np\npfs.h: #include <ndk/iotypes.h>
+drivers\fs\vfat\vfat.h: #include <ndk/ntndk.h>
+drivers\net\ndis\include\ndissys.h: #include <ndk/ntndk.h>
+drivers\net\tcpip\include\precomp.h: #include <ndk/ntndk.h>
+drivers\video\miniport\xboxvmp\xboxvmp.h: #include <ndk/ntndk.h>
+drivers\video\videoprt\videoprt.h: #include <ndk/ntndk.h>
+hal\halx86\include\hal.h: #include <ndk/ntndk.h>
+include\drivers\diskdump\diskdump.h: #include <ndk/ntndk.h>
+lib\advapi32\advapi32.h: #include <ndk/ntndk.h>
+lib\crt\precomp.h: #include <ndk/ntndk.h>
+lib\dbghelp\stackframe.h: #include <ndk/umtypes.h>
+lib\dbghelp\stackframe.h: #include <ndk/extypes.h>
+lib\dbghelp\stackframe.h: #include <ndk/rtlfuncs.h>
+lib\dnsapi\dnsapi\precomp.h: #include <ndk/ntndk.h>
+lib\fmifs\precomp.h: #include <ndk/ntndk.h>
+lib\fslib\vfatlib\vfatlib.h: #include <ndk/ntndk.h>
+lib\fslib\vfatxlib\vfatxlib.h: #include <ndk/ntndk.h>
+lib\gdi32\include\precomp.h: #include <ndk/ntndk.h>
+lib\imagehlp\precomp.h: #include <ndk/umtypes.h>
+lib\imagehlp\precomp.h: #include <ndk/rtlfuncs.h>
+lib\iphlpapi\iphlpapi_private.h: #include <ndk/ntndk.h>
+lib\kernel32\k32.h: #include <ndk/ntndk.h>
+lib\msafd\msafd.h: #include <ndk/ntndk.h>
+lib\ntdll\inc\ntdll.h: #include <ndk/ntndk.h>
+lib\opengl32\teb.h: #include <ndk/ntndk.h>
+lib\psapi\precomp.h: #include <ndk/ntndk.h>
+lib\rtl\rtl.h: #include <ndk/ntndk.h>
+lib\secur32\precomp.h: #include <ndk/ntndk.h>
+lib\setupapi\setupapi_private.h: #include <ndk/ntndk.h>
+lib\smlib\precomp.h: #include <ndk/ntndk.h>
+lib\user32\include\user32.h: #include <ndk/ntndk.h>
+lib\userenv\precomp.h: #include <ndk/ntndk.h>
+lib\ws2help\ws2help.h: #include <ndk/ntndk.h>
+lib\ws2_32\include\ws2_32.h: #include <ndk/ntndk.h>
+lib\wshirda\wshirda.h: #include <ndk/ntndk.h>
+ntoskrnl\include\ntoskrnl.h: #include <ndk/ntndk.h>
+ntoskrnl\include\internal\napi.h: #include <ndk/asm.h>
+services\dhcp\include\rosdhcp.h: #include <ndk/ntndk.h>
+services\eventlog\eventlog.h: #include <ndk/ntndk.h>
+services\rpcss\rpcss.h: #include <ndk/ntndk.h>
+subsys\csr\csrsrv\srv.h: #include <ndk/ntndk.h>
+subsys\csrss\csrss.h: #include <ndk/ntndk.h>
+subsys\csrss\include\api.h: #include <ndk/ntndk.h>
+subsys\csrss\win32csr\w32csr.h: #include <ndk/ntndk.h>
+subsys\smss\smss.h: #include <ndk/ntndk.h>
+subsys\system\cmd\precomp.h: #include <ndk/ntndk.h>
+subsys\system\services\services.h: #include <ndk/ntndk.h>
+subsys\system\taskmgr\precomp.h: #include <ndk/ntndk.h>
+subsys\system\usetup\usetup.h: #include <ndk/ntndk.h>
+subsys\system\winlogon\winlogon.h: #include <ndk/ntndk.h>
+subsys\win\basesrv\basesrv.h: #include <ndk/ntndk.h>
+subsys\win\winsrv\winsrv.h: #include <ndk/ntndk.h>
+subsys\win32k\w32k.h: #include <ndk/ntndk.h>
+subsys\win32k\include\napi.h: #include <ndk/asm.h>
\ No newline at end of file
  _____  

Modified: trunk/reactos/include/ndk/readme.txt
--- trunk/reactos/include/ndk/readme.txt	2005-11-22 08:20:55 UTC
(rev 19458)
+++ trunk/reactos/include/ndk/readme.txt	2005-11-22 08:21:42 UTC
(rev 19459)
@@ -2,6 +2,20 @@

         NDK 1.00
 -----------------------------
 
+0. PREABMLE
+
+0.1 COPYRIGHT
+
+The NDK is Copyright ® 2005 Alex Ionescu.
+
+0.2 CONTACT INFORMATION
+
+The author, Alex Ionescu, may be reached through the following means:
+
+Email: 	alex.ionescu(a)reactos.com
+Mail:	2246, Duvernay. H3J 2Y3. Montreal, QC. CANADA.	
+Phone: 	[phone]
+
 1. LICENSE
 
 1.1 OPEN SOURCE USAGE
@@ -45,8 +59,63 @@
 If you are unsure of have any questions about the NDK License, please
contact the
 author for further clarification.
 
-2. USAGE
+2. ORIGINS OF NDK MATERIAL, AND ADDING YOUR OWN
 
-2.1 TODO (COPY FROM WIKI)
+2.1 CONTRIBUTIONS AND SOURCES
 
+The NDK could not exist without the various contributions made by a
variety of people
+and sources. The following public sources of information were lawfully
used:
+
+- GNU NTIFS.H, Revision 43
+- W32API, Version 2.5
+- Microsoft Driver Development Kit 2003 SP1
+- Microsoft Driver Development Kit 2000
+- Microsoft Driver Development Kit NT 4
+- Microsoft Driver Development Kit WinME
+- Microsoft Installable File Systems Kit 2003 SP1
+- Microsoft Windows Debugger (WinDBG) 6.5.0003.7
+- Microsoft Public Symbolic Data
+- Microsoft Public Windows Binaries (strings)
+- OSR Technical Articles
+- Undocumented windows 2000 Secrets, a Programmer's Cookbook
+- Windows NT/2000 Native API Reference
+- Windows NT File System Internals
+- Windows Internals I - II
+- Windows Internals 4th Edition
+
+If the information contained in these sources was copyrighted, the
information was not
+copied, but simply used as a basis for developing a compatible and
identical definition.
+No information protected by a patent or NDA was used. All information
was publically
+located through the Internet or purchased or licensed for lawful use.
+
+Additionally, the following people contributed to the NDK:
+
+- Eric Kohl
+- Filip Navara
+- Steven Edwards
+
+2.2 BECOMING A CONTRIBUTOR
+
+To contribute information to the NDK, simply contact the author with
your new structure,
+definition, enumeration, or prototype. Please make sure that your
addition is:
+
+1) Actually correct!
+2) Present in Windows NT 5, 5.1, 5.2 and/or 6.0
+3) Not already accessible through another public header in the DDK,
IFS, WDK and/or PSDK.
+4) From a publically verifiable source. The author needs to be able to
search for your
+   addition in a public information location (book, Internet, etc) and
locate this definition.
+5) Not Reversed. Reversing a type is STRONGLY discouraged and a
reversed type will more then likely
+   not be accepted, due to the fact that functionality and naming will
be entirely guessed, and things
+   like unions are almost impossible to determine. It can also bring up
possible legal ramifications
+   depending on your location. However, using a tool to dump the
strings inside an executable
+   for the purpose of locating the actual name or definition of a
structure (sometimes possible due
+   to ASSERTs or debugging strings) is considered 'fair use' and will
be a likely candidate.
+
+If your addition satsfies these points, then please submit it, and also
include whether or not
+you would like to be credited for it.
+
+3. USAGE
+
+3.1 TODO (COPY FROM WIKI)
+
 ... TODO ... (COPY FROM WIKI)
  _____  

Modified: trunk/reactos/lib/wdmguid/wdmguid.c
--- trunk/reactos/lib/wdmguid/wdmguid.c	2005-11-22 08:20:55 UTC (rev
19458)
+++ trunk/reactos/lib/wdmguid/wdmguid.c	2005-11-22 08:21:42 UTC (rev
19459)
@@ -5,6 +5,6 @@

 #include "initguid.h"
 
 #include <ddk/wdmguid.h>
-#include <ndk/sysguid.h>
+#include <umpnpmgr/sysguid.h>
 
 /* EOF */