[ros-diffs] [janderwald] 40705: - Pass KSPROPERTY_SET to subdevice constructor - Add debug traces on error case

Author: janderwald
Date: Sun Apr 26 04:07:33 2009
New Revision: 40705

URL: http://svn.reactos.org/svn/reactos?rev=40705&view=rev
Log:
- Pass KSPROPERTY_SET to subdevice constructor
- Add debug traces on error case

Modified:
    trunk/reactos/drivers/wdm/audio/backpln/portcls/port_wavepci.c
    trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.c

Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/port_wavepci.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/p...
==============================================================================
--- trunk/reactos/drivers/wdm/audio/backpln/portcls/port_wavepci.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/wdm/audio/backpln/portcls/port_wavepci.c [iso-8859-1] Sun Apr 26 04:07:33 2009
@@ -49,6 +49,27 @@
     }
 };

+DEFINE_KSPROPERTY_TOPOLOGYSET(PortFilterWavePciTopologySet, TopologyPropertyHandler);
+DEFINE_KSPROPERTY_PINPROPOSEDATAFORMAT(PortFilterWavePciPinSet, PinPropertyHandler, PinPropertyHandler, PinPropertyHandler);
+
+KSPROPERTY_SET WavePciPropertySet[] =
+{
+    {
+        &KSPROPSETID_Topology,
+        sizeof(PortFilterWavePciTopologySet) / sizeof(KSPROPERTY_ITEM),
+        (const KSPROPERTY_ITEM*)&PortFilterWavePciTopologySet,
+        0,
+        NULL
+    },
+    {
+        &KSPROPSETID_Pin,
+        sizeof(PortFilterWavePciPinSet) / sizeof(KSPROPERTY_ITEM),
+        (const KSPROPERTY_ITEM*)&PortFilterWavePciPinSet,
+        0,
+        NULL
+    }
+};
+

//---------------------------------------------------------------
 // IPortEvents
@@ -401,14 +422,14 @@
         return Status;
     }

-    /* create the subdevice descriptor */
+   /* create the subdevice descriptor */
     Status = PcCreateSubdeviceDescriptor(&This->SubDeviceDescriptor, 
                                          3,
-                                         InterfaceGuids, 
+                                         InterfaceGuids,
                                          0, 
                                          NULL,
-                                         0, 
-                                         NULL,
+                                         2, 
+                                         WavePciPropertySet,
                                          0,
                                          0,
                                          0,
@@ -416,6 +437,7 @@
                                          0,
                                          NULL,
                                          This->pDescriptor);
+

if (!NT_SUCCESS(Status))
     {

Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/p...
==============================================================================
--- trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.c [iso-8859-1] Sun Apr 26 04:07:33 2009
@@ -224,6 +224,7 @@
     if (!IsEqualGUIDAligned(&Property->Set, &KSPROPSETID_Pin))
     {
         /* the fast handler only supports pin properties */
+        DPRINT("Only KSPROPSETID_Pin is supported\n");
         return Status;
     }

@@ -231,6 +232,7 @@
     Status = FindPropertyHandler(IoStatus, Descriptor, Property, PropertyLength, DataLength, &PropertyHandler);
     if (!NT_SUCCESS(Status))
     {
+        DPRINT("FindPropertyHandler failed with %x\n", Status);
         return Status;
     }