[ros-diffs] [akhaldi] 58855: [SHELL32] * Sync SH{Register, Revoke}DragDrop with Wine 1.5.26.

Author: akhaldi
Date: Thu Apr 25 23:04:00 2013
New Revision: 58855

URL: http://svn.reactos.org/svn/reactos?rev=58855&view=rev
Log:
[SHELL32]
* Sync SH{Register,Revoke}DragDrop with Wine 1.5.26.

Modified:
    trunk/reactos/dll/win32/shell32/shellord.cpp

Modified: trunk/reactos/dll/win32/shell32/shellord.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shellord....
==============================================================================
--- trunk/reactos/dll/win32/shell32/shellord.cpp [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/shellord.cpp [iso-8859-1] Thu Apr 25 23:04:00 2013
@@ -405,13 +405,14 @@
 }

/*************************************************************************
- * SHRegisterDragDrop                [SHELL32.86]
+ * SHRegisterDragDrop				[SHELL32.86]
  *
  * Probably equivalent to RegisterDragDrop but under Windows 95 it could use the
  * shell32 built-in "mini-COM" without the need to load ole32.dll - see SHLoadOLE
  * for details. Under Windows 98 this function initializes the true OLE when called
  * the first time, on XP always returns E_OUTOFMEMORY and it got removed from Vista.
  *
+ * We follow Windows 98 behaviour.
  *
  * NOTES
  *     exported by ordinal
@@ -420,20 +421,34 @@
  *     RegisterDragDrop, SHLoadOLE
  */
 HRESULT WINAPI SHRegisterDragDrop(
-    HWND hWnd,
-    LPDROPTARGET pDropTarget)
-{
-    FIXME("(%p,%p):stub.\n", hWnd, pDropTarget);
-    return RegisterDragDrop(hWnd, pDropTarget);
-}
-
-/*************************************************************************
- * SHRevokeDragDrop                [SHELL32.87]
- *
- * Probably equivalent to RevokeDragDrop but under Windows 9x it could use the
+	HWND hWnd,
+	LPDROPTARGET pDropTarget)
+{
+        static BOOL ole_initialized = FALSE;
+        HRESULT hr;
+
+        TRACE("(%p,%p)\n", hWnd, pDropTarget);
+
+        if (!ole_initialized)
+        {
+            hr = OleInitialize(NULL);
+            if (FAILED(hr))
+                return hr;
+            ole_initialized = TRUE;
+        }
+	return RegisterDragDrop(hWnd, pDropTarget);
+}
+
+/*************************************************************************
+ * SHRevokeDragDrop				[SHELL32.87]
+ *
+ * Probably equivalent to RevokeDragDrop but under Windows 95 it could use the
  * shell32 built-in "mini-COM" without the need to load ole32.dll - see SHLoadOLE
  * for details. Function removed from Windows Vista.
  *
+ * We call ole32 RevokeDragDrop which seems to work even if OleInitialize was
+ * not called.
+ *
  * NOTES
  *     exported by ordinal
  *
@@ -442,7 +457,7 @@
  */
 HRESULT WINAPI SHRevokeDragDrop(HWND hWnd)
 {
-    FIXME("(%p):stub.\n",hWnd);
+    TRACE("(%p)\n", hWnd);
     return RevokeDragDrop(hWnd);
 }