Author: tfaber Date: Sun Apr 19 08:39:58 2015 New Revision: 67291
URL: http://svn.reactos.org/svn/reactos?rev=67291&view=rev Log: [CMAKE] We have a zero-warnings policy in trunk, accordingly: - Disable overflow warnings in mciwave - Remove all -Wno-error directives - Remove all allow_warnings invocations - Make allow_warnings defunct, it needs to be reworked, e.g. according to CORE-6959.
Modified: trunk/reactos/cmake/gcc.cmake trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt trunk/reactos/dll/opengl/mesa/main/CMakeLists.txt trunk/reactos/dll/opengl/mesa/swrast/CMakeLists.txt trunk/reactos/dll/win32/mciwave/CMakeLists.txt trunk/reactos/drivers/storage/class/disk_new/CMakeLists.txt trunk/reactos/drivers/storage/classpnp/CMakeLists.txt trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CMakeLists.txt trunk/rostests/winetests/ntdll/CMakeLists.txt
Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=67291&a... ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Sun Apr 19 08:39:58 2015 @@ -116,10 +116,7 @@
if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang") add_compile_flags("-Wno-maybe-uninitialized") - add_compile_flags("-Wno-error=unused-but-set-variable") -endif() - -add_compile_flags("-Wno-error=type-limits") +endif()
if(ARCH STREQUAL "amd64") add_compile_flags("-Wno-format") @@ -427,7 +424,8 @@ endfunction()
function(allow_warnings __module) - add_target_compile_flags(${__module} "-Wno-error") + # We don't allow warnings in trunk, this needs to be reworked. See CORE-6959. + #add_target_compile_flags(${__module} "-Wno-error") endfunction()
macro(add_asm_files _target)
Modified: trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libtiff/CMakeL... ============================================================================== --- trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt [iso-8859-1] Sun Apr 19 08:39:58 2015 @@ -59,7 +59,6 @@ add_cd_file(TARGET libtiff DESTINATION reactos/system32 FOR all)
if(NOT MSVC) - allow_warnings(libtiff) if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang") add_target_compile_flags(libtiff "-Wno-unused-but-set-variable") endif()
Modified: trunk/reactos/dll/opengl/mesa/main/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/mesa/main/CMakeL... ============================================================================== --- trunk/reactos/dll/opengl/mesa/main/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/opengl/mesa/main/CMakeLists.txt [iso-8859-1] Sun Apr 19 08:39:58 2015 @@ -73,6 +73,5 @@ add_pch(mesa_main precomp.h SOURCE)
if(NOT MSVC) - allow_warnings(mesa_main) add_target_compile_flags(mesa_main "-Wno-type-limits") endif()
Modified: trunk/reactos/dll/opengl/mesa/swrast/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/mesa/swrast/CMak... ============================================================================== --- trunk/reactos/dll/opengl/mesa/swrast/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/opengl/mesa/swrast/CMakeLists.txt [iso-8859-1] Sun Apr 19 08:39:58 2015 @@ -32,5 +32,4 @@
if(NOT MSVC) add_target_compile_flags(mesa_swrast "-Wno-unused-variable") - allow_warnings(mesa_swrast) endif()
Modified: trunk/reactos/dll/win32/mciwave/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mciwave/CMakeList... ============================================================================== --- trunk/reactos/dll/win32/mciwave/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mciwave/CMakeLists.txt [iso-8859-1] Sun Apr 19 08:39:58 2015 @@ -17,5 +17,5 @@ add_cd_file(TARGET mciwave DESTINATION reactos/system32 FOR all)
if(NOT MSVC) - add_target_compile_flags(mciwave "-Wno-error=overflow") + add_target_compile_flags(mciwave "-Wno-overflow") endif()
Modified: trunk/reactos/drivers/storage/class/disk_new/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/disk_... ============================================================================== --- trunk/reactos/drivers/storage/class/disk_new/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/class/disk_new/CMakeLists.txt [iso-8859-1] Sun Apr 19 08:39:58 2015 @@ -16,8 +16,8 @@
if((ARCH STREQUAL "i386") AND (NOT MSVC)) # FIXME: http://www.cmake.org/Bug/view.php?id=12998 - #add_target_compile_flags(disk_new "-Wno-error -Wno-format -Wno-pointer-sign") - set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error -Wno-format -Wno-pointer-sign") + #add_target_compile_flags(disk_new "-Wno-format -Wno-pointer-sign") + set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-format -Wno-pointer-sign") endif()
set_module_type(disk_new kernelmodedriver)
Modified: trunk/reactos/drivers/storage/classpnp/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/classpnp/CM... ============================================================================== --- trunk/reactos/drivers/storage/classpnp/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/classpnp/CMakeLists.txt [iso-8859-1] Sun Apr 19 08:39:58 2015 @@ -33,11 +33,6 @@ class.rc ${CMAKE_CURRENT_BINARY_DIR}/classpnp.def)
-if((ARCH STREQUAL "i386") AND (NOT MSVC)) - # FIXME: http://www.cmake.org/Bug/view.php?id=12998 - set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error=unused-but-set-variable -Wno-error=unused-variable -Wno-error=switch") -endif() - add_pch(classpnp classp.h SOURCE) target_link_libraries(classpnp ${PSEH_LIB} libcntpr) set_module_type(classpnp kernelmodedriver)
Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drivers/C... ============================================================================== --- trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CMakeLists.txt [iso-8859-1] Sun Apr 19 08:39:58 2015 @@ -26,9 +26,8 @@
if(NOT MSVC) # FIXME: http://www.cmake.org/Bug/view.php?id=12998 - #add_target_compile_flags(portcls "-Wno-write-strings -Wno-switch") - #allow_warnings(portcls) - set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-write-strings -Wno-switch -Wno-error") + #add_target_compile_flags(cmipci "-Wno-write-strings -Wno-switch") + set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-write-strings -Wno-switch") endif()
add_pch(cmipci precomp.h SOURCE)
Modified: trunk/rostests/winetests/ntdll/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/ntdll/CMakeLists... ============================================================================== --- trunk/rostests/winetests/ntdll/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/ntdll/CMakeLists.txt [iso-8859-1] Sun Apr 19 08:39:58 2015 @@ -34,6 +34,5 @@ add_cd_file(TARGET ntdll_winetest DESTINATION reactos/bin FOR all)
if(NOT MSVC) - allow_warnings(ntdll_winetest) add_target_compile_flags(ntdll_winetest "-Wno-format") endif()