[ros-diffs] [fireball] 27345: - Clean up the mess Magnus introduced (remove allowwarnings="true"). - RpcTryFinall set of macros was mapped to PSEH incorrectly, which lead to a "finally" block being treated as an "except" block (thus ending up in a memory leak). Reverting this part for now until a better solution is found.

Author: fireball
Date: Sat Jun 30 20:01:03 2007
New Revision: 27345

URL: http://svn.reactos.org/svn/reactos?rev=27345&view=rev
Log:
- Clean up the mess Magnus introduced (remove allowwarnings="true").
- RpcTryFinall set of macros was mapped to PSEH incorrectly, which lead to a
"finally" block being treated as an "except" block (thus ending up in
a memory leak). Reverting this part for now until a better solution is found.

Modified:
    trunk/reactos/dll/win32/aclui/aclui.rbuild
    trunk/reactos/dll/win32/advapi32/advapi32.rbuild
    trunk/reactos/include/psdk/rpc.h
    trunk/reactos/include/reactos/idl/idl.rbuild

Modified: trunk/reactos/dll/win32/aclui/aclui.rbuild
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/aclui/aclui.rbui…
==============================================================================
--- trunk/reactos/dll/win32/aclui/aclui.rbuild (original)
+++ trunk/reactos/dll/win32/aclui/aclui.rbuild Sat Jun 30 20:01:03 2007
@@ -1,4 +1,4 @@
-<module name="aclui" type="win32dll"
baseaddress="${BASEADDRESS_ACLUI}" installbase="system32"
installname="aclui.dll" allowwarnings ="true">
+<module name="aclui" type="win32dll"
baseaddress="${BASEADDRESS_ACLUI}" installbase="system32"
installname="aclui.dll">
 	<importlibrary definition="aclui.spec.def" />
 	<include base="aclui">.</include>
 	<define name="UNICODE" />

Modified: trunk/reactos/dll/win32/advapi32/advapi32.rbuild
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/advapi3…
==============================================================================
--- trunk/reactos/dll/win32/advapi32/advapi32.rbuild (original)
+++ trunk/reactos/dll/win32/advapi32/advapi32.rbuild Sat Jun 30 20:01:03 2007
@@ -1,4 +1,4 @@
-<module name="advapi32" type="win32dll"
baseaddress="${BASEADDRESS_ADVAPI32}"  installbase="system32"
installname="advapi32.dll"  allowwarnings ="true">
+<module name="advapi32" type="win32dll"
baseaddress="${BASEADDRESS_ADVAPI32}"  installbase="system32"
installname="advapi32.dll">
 
 	<importlibrary definition="advapi32.def" />
 	<include base="advapi32">.</include>

Modified: trunk/reactos/include/psdk/rpc.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/rpc.h?rev=273…
==============================================================================
--- trunk/reactos/include/psdk/rpc.h (original)
+++ trunk/reactos/include/psdk/rpc.h Sat Jun 30 20:01:03 2007
@@ -150,9 +150,9 @@
                                  } \
                                  _SEH_END;
 
-            #define RpcTryFinally  _SEH_TRY {
-            #define RpcFinally  } _SEH_HANDLE {
-            #define RpcEndFinally } _SEH_END;
+            #define RpcTryFinally
+            #define RpcFinally
+            #define RpcEndFinally
             #define RpcExceptionCode() _SEH_GetExceptionCode()
 
             /* #define RpcAbnormalTermination() abort() */

Modified: trunk/reactos/include/reactos/idl/idl.rbuild
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/idl/idl.rb…
==============================================================================
--- trunk/reactos/include/reactos/idl/idl.rbuild (original)
+++ trunk/reactos/include/reactos/idl/idl.rbuild Sat Jun 30 20:01:03 2007
@@ -1,23 +1,23 @@
 <group>
-<module name="pnp_server" type="rpcserver" allowwarnings
="true">
+<module name="pnp_server" type="rpcserver">
 	<include base="ReactOS">.</include>
 	<include base="ReactOS">w32api/include</include>
 	<define name="_X86_" />
 	<file>pnp.idl</file>
 </module>
-<module name="pnp_client" type="rpcclient" allowwarnings
="true">
+<module name="pnp_client" type="rpcclient">
 	<include base="ReactOS">.</include>
 	<include base="ReactOS">w32api/include</include>
 	<define name="_X86_" />
 	<file>pnp.idl</file>
 </module>
-<module name="scm_server" type="rpcserver" allowwarnings
="true">
+<module name="scm_server" type="rpcserver">
 	<include base="ReactOS">.</include>
 	<include base="ReactOS">w32api/include</include>
 	<define name="_X86_" />
 	<file switches="--oldnames">svcctl.idl</file>
 </module>
-<module name="scm_client" type="rpcclient" allowwarnings
="true">
+<module name="scm_client" type="rpcclient">
 	<include base="ReactOS">.</include>
 	<include base="ReactOS">w32api/include</include>
 	<define name="_X86_" />
@@ -35,13 +35,13 @@
 	<define name="_X86_" />
 	<file switches="--oldnames">eventlogrpc.idl</file>
 </module>
-<module name="lsa_server" type="rpcserver" allowwarnings
="true">
+<module name="lsa_server" type="rpcserver">
 	<include base="ReactOS">.</include>
 	<include base="ReactOS">w32api/include</include>
 	<define name="_X86_" />
 	<file switches="--oldnames">lsa.idl</file>
 </module>
-<module name="lsa_client" type="rpcclient" allowwarnings
="true">
+<module name="lsa_client" type="rpcclient">
 	<include base="ReactOS">.</include>
 	<include base="ReactOS">w32api/include</include>
 	<define name="_X86_" />