[ros-diffs] [reactos] 01/01: [UDFS] Correctly check SeSinglePrivilegeCheck() return value

[Serge Gautherie]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=17af7f0c2741f2a8173a0…

commit 17af7f0c2741f2a8173a0bd091e97b9bd14d5777
Author:     Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr>
AuthorDate: Wed Jan 30 01:54:42 2019 +0100
Commit:     Pierre Schweitzer <pierre(a)reactos.org>
CommitDate: Sun Feb 10 10:16:55 2019 +0100

    [UDFS] Correctly check SeSinglePrivilegeCheck() return value
    
    SeSinglePrivilegeCheck() returns a BOOLEAN, not a NTSTATUS.
    
    CORE-14271
---
 drivers/filesystems/udfs/create.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/filesystems/udfs/create.cpp b/drivers/filesystems/udfs/create.cpp
index e841a04d03..75f209f4b5 100644
--- a/drivers/filesystems/udfs/create.cpp
+++ b/drivers/filesystems/udfs/create.cpp
@@ -742,9 +742,9 @@ op_vol_accs_dnd:
 
         // we should check appropriate privilege if OpenForBackup requested
         if(OpenForBackup) {
-            RC = SeSinglePrivilegeCheck(SeExports->SeBackupPrivilege, UserMode);
-            if(!NT_SUCCESS(RC))
-                try_return(RC);
+            if (!SeSinglePrivilegeCheck(SeExports->SeBackupPrivilege, UserMode)) {
+                try_return(RC = STATUS_PRIVILEGE_NOT_HELD);
+            }
         }
 
         // The FSD might wish to implement the open-by-id option. The "id"