[ros-diffs] [reactos] 01/01: [WIN32K:menu] Use signed types for negative values... CORE-16306

[Mark Jansen]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e1984d03b4bafa72e89ea…

commit e1984d03b4bafa72e89ea9948af8d9f28b79b2ac
Author:     Mark Jansen <mark.jansen(a)reactos.org>
AuthorDate: Mon Sep 30 23:15:20 2019 +0200
Commit:     Mark Jansen <mark.jansen(a)reactos.org>
CommitDate: Sat Oct 12 16:19:58 2019 +0200

    [WIN32K:menu] Use signed types for negative values...
    CORE-16306
---
 win32ss/user/ntuser/menu.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/win32ss/user/ntuser/menu.c b/win32ss/user/ntuser/menu.c
index 17e31d6d13d..71a52b94b40 100644
--- a/win32ss/user/ntuser/menu.c
+++ b/win32ss/user/ntuser/menu.c
@@ -1480,7 +1480,8 @@ MENU_AdjustMenuItemRect(PMENU menu, PRECTL rect)
 static ITEM *MENU_FindItemByCoords( MENU *menu, POINT pt, UINT *pos )
 {
     ITEM *item;
-    UINT i, cx, cy;
+    UINT i;
+    INT cx, cy;
     RECT rect;
     PWND pWnd = ValidateHwndNoErr(menu->hWnd);
 
@@ -2938,7 +2939,7 @@ static BOOL MENU_MoveRect(UINT flags, INT* x, INT* y, INT width, INT
height, con
 static BOOL FASTCALL MENU_ShowPopup(PWND pwndOwner, PMENU menu, UINT id, UINT flags,
                               INT x, INT y, const RECT* pExclude)
 {
-    UINT width, height;
+    INT width, height;
     POINT ptx;
     PMONITOR monitor;
     PWND pWnd;
@@ -3410,7 +3411,7 @@ static PMENU FASTCALL MENU_ShowSubPopup(PWND WndOwner, PMENU Menu,
BOOL SelectFi
           RECT rc;
           rc.left   = Item->xItem;
           rc.top    = Item->yItem;
-          rc.right  = Item->cxItem; // Do this for now......
+          rc.right  = Item->cxItem;
           rc.bottom = Item->cyItem;
 
           MENU_AdjustMenuItemRect(Menu, &rc);