[ros-diffs] 01/01: [APITESTS] Add ShellStateTest

[Katayama Hirofumi MZ]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=12713b770972caf8a169e…

commit 12713b770972caf8a169e76ad3f37e9bdd0f7388
Author:     Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com>
AuthorDate: Sat Jun 2 11:05:52 2018 +0900
Commit:     Mark Jansen <mark.jansen(a)reactos.org>
CommitDate: Thu Jun 14 20:07:52 2018 +0200

    [APITESTS] Add ShellStateTest
---
 modules/rostests/apitests/shell32/CMakeLists.txt |   7 +-
 modules/rostests/apitests/shell32/ShellState.cpp | 219 +++++++++++++++++++++++
 modules/rostests/apitests/shell32/testlist.c     |   2 +
 3 files changed, 225 insertions(+), 3 deletions(-)

diff --git a/modules/rostests/apitests/shell32/CMakeLists.txt
b/modules/rostests/apitests/shell32/CMakeLists.txt
index ba7096b0c1..545d2cc26e 100644
--- a/modules/rostests/apitests/shell32/CMakeLists.txt
+++ b/modules/rostests/apitests/shell32/CMakeLists.txt
@@ -7,20 +7,21 @@ include_directories(${REACTOS_SOURCE_DIR}/sdk/lib/atl)
 
 list(APPEND SOURCE
     AddCommas.cpp
-    Control_RunDLLW.cpp
     CFSFolder.cpp
     CMyComputer.cpp
     CShellDesktop.cpp
     CShellLink.cpp
     CUserNotification.cpp
+    Control_RunDLLW.cpp
     IShellFolderViewCB.cpp
-    menu.cpp
     OpenAs_RunDLL.cpp
     PathResolve.cpp
     SHCreateFileExtractIconW.cpp
+    SHParseDisplayName.cpp
     ShellExecuteEx.cpp
+    ShellState.cpp
+    menu.cpp
     shelltest.cpp
-    SHParseDisplayName.cpp
     shelltest.h)
 
 add_executable(shell32_apitest
diff --git a/modules/rostests/apitests/shell32/ShellState.cpp
b/modules/rostests/apitests/shell32/ShellState.cpp
new file mode 100644
index 0000000000..94a4a38cff
--- /dev/null
+++ b/modules/rostests/apitests/shell32/ShellState.cpp
@@ -0,0 +1,219 @@
+/*
+ * PROJECT:         ReactOS API tests
+ * LICENSE:         LGPLv2.1+ - See COPYING.LIB in the top level directory
+ * PURPOSE:         Test for SHELLSTATE
+ * PROGRAMMERS:     Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com>
+ */
+#include "shelltest.h"
+
+#define NDEBUG
+#include <debug.h>
+#include <shellutils.h>
+#include <strsafe.h>
+
+/* [HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer] */
+/* The contents of RegValue ShellState. */
+typedef struct REGSHELLSTATE
+{
+    DWORD dwSize;
+    SHELLSTATE ss;
+} REGSHELLSTATE, *PREGSHELLSTATE;
+
+static void dump(const char *name, const void *ptr, size_t siz)
+{
+    char buf[256], sz[16];
+
+    StringCbCopyA(buf, sizeof(buf), name);
+    StringCbCatA(buf, sizeof(buf), ": ");
+
+    const BYTE *pb = reinterpret_cast<const BYTE *>(ptr);
+    while (siz--)
+    {
+        StringCbPrintfA(sz, sizeof(sz), "%02X ", *pb++);
+        StringCbCatA(buf, sizeof(buf), sz);
+    }
+
+    trace("%s\n", buf);
+}
+
+static int read_key(REGSHELLSTATE *prss)
+{
+    HKEY hKey;
+    LONG result;
+    DWORD cb;
+    static const LPCWSTR s_pszExplorer =
+        L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer";
+
+    memset(prss, 0, sizeof(*prss));
+
+    result = RegOpenKeyExW(HKEY_CURRENT_USER, s_pszExplorer, 0, KEY_READ, &hKey);
+    ok(result == ERROR_SUCCESS, "result was %ld\n", result);
+    ok(hKey != NULL, "hKey was NULL\n");
+
+    if (result != ERROR_SUCCESS || !hKey)
+    {
+        skip("RegOpenKeyEx failed: %ld\n", result);
+        return 1;
+    }
+
+    cb = sizeof(*prss);
+    result = RegQueryValueExW(hKey, L"ShellState", NULL, NULL,
reinterpret_cast<LPBYTE>(prss), &cb);
+    RegCloseKey(hKey);
+
+    ok(result == ERROR_SUCCESS, "result was %ld\n", result);
+    if (result != ERROR_SUCCESS)
+    {
+        skip("RegQueryValueEx failed: %ld\n", result);
+        return 2;
+    }
+
+    return 0;
+}
+
+static int dump_pss(SHELLSTATE *pss)
+{
+    dump("SHELLSTATE", pss, sizeof(*pss));
+    return 0;
+}
+
+START_TEST(ShellState)
+{
+    OSVERSIONINFO osinfo;
+    REGSHELLSTATE rss;
+    SHELLSTATE *pss;
+    SHELLFLAGSTATE FlagState;
+    LPBYTE pb;
+    int ret;
+
+    trace("GetVersion(): 0x%08lX", GetVersion());
+
+    osinfo.dwOSVersionInfoSize = sizeof(osinfo);
+    GetVersionEx(&osinfo);
+    trace("osinfo.dwMajorVersion: 0x%08lX\n", osinfo.dwMajorVersion);
+    trace("osinfo.dwMinorVersion: 0x%08lX\n", osinfo.dwMinorVersion);
+    trace("osinfo.dwBuildNumber: 0x%08lX\n", osinfo.dwBuildNumber);
+    trace("osinfo.dwPlatformId: 0x%08lX\n", osinfo.dwPlatformId);
+
+    trace("WINVER: 0x%04X\n", WINVER);
+    trace("_WIN32_WINNT: 0x%04X\n", _WIN32_WINNT);
+    trace("_WIN32_IE: 0x%04X\n", _WIN32_IE);
+    trace("NTDDI_VERSION: 0x%08X\n", NTDDI_VERSION);
+
+#ifdef _MSC_VER
+    trace("_MSC_VER: 0x%08X\n", int(_MSC_VER));
+#elif defined(__MINGW32__)
+    trace("__MINGW32__: 0x%08X\n", int(__MINGW32__));
+#elif defined(__clang__)
+    trace("__clang__: 0x%08X\n", int(__clang__));
+#else
+    #error Unknown compiler.
+#endif
+
+    ok(sizeof(REGSHELLSTATE) >= 0x24, "sizeof(REGSHELLSTATE) was %d\n",
(int)sizeof(REGSHELLSTATE));
+    trace("sizeof(SHELLSTATE): %d\n", (int)sizeof(SHELLSTATE));
+    trace("__alignof(SHELLSTATE): %d\n", (int)__alignof(SHELLSTATE));
+    trace("sizeof(SHELLFLAGSTATE): %d\n", (int)sizeof(SHELLFLAGSTATE));
+    trace("sizeof(CABINETSTATE): %d\n", (int)sizeof(CABINETSTATE));
+
+    pss = &rss.ss;
+    pb = reinterpret_cast<LPBYTE>(pss);
+
+    ret = read_key(&rss);
+    if (ret)
+    {
+        return;
+    }
+
+    dump_pss(pss);
+    ok(rss.dwSize >= 0x24, "rss.dwSize was %ld (0x%lX).\n", rss.dwSize,
rss.dwSize);
+
+#define DUMP_LONG(x) trace(#x ": 0x%08X\n", int(x));
+#define DUMP_BOOL(x) trace(#x ": %d\n", !!int(x));
+    DUMP_BOOL(pss->fShowAllObjects);
+    DUMP_BOOL(pss->fShowExtensions);
+    DUMP_BOOL(pss->fNoConfirmRecycle);
+    DUMP_BOOL(pss->fShowSysFiles);
+    DUMP_BOOL(pss->fShowCompColor);
+    DUMP_BOOL(pss->fDoubleClickInWebView);
+    DUMP_BOOL(pss->fDesktopHTML);
+    DUMP_BOOL(pss->fWin95Classic);
+    DUMP_BOOL(pss->fDontPrettyPath);
+    DUMP_BOOL(pss->fShowAttribCol);
+    DUMP_BOOL(pss->fMapNetDrvBtn);
+    DUMP_BOOL(pss->fShowInfoTip);
+    DUMP_BOOL(pss->fHideIcons);
+    DUMP_BOOL(pss->fWebView);
+    DUMP_BOOL(pss->fFilter);
+    DUMP_BOOL(pss->fShowSuperHidden);
+    DUMP_BOOL(pss->fNoNetCrawling);
+    DUMP_LONG(pss->lParamSort);
+    DUMP_LONG(pss->iSortDirection);
+    DUMP_LONG(pss->version);
+    DUMP_LONG(pss->lParamSort);
+    DUMP_LONG(pss->iSortDirection);
+    DUMP_LONG(pss->version);
+    DUMP_BOOL(pss->fSepProcess);
+    DUMP_BOOL(pss->fStartPanelOn);
+    DUMP_BOOL(pss->fShowStartPage);
+#if NTDDI_VERSION >= 0x06000000     // for future use
+    DUMP_BOOL(pss->fIconsOnly);
+    DUMP_BOOL(pss->fShowTypeOverlay);
+    DUMP_BOOL(pss->fShowStatusBar);
+#endif
+
+#define SSF_MASK \
+    (SSF_SHOWALLOBJECTS | SSF_SHOWEXTENSIONS | SSF_NOCONFIRMRECYCLE | \
+     SSF_SHOWCOMPCOLOR | SSF_DOUBLECLICKINWEBVIEW | SSF_DESKTOPHTML | \
+     SSF_WIN95CLASSIC | SSF_DONTPRETTYPATH | SSF_SHOWATTRIBCOL | \
+     SSF_MAPNETDRVBUTTON | SSF_SHOWINFOTIP | SSF_HIDEICONS)
+    // For future:
+    // SSF_AUTOCHECKSELECT, SSF_ICONSONLY, SSF_SHOWTYPEOVERLAY, SSF_SHOWSTATUSBAR
+
+    memset(&FlagState, 0, sizeof(FlagState));
+    SHGetSettings(&FlagState, SSF_MASK);
+
+#define CHECK_FLAG(x) ok(pss->x == FlagState.x, "FlagState.%s expected %d, was
%d\n", #x, (int)pss->x, (int)FlagState.x)
+    CHECK_FLAG(fShowAllObjects);
+    CHECK_FLAG(fShowExtensions);
+    CHECK_FLAG(fNoConfirmRecycle);
+    //CHECK_FLAG(fShowSysFiles);    // No use
+    CHECK_FLAG(fShowCompColor);
+    CHECK_FLAG(fDoubleClickInWebView);
+    CHECK_FLAG(fDesktopHTML);
+    CHECK_FLAG(fWin95Classic);
+    CHECK_FLAG(fDontPrettyPath);
+    CHECK_FLAG(fShowAttribCol);
+    CHECK_FLAG(fMapNetDrvBtn);
+    CHECK_FLAG(fShowInfoTip);
+    CHECK_FLAG(fHideIcons);
+#if NTDDI_VERSION >= 0x06000000     // for future use
+    CHECK_FLAG(fAutoCheckSelect);
+    CHECK_FLAG(fIconsOnly);
+#endif
+
+#if 1
+    #define DO_IT(x) x
+#else
+    #define DO_IT(x) do { trace(#x ";\n"); x; } while (0)
+#endif
+
+    DO_IT(memset(pss, 0, sizeof(*pss)));
+    DO_IT(pss->dwWin95Unused = 1);
+    ok(pb[4] == 0x01 || dump_pss(pss), "Unexpected pss ^\n");
+
+    DO_IT(memset(pss, 0, sizeof(*pss)));
+    DO_IT(pss->lParamSort = 1);
+    ok(pb[12] == 0x01 || dump_pss(pss), "Unexpected pss ^\n");
+
+    DO_IT(memset(pss, 0, sizeof(*pss)));
+    DO_IT(pss->iSortDirection = 0xDEADBEEF);
+    ok(*(UNALIGNED DWORD *)(pb + 16) == 0xDEADBEEF || dump_pss(pss), "Unexpected pss
^\n");
+
+    DO_IT(memset(pss, 0, sizeof(*pss)));
+    DO_IT(pss->version = 0xDEADBEEF);
+    ok(*(UNALIGNED DWORD *)(pb + 20) == 0xDEADBEEF || dump_pss(pss), "Unexpected pss
^\n");
+
+    DO_IT(memset(pss, 0, sizeof(*pss)));
+    DO_IT(pss->fSepProcess = TRUE);
+    ok(pb[28] == 0x01 || dump_pss(pss), "Unexpected pss ^\n");
+}
diff --git a/modules/rostests/apitests/shell32/testlist.c
b/modules/rostests/apitests/shell32/testlist.c
index 975b933f3f..b2e1b78876 100644
--- a/modules/rostests/apitests/shell32/testlist.c
+++ b/modules/rostests/apitests/shell32/testlist.c
@@ -16,6 +16,7 @@ extern void func_OpenAs_RunDLL(void);
 extern void func_PathResolve(void);
 extern void func_SHCreateFileExtractIconW(void);
 extern void func_ShellExecuteEx(void);
+extern void func_ShellState(void);
 extern void func_SHParseDisplayName(void);
 
 const struct test winetest_testlist[] =
@@ -33,6 +34,7 @@ const struct test winetest_testlist[] =
     { "PathResolve", func_PathResolve },
     { "SHCreateFileExtractIconW", func_SHCreateFileExtractIconW },
     { "ShellExecuteEx", func_ShellExecuteEx },
+    { "ShellState", func_ShellState },
     { "SHParseDisplayName", func_SHParseDisplayName },
     { 0, 0 }
 };