Author: akhaldi Date: Sat May 11 11:03:12 2013 New Revision: 58990
URL: http://svn.reactos.org/svn/reactos?rev=58990&view=rev Log: [FASTFAT] * Add some function annotations. * Fix several debug print specifiers. * Properly mark some unreferenced parameters as such.
Modified: trunk/reactos/drivers/filesystems/fastfat/blockdev.c trunk/reactos/drivers/filesystems/fastfat/create.c trunk/reactos/drivers/filesystems/fastfat/direntry.c trunk/reactos/drivers/filesystems/fastfat/dirwr.c trunk/reactos/drivers/filesystems/fastfat/fastio.c trunk/reactos/drivers/filesystems/fastfat/fat.c trunk/reactos/drivers/filesystems/fastfat/fcb.c trunk/reactos/drivers/filesystems/fastfat/finfo.c trunk/reactos/drivers/filesystems/fastfat/fsctl.c trunk/reactos/drivers/filesystems/fastfat/iface.c trunk/reactos/drivers/filesystems/fastfat/misc.c trunk/reactos/drivers/filesystems/fastfat/rw.c trunk/reactos/drivers/filesystems/fastfat/volume.c
Modified: trunk/reactos/drivers/filesystems/fastfat/blockdev.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/blockdev.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/blockdev.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -74,8 +74,8 @@ again: KeInitializeEvent (&event, NotificationEvent, FALSE);
- DPRINT ("VfatReadDisk(pDeviceObject %p, Offset %I64x, Length %d, Buffer %p)\n", - pDeviceObject, ReadOffset->QuadPart, ReadLength, Buffer); + DPRINT("VfatReadDisk(pDeviceObject %p, Offset %I64x, Length %u, Buffer %p)\n", + pDeviceObject, ReadOffset->QuadPart, ReadLength, Buffer);
DPRINT ("Building synchronous FSD Request...\n"); Irp = IoBuildSynchronousFsdRequest (IRP_MJ_READ, @@ -130,9 +130,9 @@
if (!NT_SUCCESS (Status)) { - DPRINT ("IO failed!!! VfatReadDisk : Error code: %x\n", Status); - DPRINT ("(pDeviceObject %p, Offset %I64x, Size %d, Buffer %p\n", - pDeviceObject, ReadOffset->QuadPart, ReadLength, Buffer); + DPRINT("IO failed!!! VfatReadDisk : Error code: %x\n", Status); + DPRINT("(pDeviceObject %p, Offset %I64x, Size %u, Buffer %p\n", + pDeviceObject, ReadOffset->QuadPart, ReadLength, Buffer); return (Status); } DPRINT ("Block request succeeded for %p\n", Irp); @@ -151,8 +151,8 @@ NTSTATUS Status; PVOID Buffer;
- DPRINT ("VfatReadDiskPartial(IrpContext %p, ReadOffset %I64x, ReadLength %d, BufferOffset %x, Wait %d)\n", - IrpContext, ReadOffset->QuadPart, ReadLength, BufferOffset, Wait); + DPRINT("VfatReadDiskPartial(IrpContext %p, ReadOffset %I64x, ReadLength %u, BufferOffset %u, Wait %u)\n", + IrpContext, ReadOffset->QuadPart, ReadLength, BufferOffset, Wait);
DPRINT ("Building asynchronous FSD Request...\n");
@@ -251,8 +251,8 @@ NTSTATUS Status; PVOID Buffer;
- DPRINT ("VfatWriteDiskPartial(IrpContext %p, WriteOffset %I64x, WriteLength %d, BufferOffset %x, Wait %d)\n", - IrpContext, WriteOffset->QuadPart, WriteLength, BufferOffset, Wait); + DPRINT("VfatWriteDiskPartial(IrpContext %p, WriteOffset %I64x, WriteLength %u, BufferOffset %x, Wait %u)\n", + IrpContext, WriteOffset->QuadPart, WriteLength, BufferOffset, Wait);
Buffer = (PCHAR)MmGetMdlVirtualAddress(IrpContext->Irp->MdlAddress) + BufferOffset;
Modified: trunk/reactos/drivers/filesystems/fastfat/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -196,7 +196,7 @@ UNICODE_STRING FileToFindUpcase; BOOLEAN WildCard;
- DPRINT ("FindFile(Parent %p, FileToFind '%wZ', DirIndex: %d)\n", + DPRINT ("FindFile(Parent %p, FileToFind '%wZ', DirIndex: %u)\n", Parent, FileToFindU, DirContext->DirIndex); DPRINT ("FindFile: Path %wZ\n",&Parent->PathNameU);
@@ -242,7 +242,7 @@ RtlCopyMemory(&DirContext->DirEntry, &rcFcb->entry, sizeof(DIR_ENTRY)); DirContext->StartIndex = rcFcb->startIndex; DirContext->DirIndex = rcFcb->dirIndex; - DPRINT("FindFile: new Name %wZ, DirIndex %d (%d)\n", + DPRINT("FindFile: new Name %wZ, DirIndex %u (%u)\n", &DirContext->LongNameU, DirContext->DirIndex, DirContext->StartIndex); Status = STATUS_SUCCESS; } @@ -309,8 +309,8 @@ vfatReleaseFCB(DeviceExt, rcFcb); } } - DPRINT("%d\n", DirContext->LongNameU.Length); - DPRINT("FindFile: new Name %wZ, DirIndex %d\n", + DPRINT("%u\n", DirContext->LongNameU.Length); + DPRINT("FindFile: new Name %wZ, DirIndex %u\n", &DirContext->LongNameU, DirContext->DirIndex);
if (Context)
Modified: trunk/reactos/drivers/filesystems/fastfat/direntry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/direntry.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/direntry.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -294,7 +294,7 @@ { if (dirMap == 0) { - DPRINT (" long name entry found at %d\n", DirContext->DirIndex); + DPRINT (" long name entry found at %u\n", DirContext->DirIndex); RtlZeroMemory(DirContext->LongNameU.Buffer, DirContext->LongNameU.MaximumLength); CheckSum = longNameEntry->alias_checksum; Valid = TRUE; @@ -416,6 +416,8 @@ ULONG DirIndex = DirContext->DirIndex;
FileOffset.u.HighPart = 0; + + UNREFERENCED_PARAMETER(First);
if (!vfatFCBIsRoot(pDirFcb)) {
Modified: trunk/reactos/drivers/filesystems/fastfat/dirwr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/dirwr.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/dirwr.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -37,7 +37,7 @@ dirIndex = pFcb->dirIndex; }
- DPRINT("updEntry dirIndex %d, PathName '%wZ'\n", dirIndex, &pFcb->PathNameU); + DPRINT("updEntry dirIndex %u, PathName '%wZ'\n", dirIndex, &pFcb->PathNameU);
if (vfatFCBIsRoot(pFcb) || (pFcb->Flags & (FCB_IS_FAT|FCB_IS_VOLUME))) { @@ -184,7 +184,7 @@ CcUnpinData(Context); } } - DPRINT("nbSlots %d nbFree %d, entry number %d\n", nbSlots, nbFree, *start); + DPRINT("nbSlots %u nbFree %u, entry number %u\n", nbSlots, nbFree, *start); return TRUE; }
@@ -228,7 +228,7 @@
/* nb of entry needed for long name+normal entry */ nbSlots = (DirContext.LongNameU.Length / sizeof(WCHAR) + 12) / 13 + 1; - DPRINT("NameLen= %d, nbSlots =%d\n", DirContext.LongNameU.Length / sizeof(WCHAR), nbSlots); + DPRINT("NameLen= %u, nbSlots =%u\n", DirContext.LongNameU.Length / sizeof(WCHAR), nbSlots); Buffer = ExAllocatePoolWithTag(NonPagedPool, (nbSlots - 1) * sizeof(FAT_DIR_ENTRY), TAG_VFAT); if (Buffer == NULL) { @@ -326,7 +326,7 @@ needLong = TRUE; } } - DPRINT("'%s', '%wZ', needTilde=%d, needLong=%d\n", + DPRINT("'%s', '%wZ', needTilde=%u, needLong=%u\n", aName, &DirContext.LongNameU, needTilde, needLong); memset(DirContext.DirEntry.Fat.ShortName, ' ', 11); for (i = 0; i < 8 && aName[i] && aName[i] != '.'; i++) @@ -653,7 +653,7 @@ ASSERT(pFcb->parentFcb);
DPRINT("delEntry PathName '%wZ'\n", &pFcb->PathNameU); - DPRINT("delete entry: %d to %d\n", pFcb->startIndex, pFcb->dirIndex); + DPRINT("delete entry: %u to %u\n", pFcb->startIndex, pFcb->dirIndex); Offset.u.HighPart = 0; for (i = pFcb->startIndex; i <= pFcb->dirIndex; i++) { @@ -716,7 +716,7 @@ StartIndex = pFcb->startIndex;
DPRINT("delEntry PathName '%wZ'\n", &pFcb->PathNameU); - DPRINT("delete entry: %d\n", StartIndex); + DPRINT("delete entry: %u\n", StartIndex); Offset.u.HighPart = 0; Offset.u.LowPart = (StartIndex * sizeof(FATX_DIR_ENTRY) / PAGE_SIZE) * PAGE_SIZE; if (!CcPinRead(pFcb->parentFcb->FileObject, &Offset, sizeof(FATX_DIR_ENTRY), TRUE,
Modified: trunk/reactos/drivers/filesystems/fastfat/fastio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fastio.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fastio.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -8,6 +8,8 @@
#define NDEBUG #include "vfat.h" + +static FAST_IO_CHECK_IF_POSSIBLE VfatFastIoCheckIfPossible;
static BOOLEAN NTAPI VfatFastIoCheckIfPossible(IN PFILE_OBJECT FileObject, @@ -19,24 +21,48 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - /* Prevent all Fast I/O requests */ - DPRINT("VfatFastIoCheckIfPossible(): returning FALSE.\n"); - return FALSE; -} + /* Prevent all Fast I/O requests */ + DPRINT("VfatFastIoCheckIfPossible(): returning FALSE.\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(CheckForReadOperation); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_READ VfatFastIoRead;
static BOOLEAN NTAPI VfatFastIoRead(IN PFILE_OBJECT FileObject, IN PLARGE_INTEGER FileOffset, - IN ULONG Length, + IN ULONG Length, IN BOOLEAN Wait, IN ULONG LockKey, OUT PVOID Buffer, - OUT PIO_STATUS_BLOCK IoStatus, + OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoRead()\n"); - return FALSE; -} + DPRINT("VfatFastIoRead()\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_WRITE VfatFastIoWrite;
static BOOLEAN NTAPI VfatFastIoWrite(IN PFILE_OBJECT FileObject, @@ -48,9 +74,21 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoWrite()\n"); - return FALSE; -} + DPRINT("VfatFastIoWrite()\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_QUERY_BASIC_INFO VfatFastIoQueryBasicInfo;
static BOOLEAN NTAPI VfatFastIoQueryBasicInfo(IN PFILE_OBJECT FileObject, @@ -59,9 +97,18 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoQueryBasicInfo()\n"); - return FALSE; -} + DPRINT("VfatFastIoQueryBasicInfo()\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_QUERY_STANDARD_INFO VfatFastIoQueryStandardInfo;
static BOOLEAN NTAPI VfatFastIoQueryStandardInfo(IN PFILE_OBJECT FileObject, @@ -70,9 +117,18 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoQueryStandardInfo\n"); - return FALSE; -} + DPRINT("VfatFastIoQueryStandardInfo\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_LOCK VfatFastIoLock;
static BOOLEAN NTAPI VfatFastIoLock(IN PFILE_OBJECT FileObject, @@ -85,9 +141,22 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoLock\n"); - return FALSE; -} + DPRINT("VfatFastIoLock\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(ProcessId); + UNREFERENCED_PARAMETER(Key); + UNREFERENCED_PARAMETER(FailImmediately); + UNREFERENCED_PARAMETER(ExclusiveLock); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_UNLOCK_SINGLE VfatFastIoUnlockSingle;
static BOOLEAN NTAPI VfatFastIoUnlockSingle(IN PFILE_OBJECT FileObject, @@ -98,9 +167,20 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoUnlockSingle\n"); - return FALSE; -} + DPRINT("VfatFastIoUnlockSingle\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(ProcessId); + UNREFERENCED_PARAMETER(Key); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_UNLOCK_ALL VfatFastIoUnlockAll;
static BOOLEAN NTAPI VfatFastIoUnlockAll(IN PFILE_OBJECT FileObject, @@ -108,9 +188,17 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoUnlockAll\n"); - return FALSE; -} + DPRINT("VfatFastIoUnlockAll\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(ProcessId); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_UNLOCK_ALL_BY_KEY VfatFastIoUnlockAllByKey;
static BOOLEAN NTAPI VfatFastIoUnlockAllByKey(IN PFILE_OBJECT FileObject, @@ -119,9 +207,18 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoUnlockAllByKey\n"); - return FALSE; -} + DPRINT("VfatFastIoUnlockAllByKey\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(ProcessId); + UNREFERENCED_PARAMETER(Key); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_DEVICE_CONTROL VfatFastIoDeviceControl;
static BOOLEAN NTAPI VfatFastIoDeviceControl(IN PFILE_OBJECT FileObject, @@ -134,28 +231,51 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoDeviceControl\n"); - return FALSE; -} + DPRINT("VfatFastIoDeviceControl\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(InputBuffer); + UNREFERENCED_PARAMETER(InputBufferLength); + UNREFERENCED_PARAMETER(OutputBuffer); + UNREFERENCED_PARAMETER(OutputBufferLength); + UNREFERENCED_PARAMETER(IoControlCode); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_ACQUIRE_FILE VfatAcquireFileForNtCreateSection;
static VOID NTAPI VfatAcquireFileForNtCreateSection(IN PFILE_OBJECT FileObject) { - DPRINT("VfatAcquireFileForNtCreateSection\n"); -} + DPRINT("VfatAcquireFileForNtCreateSection\n"); + UNREFERENCED_PARAMETER(FileObject); +} + +static FAST_IO_RELEASE_FILE VfatReleaseFileForNtCreateSection;
static VOID NTAPI VfatReleaseFileForNtCreateSection(IN PFILE_OBJECT FileObject) { - DPRINT("VfatReleaseFileForNtCreateSection\n"); -} + DPRINT("VfatReleaseFileForNtCreateSection\n"); + UNREFERENCED_PARAMETER(FileObject); +} + +static FAST_IO_DETACH_DEVICE VfatFastIoDetachDevice;
static VOID NTAPI VfatFastIoDetachDevice(IN PDEVICE_OBJECT SourceDevice, IN PDEVICE_OBJECT TargetDevice) { - DPRINT("VfatFastIoDetachDevice\n"); -} + DPRINT("VfatFastIoDetachDevice\n"); + UNREFERENCED_PARAMETER(SourceDevice); + UNREFERENCED_PARAMETER(TargetDevice); +} + +static FAST_IO_QUERY_NETWORK_OPEN_INFO VfatFastIoQueryNetworkOpenInfo;
static BOOLEAN NTAPI VfatFastIoQueryNetworkOpenInfo(IN PFILE_OBJECT FileObject, @@ -164,9 +284,18 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoQueryNetworkOpenInfo\n"); - return FALSE; -} + DPRINT("VfatFastIoQueryNetworkOpenInfo\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_ACQUIRE_FOR_MOD_WRITE VfatAcquireForModWrite;
static NTSTATUS NTAPI VfatAcquireForModWrite(IN PFILE_OBJECT FileObject, @@ -174,9 +303,17 @@ OUT PERESOURCE* ResourceToRelease, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatAcquireForModWrite\n"); - return STATUS_INVALID_DEVICE_REQUEST; -} + DPRINT("VfatAcquireForModWrite\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(EndingOffset); + UNREFERENCED_PARAMETER(ResourceToRelease); + UNREFERENCED_PARAMETER(DeviceObject); + + return STATUS_INVALID_DEVICE_REQUEST; +} + +static FAST_IO_MDL_READ VfatMdlRead;
static BOOLEAN NTAPI VfatMdlRead(IN PFILE_OBJECT FileObject, @@ -187,18 +324,36 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatMdlRead\n"); - return FALSE; -} + DPRINT("VfatMdlRead\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_MDL_READ_COMPLETE VfatMdlReadComplete;
static BOOLEAN NTAPI VfatMdlReadComplete(IN PFILE_OBJECT FileObject, IN PMDL MdlChain, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatMdlReadComplete\n"); - return FALSE; -} + DPRINT("VfatMdlReadComplete\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_PREPARE_MDL_WRITE VfatPrepareMdlWrite;
static BOOLEAN NTAPI VfatPrepareMdlWrite(IN PFILE_OBJECT FileObject, @@ -209,9 +364,20 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatPrepareMdlWrite\n"); - return FALSE; -} + DPRINT("VfatPrepareMdlWrite\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_MDL_WRITE_COMPLETE VfatMdlWriteComplete;
static BOOLEAN NTAPI VfatMdlWriteComplete(IN PFILE_OBJECT FileObject, @@ -219,9 +385,17 @@ IN PMDL MdlChain, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatMdlWriteComplete\n"); - return FALSE; -} + DPRINT("VfatMdlWriteComplete\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_READ_COMPRESSED VfatFastIoReadCompressed;
static BOOLEAN NTAPI VfatFastIoReadCompressed(IN PFILE_OBJECT FileObject, @@ -235,9 +409,23 @@ IN ULONG CompressedDataInfoLength, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoReadCompressed\n"); - return FALSE; -} + DPRINT("VfatFastIoReadCompressed\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(CompressedDataInfo); + UNREFERENCED_PARAMETER(CompressedDataInfoLength); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_WRITE_COMPRESSED VfatFastIoWriteCompressed;
static BOOLEAN NTAPI VfatFastIoWriteCompressed(IN PFILE_OBJECT FileObject, @@ -251,18 +439,39 @@ IN ULONG CompressedDataInfoLength, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatFastIoWriteCompressed\n"); - return FALSE; -} + DPRINT("VfatFastIoWriteCompressed\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(CompressedDataInfo); + UNREFERENCED_PARAMETER(CompressedDataInfoLength); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_MDL_READ_COMPLETE_COMPRESSED VfatMdlReadCompleteCompressed;
static BOOLEAN NTAPI VfatMdlReadCompleteCompressed(IN PFILE_OBJECT FileObject, IN PMDL MdlChain, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatMdlReadCompleteCompressed\n"); - return FALSE; -} + DPRINT("VfatMdlReadCompleteCompressed\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_MDL_WRITE_COMPLETE_COMPRESSED VfatMdlWriteCompleteCompressed;
static BOOLEAN NTAPI VfatMdlWriteCompleteCompressed(IN PFILE_OBJECT FileObject, @@ -270,9 +479,17 @@ IN PMDL MdlChain, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatMdlWriteCompleteCompressed\n"); - return FALSE; -} + DPRINT("VfatMdlWriteCompleteCompressed\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_QUERY_OPEN VfatFastIoQueryOpen;
static BOOLEAN NTAPI VfatFastIoQueryOpen(IN PIRP Irp, @@ -280,17 +497,31 @@ IN PDEVICE_OBJECT DeviceObject) { DPRINT("VfatFastIoQueryOpen\n"); - return FALSE; -} + + UNREFERENCED_PARAMETER(Irp); + UNREFERENCED_PARAMETER(NetworkInformation); + UNREFERENCED_PARAMETER(DeviceObject); + + return FALSE; +} + +static FAST_IO_RELEASE_FOR_MOD_WRITE VfatReleaseForModWrite;
static NTSTATUS NTAPI VfatReleaseForModWrite(IN PFILE_OBJECT FileObject, IN PERESOURCE ResourceToRelease, IN PDEVICE_OBJECT DeviceObject) { - DPRINT("VfatReleaseForModWrite\n"); - return STATUS_INVALID_DEVICE_REQUEST; -} + DPRINT("VfatReleaseForModWrite\n"); + + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(ResourceToRelease); + UNREFERENCED_PARAMETER(DeviceObject); + + return STATUS_INVALID_DEVICE_REQUEST; +} + +static FAST_IO_ACQUIRE_FOR_CCFLUSH VfatAcquireForCcFlush;
static NTSTATUS NTAPI VfatAcquireForCcFlush(IN PFILE_OBJECT FileObject, @@ -300,6 +531,8 @@
DPRINT("VfatAcquireForCcFlush\n");
+ UNREFERENCED_PARAMETER(DeviceObject); + /* Make sure it is not a volume lock */ ASSERT(!(Fcb->Flags & FCB_IS_VOLUME));
@@ -308,6 +541,8 @@
return STATUS_SUCCESS; } + +static FAST_IO_RELEASE_FOR_CCFLUSH VfatReleaseForCcFlush;
static NTSTATUS NTAPI VfatReleaseForCcFlush(IN PFILE_OBJECT FileObject, @@ -316,6 +551,8 @@ PVFATFCB Fcb = (PVFATFCB)FileObject->FsContext;
DPRINT("VfatReleaseForCcFlush\n"); + + UNREFERENCED_PARAMETER(DeviceObject);
/* Make sure it is not a volume lock */ ASSERT(!(Fcb->Flags & FCB_IS_VOLUME));
Modified: trunk/reactos/drivers/filesystems/fastfat/fat.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fat.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fat.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -148,7 +148,7 @@ Offset.QuadPart = ROUND_DOWN(i * 2, ChunkSize); if(!CcPinRead(DeviceExt->FATFileObject, &Offset, ChunkSize, 1, &Context, &BaseAddress)) { - DPRINT1("CcMapData(Offset %x, Length %d) failed\n", (ULONG)Offset.QuadPart, ChunkSize); + DPRINT1("CcMapData(Offset %x, Length %u) failed\n", (ULONG)Offset.QuadPart, ChunkSize); return STATUS_UNSUCCESSFUL; } Block = (PUSHORT)((ULONG_PTR)BaseAddress + (i * 2) % ChunkSize); @@ -202,7 +202,7 @@ Offset.QuadPart = 0; if(!CcPinRead(DeviceExt->FATFileObject, &Offset, DeviceExt->FatInfo.FATSectors * DeviceExt->FatInfo.BytesPerSector, 1, &Context, &BaseAddress)) { - DPRINT1("CcMapData(Offset %x, Length %d) failed\n", (ULONG)Offset.QuadPart, DeviceExt->FatInfo.FATSectors * DeviceExt->FatInfo.BytesPerSector); + DPRINT1("CcMapData(Offset %x, Length %u) failed\n", (ULONG)Offset.QuadPart, DeviceExt->FatInfo.FATSectors * DeviceExt->FatInfo.BytesPerSector); return STATUS_UNSUCCESSFUL; }
@@ -269,7 +269,7 @@ Offset.QuadPart = ROUND_DOWN(i * 4, ChunkSize); if(!CcPinRead(DeviceExt->FATFileObject, &Offset, ChunkSize, 1, &Context, &BaseAddress)) { - DPRINT1("CcMapData(Offset %x, Length %d) failed\n", (ULONG)Offset.QuadPart, ChunkSize); + DPRINT1("CcMapData(Offset %x, Length %u) failed\n", (ULONG)Offset.QuadPart, ChunkSize); return STATUS_UNSUCCESSFUL; } Block = (PULONG)((ULONG_PTR)BaseAddress + (i * 4) % ChunkSize); @@ -420,7 +420,7 @@ Offset.QuadPart = ROUND_DOWN(i * 4, ChunkSize); if(!CcMapData(DeviceExt->FATFileObject, &Offset, ChunkSize, 1, &Context, &BaseAddress)) { - DPRINT1("CcMapData(Offset %x, Length %d) failed\n", (ULONG)Offset.QuadPart, ChunkSize); + DPRINT1("CcMapData(Offset %x, Length %u) failed\n", (ULONG)Offset.QuadPart, ChunkSize); return STATUS_UNSUCCESSFUL; } Block = (PULONG)((ULONG_PTR)BaseAddress + (i * 4) % ChunkSize);
Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -532,6 +532,8 @@ { PVFATCCB newCCB;
+ UNREFERENCED_PARAMETER(vcb); + newCCB = ExAllocateFromNPagedLookasideList(&VfatGlobalData->CcbLookasideList); if (newCCB == NULL) { @@ -601,7 +603,7 @@ return status; }
- DPRINT (" Index:%d longName:%wZ\n", + DPRINT (" Index:%u longName:%wZ\n", DirContext.DirIndex, &DirContext.LongNameU);
Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -105,7 +105,7 @@ DPRINT ("FsdSetPositionInformation()\n");
DPRINT ("PositionInfo %p\n", PositionInfo); - DPRINT ("Setting position %d\n", PositionInfo->CurrentByteOffset.u.LowPart); + DPRINT ("Setting position %u\n", PositionInfo->CurrentByteOffset.u.LowPart);
FileObject->CurrentByteOffset.QuadPart = PositionInfo->CurrentByteOffset.QuadPart; @@ -303,7 +303,7 @@ PDEVICE_EXTENSION DeviceExt = DeviceObject->DeviceExtension; #endif
- DPRINT ("FsdSetDispositionInformation(<%wZ>, Delete %d)\n", &FCB->PathNameU, DispositionInfo->DeleteFile); + DPRINT ("FsdSetDispositionInformation(<%wZ>, Delete %u)\n", &FCB->PathNameU, DispositionInfo->DeleteFile);
ASSERT(DeviceExt != NULL); ASSERT(DeviceExt->FatInfo.BytesPerCluster != 0); @@ -605,7 +605,7 @@ ULONG NCluster; BOOLEAN AllocSizeChanged = FALSE;
- DPRINT("VfatSetAllocationSizeInformation(File <%wZ>, AllocationSize %d %d)\n", &Fcb->PathNameU, + DPRINT("VfatSetAllocationSizeInformation(File <%wZ>, AllocationSize %d %u)\n", &Fcb->PathNameU, AllocationSize->HighPart, AllocationSize->LowPart);
if (Fcb->Flags & FCB_IS_FATX_ENTRY)
Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -85,8 +85,8 @@ } PartitionInfoIsValid = TRUE; DPRINT("Partition Information:\n"); - DPRINT("StartingOffset %I64u\n", PartitionInfo.StartingOffset.QuadPart / 512); - DPRINT("PartitionLength %I64u\n", PartitionInfo.PartitionLength.QuadPart / 512); + DPRINT("StartingOffset %I64x\n", PartitionInfo.StartingOffset.QuadPart / 512); + DPRINT("PartitionLength %I64x\n", PartitionInfo.PartitionLength.QuadPart / 512); DPRINT("HiddenSectors %u\n", PartitionInfo.HiddenSectors); DPRINT("PartitionNumber %u\n", PartitionInfo.PartitionNumber); DPRINT("PartitionType %u\n", PartitionInfo.PartitionType); @@ -153,7 +153,7 @@ Boot->BytesPerSector != 2048 && Boot->BytesPerSector != 4096) { - DPRINT1("BytesPerSector %d\n", Boot->BytesPerSector); + DPRINT1("BytesPerSector %u\n", Boot->BytesPerSector); *RecognizedFS = FALSE; }
@@ -161,7 +161,7 @@ Boot->FATCount != 1 && Boot->FATCount != 2) { - DPRINT1("FATCount %d\n", Boot->FATCount); + DPRINT1("FATCount %u\n", Boot->FATCount); *RecognizedFS = FALSE; }
@@ -349,7 +349,7 @@ { return(Status); } - DPRINT("MountVfatdev %d, PAGE_SIZE = %d\n", DeviceExt->FatInfo.BytesPerCluster, PAGE_SIZE); + DPRINT("MountVfatdev %u, PAGE_SIZE = %d\n", DeviceExt->FatInfo.BytesPerCluster, PAGE_SIZE);
return(STATUS_SUCCESS); @@ -448,15 +448,15 @@ goto ByeBye; }
- DPRINT("BytesPerSector: %d\n", DeviceExt->FatInfo.BytesPerSector); - DPRINT("SectorsPerCluster: %d\n", DeviceExt->FatInfo.SectorsPerCluster); - DPRINT("FATCount: %d\n", DeviceExt->FatInfo.FATCount); - DPRINT("FATSectors: %d\n", DeviceExt->FatInfo.FATSectors); - DPRINT("RootStart: %d\n", DeviceExt->FatInfo.rootStart); - DPRINT("DataStart: %d\n", DeviceExt->FatInfo.dataStart); + DPRINT("BytesPerSector: %u\n", DeviceExt->FatInfo.BytesPerSector); + DPRINT("SectorsPerCluster: %u\n", DeviceExt->FatInfo.SectorsPerCluster); + DPRINT("FATCount: %u\n", DeviceExt->FatInfo.FATCount); + DPRINT("FATSectors: %u\n", DeviceExt->FatInfo.FATSectors); + DPRINT("RootStart: %u\n", DeviceExt->FatInfo.rootStart); + DPRINT("DataStart: %u\n", DeviceExt->FatInfo.dataStart); if (DeviceExt->FatInfo.FatType == FAT32) { - DPRINT("RootCluster: %d\n", DeviceExt->FatInfo.RootCluster); + DPRINT("RootCluster: %u\n", DeviceExt->FatInfo.RootCluster); }
switch (DeviceExt->FatInfo.FatType) @@ -875,7 +875,7 @@ break;
default: - DPRINT("VFAT FSC: MinorFunction %d\n", IrpContext->MinorFunction); + DPRINT("VFAT FSC: MinorFunction %u\n", IrpContext->MinorFunction); Status = STATUS_INVALID_DEVICE_REQUEST; break; }
Modified: trunk/reactos/drivers/filesystems/fastfat/iface.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/iface.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/iface.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -48,6 +48,8 @@ PDEVICE_OBJECT DeviceObject; UNICODE_STRING DeviceName = RTL_CONSTANT_STRING(L"\Fat"); NTSTATUS Status; + + UNREFERENCED_PARAMETER(RegistryPath);
Status = IoCreateDevice(DriverObject, sizeof(VFAT_GLOBAL_DATA),
Modified: trunk/reactos/drivers/filesystems/fastfat/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/misc.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/misc.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -212,6 +212,8 @@ return IrpContext; }
+static WORKER_THREAD_ROUTINE VfatDoRequest; + static VOID NTAPI VfatDoRequest (PVOID IrpContext) { InterlockedDecrement(&QueueCount); @@ -274,4 +276,3 @@ return STATUS_SUCCESS; }
-
Modified: trunk/reactos/drivers/filesystems/fastfat/rw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -139,7 +139,7 @@ ASSERT(IrpContext->FileObject->FsContext2 != NULL);
DPRINT("VfatReadFileData(DeviceExt %p, FileObject %p, " - "Length %d, ReadOffset 0x%I64x)\n", DeviceExt, + "Length %u, ReadOffset 0x%I64x)\n", DeviceExt, IrpContext->FileObject, Length, ReadOffset.QuadPart);
*LengthRead = 0; @@ -283,7 +283,7 @@ Status = NextCluster(DeviceExt, FirstCluster, &CurrentCluster, FALSE); } while (StartCluster + ClusterCount == CurrentCluster && NT_SUCCESS(Status) && Length > BytesDone); - DPRINT("start %08x, next %08x, count %d\n", + DPRINT("start %08x, next %08x, count %u\n", StartCluster, CurrentCluster, ClusterCount);
ExAcquireFastMutex(&Fcb->LastMutex); @@ -354,7 +354,7 @@ BytesPerSector = DeviceExt->FatInfo.BytesPerSector;
DPRINT("VfatWriteFileData(DeviceExt %p, FileObject %p, " - "Length %d, WriteOffset 0x%I64x), '%wZ'\n", DeviceExt, + "Length %u, WriteOffset 0x%I64x), '%wZ'\n", DeviceExt, IrpContext->FileObject, Length, WriteOffset.QuadPart, &Fcb->PathNameU);
@@ -491,7 +491,7 @@ Status = NextCluster(DeviceExt, FirstCluster, &CurrentCluster, FALSE); } while (StartCluster + ClusterCount == CurrentCluster && NT_SUCCESS(Status) && Length > BytesDone); - DPRINT("start %08x, next %08x, count %d\n", + DPRINT("start %08x, next %08x, count %u\n", StartCluster, CurrentCluster, ClusterCount);
ExAcquireFastMutex(&Fcb->LastMutex); @@ -583,7 +583,7 @@ }
- DPRINT("'%wZ', Offset: %d, Length %d\n", &Fcb->PathNameU, ByteOffset.u.LowPart, Length); + DPRINT("'%wZ', Offset: %u, Length %u\n", &Fcb->PathNameU, ByteOffset.u.LowPart, Length);
if (ByteOffset.u.HighPart && !(Fcb->Flags & FCB_IS_VOLUME)) { @@ -600,7 +600,7 @@ { if (ByteOffset.u.LowPart % BytesPerSector != 0 || Length % BytesPerSector != 0) { - DPRINT("%d %d\n", ByteOffset.u.LowPart, Length); + DPRINT("%u %u\n", ByteOffset.u.LowPart, Length); // non cached read must be sector aligned Status = STATUS_INVALID_PARAMETER; goto ByeBye; @@ -1043,4 +1043,3 @@ return Status; }
-
Modified: trunk/reactos/drivers/filesystems/fastfat/volume.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat... ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/volume.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/volume.c [iso-8859-1] Sat May 11 11:03:12 2013 @@ -411,7 +411,7 @@ SystemBuffer = IrpContext->Irp->AssociatedIrp.SystemBuffer;
DPRINT ("FsInformationClass %d\n", FsInformationClass); - DPRINT ("BufferLength %d\n", BufferLength); + DPRINT ("BufferLength %u\n", BufferLength); DPRINT ("SystemBuffer %p\n", SystemBuffer);
switch(FsInformationClass)