[ros-diffs] [tfaber] 62566: [CMAKE] - Remove unnecessary allow_warnings throughout the code base - Make -Wnarrowing an error unless excepted specifically (only done in explorer)

Author: tfaber
Date: Wed Mar 26 11:08:45 2014
New Revision: 62566

URL: http://svn.reactos.org/svn/reactos?rev=62566&view=rev
Log:
[CMAKE]
- Remove unnecessary allow_warnings throughout the code base
- Make -Wnarrowing an error unless excepted specifically (only done in explorer)

Modified:
    trunk/reactos/base/applications/atactl/CMakeLists.txt
    trunk/reactos/base/applications/write/CMakeLists.txt
    trunk/reactos/base/shell/explorer/CMakeLists.txt
    trunk/reactos/cmake/gcc.cmake
    trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt
    trunk/reactos/dll/win32/mciseq/CMakeLists.txt
    trunk/reactos/dll/win32/mciwave/CMakeLists.txt
    trunk/reactos/drivers/bluetooth/fbtusb/CMakeLists.txt
    trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt
    trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt
    trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt
    trunk/reactos/lib/3rdparty/libmpg123/CMakeLists.txt
    trunk/reactos/lib/drivers/lwip/CMakeLists.txt
    trunk/reactos/lib/fslib/ext2lib/CMakeLists.txt
    trunk/reactos/lib/pseh/CMakeLists.txt
    trunk/reactos/lib/rossym_new/CMakeLists.txt
    trunk/reactos/lib/sdk/crt/msvcrtex.cmake
    trunk/reactos/win32ss/drivers/miniport/vga_new/CMakeLists.txt

Modified: trunk/reactos/base/applications/atactl/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/atactl/C…
==============================================================================
--- trunk/reactos/base/applications/atactl/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/base/applications/atactl/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45
2014
@@ -7,10 +7,4 @@
 set_module_type(atactl win32cui)
 add_importlibs(atactl advapi32 msvcrt kernel32 ntdll)
 
-if(NOT MSVC)
-    # FIXME: http://www.cmake.org/Bug/view.php?id=12998
-    #allow_warnings(atactl)
-    set_source_files_properties(atactl.cpp PROPERTIES COMPILE_FLAGS
"-Wno-error")
-endif()
-
 add_cd_file(TARGET atactl DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/base/applications/write/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/write/CM…
==============================================================================
--- trunk/reactos/base/applications/write/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/base/applications/write/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45
2014
@@ -3,9 +3,3 @@
 set_module_type(write win32gui UNICODE)
 add_importlibs(write user32 gdi32 msvcrt kernel32)
 add_cd_file(TARGET write DESTINATION reactos/system32 FOR all)
-
-if(NOT MSVC)
-    # FIXME: http://www.cmake.org/Bug/view.php?id=12998
-    #allow_warnings(write)
-    set_source_files_properties(write.c PROPERTIES COMPILE_FLAGS "-Wno-error")
-endif()

Modified: trunk/reactos/base/shell/explorer/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/CMakeL…
==============================================================================
--- trunk/reactos/base/shell/explorer/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/base/shell/explorer/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45
2014
@@ -60,3 +60,7 @@
 add_dependencies(explorer psdk)
 add_cd_file(TARGET explorer DESTINATION reactos FOR all)
 add_cd_file(FILE ${CMAKE_CURRENT_SOURCE_DIR}/explorer-cfg-template.xml DESTINATION
reactos FOR all)
+
+if(NOT MSVC)
+    add_compile_flags("-Wno-error=narrowing")
+endif()

Modified: trunk/reactos/cmake/gcc.cmake
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=62566&…
==============================================================================
--- trunk/reactos/cmake/gcc.cmake	[iso-8859-1] (original)
+++ trunk/reactos/cmake/gcc.cmake	[iso-8859-1] Wed Mar 26 11:08:45 2014
@@ -85,7 +85,6 @@
     add_compile_flags("-Wno-error=unused-but-set-variable")
 endif()
 
-add_compile_flags("-Wno-error=narrowing")
 add_compile_flags("-Wtype-limits -Wno-error=type-limits")
 
 if(ARCH STREQUAL "amd64")

Modified: trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libxslt/CMake…
==============================================================================
--- trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45
2014
@@ -49,5 +49,4 @@
 
 if(NOT MSVC)
     add_target_compile_flags(libxslt "-Wno-pointer-sign -Wno-unused-but-set-variable
-Wno-unused-function")
-    allow_warnings(libxslt)
 endif()

Modified: trunk/reactos/dll/win32/mciseq/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mciseq/CMakeList…
==============================================================================
--- trunk/reactos/dll/win32/mciseq/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/win32/mciseq/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45 2014
@@ -15,5 +15,5 @@
 add_cd_file(TARGET mciseq DESTINATION reactos/system32 FOR all)
 
 if(NOT MSVC)
-    allow_warnings(mciseq)
+    add_target_compile_flags(mciseq "-Wno-error=overflow")
 endif()

Modified: trunk/reactos/dll/win32/mciwave/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mciwave/CMakeLis…
==============================================================================
--- trunk/reactos/dll/win32/mciwave/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/win32/mciwave/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45 2014
@@ -21,5 +21,5 @@
 add_cd_file(TARGET mciwave DESTINATION reactos/system32 FOR all)
 
 if(NOT MSVC)
-    allow_warnings(mciwave)
+    add_target_compile_flags(mciwave "-Wno-error=overflow")
 endif()

Modified: trunk/reactos/drivers/bluetooth/fbtusb/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bluetooth/fbtusb/C…
==============================================================================
--- trunk/reactos/drivers/bluetooth/fbtusb/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/bluetooth/fbtusb/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45
2014
@@ -12,10 +12,8 @@
 
 add_library(fbtusb SHARED ${SOURCE} fbtusb.rc)
 
-# FIXME: http://www.cmake.org/Bug/view.php?id=12998
 if(NOT MSVC)
-    #allow_warnings(fbtusb)
-    set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error
-Wno-unused-but-set-variable")
+    set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS
"-Wno-unused-but-set-variable")
 endif()
 
 set_module_type(fbtusb kernelmodedriver)

Modified: trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/C…
==============================================================================
--- trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45
2014
@@ -28,7 +28,6 @@
     add_compile_flags("-Wno-unused-but-set-variable")
 endif()
 
-allow_warnings(ext2fs)
 target_link_libraries(ext2fs ${PSEH_LIB})
 add_pch(ext2fs inc/ext2fsd.h SOURCE)
 set_module_type(ext2fs kernelmodedriver)

Modified: trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/uniata…
==============================================================================
--- trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt	[iso-8859-1] Wed Mar 26
11:08:45 2014
@@ -22,9 +22,7 @@
 
 
 if(NOT MSVC)
-    # FIXME: http://www.cmake.org/Bug/view.php?id=12998
-    #allow_warnings(uniata)
-    set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error
-Wno-unused-but-set-variable -Wno-narrowing")
+    set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS
"-Wno-unused-but-set-variable -Wno-narrowing")
 endif()
 
 add_pch(uniata stdafx.h SOURCE)

Modified: trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/fullfat/CMake…
==============================================================================
--- trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45
2014
@@ -17,7 +17,6 @@
     ff_time.c)
 
 add_library(fullfat ${SOURCE})
-allow_warnings(fullfat)
 add_dependencies(fullfat bugcodes)
 
 if(NOT MSVC)

Modified: trunk/reactos/lib/3rdparty/libmpg123/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libmpg123/CMa…
==============================================================================
--- trunk/reactos/lib/3rdparty/libmpg123/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/3rdparty/libmpg123/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45
2014
@@ -44,4 +44,3 @@
 add_library(libmpg123 ${SOURCE})
 add_dependencies(libmpg123 psdk)
 add_pch(libmpg123 precomp.h SOURCE)
-allow_warnings(libmpg123)

Modified: trunk/reactos/lib/drivers/lwip/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/lwip/CMakeList…
==============================================================================
--- trunk/reactos/lib/drivers/lwip/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/drivers/lwip/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45 2014
@@ -61,7 +61,6 @@
 add_dependencies(lwip bugcodes)
 add_pch(lwip precomp.h SOURCE)
 if(NOT MSVC)
-    allow_warnings(lwip)
     if(LTCG)
         add_compile_flags("-fno-builtin-malloc -fno-builtin-free")
     endif()

Modified: trunk/reactos/lib/fslib/ext2lib/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fslib/ext2lib/CMakeLis…
==============================================================================
--- trunk/reactos/lib/fslib/ext2lib/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/fslib/ext2lib/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45 2014
@@ -14,4 +14,3 @@
 add_library(ext2lib ${SOURCE})
 add_pch(ext2lib Mke2fs.h SOURCE)
 add_dependencies(ext2lib psdk)
-allow_warnings(ext2lib)

Modified: trunk/reactos/lib/pseh/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/pseh/CMakeLists.txt?re…
==============================================================================
--- trunk/reactos/lib/pseh/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/pseh/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45 2014
@@ -20,7 +20,6 @@
     endif()
 
     add_library(pseh ${SOURCE})
-    allow_warnings(pseh)
     target_link_libraries(pseh chkstk)
     add_dependencies(pseh psdk)
 

Modified: trunk/reactos/lib/rossym_new/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym_new/CMakeLists.…
==============================================================================
--- trunk/reactos/lib/rossym_new/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/lib/rossym_new/CMakeLists.txt	[iso-8859-1] Wed Mar 26 11:08:45 2014
@@ -19,4 +19,3 @@
 add_library(rossym ${SOURCE})
 add_pch(rossym precomp.h)
 add_dependencies(rossym psdk bugcodes)
-allow_warnings(rossym)

Modified: trunk/reactos/lib/sdk/crt/msvcrtex.cmake
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/msvcrtex.cmake…
==============================================================================
--- trunk/reactos/lib/sdk/crt/msvcrtex.cmake	[iso-8859-1] (original)
+++ trunk/reactos/lib/sdk/crt/msvcrtex.cmake	[iso-8859-1] Wed Mar 26 11:08:45 2014
@@ -83,7 +83,6 @@
 
 if(NOT MSVC)
     target_link_libraries(msvcrtex oldnames)
-    allow_warnings(msvcrtex)
 endif()
 
 add_dependencies(msvcrtex psdk asm)

Modified: trunk/reactos/win32ss/drivers/miniport/vga_new/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/miniport/v…
==============================================================================
--- trunk/reactos/win32ss/drivers/miniport/vga_new/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/win32ss/drivers/miniport/vga_new/CMakeLists.txt	[iso-8859-1] Wed Mar 26
11:08:45 2014
@@ -13,12 +13,6 @@
 
 target_link_libraries(vga libcntpr)
 
-# FIXME: http://www.cmake.org/Bug/view.php?id=12998
-if(NOT MSVC)
-    #allow_warnings(vga)
-    set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS
"-Wno-error")
-endif()
-
 set_module_type(vga kernelmodedriver)
 add_importlibs(vga videoprt)