[ros-diffs] [spetreolle] 59015: [RUNDLL32] Rundll32 always returns 0. Mike McCormack (mike at codeweavers dot com)

Author: spetreolle
Date: Wed May 15 12:41:25 2013
New Revision: 59015

URL: http://svn.reactos.org/svn/reactos?rev=59015&view=rev
Log:
[RUNDLL32]
Rundll32 always returns 0.
Mike McCormack (mike at codeweavers dot com)

Modified:
    trunk/reactos/base/system/rundll32/rundll32.c

Modified: trunk/reactos/base/system/rundll32/rundll32.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/rundll32/rundl…
==============================================================================
--- trunk/reactos/base/system/rundll32/rundll32.c	[iso-8859-1] (original)
+++ trunk/reactos/base/system/rundll32/rundll32.c	[iso-8859-1] Wed May 15 12:41:25 2013
@@ -343,7 +343,7 @@
     DllWinMainW fnDllWinMainW;
     DllWinMainA fnDllWinMainA;
     HWND hWindow;
-    int nRetVal,i;
+    int i;
     size_t nStrLen;
 
     // Get command-line in argc-argv format
@@ -380,8 +380,6 @@
         lptCmdLine = argv[i];
     else
         lptCmdLine = _T("");
-
-    nRetVal = 0;
 
     // Everything is all setup, so load the dll now
     hDll = LoadLibrary(lptDllName);
@@ -439,13 +437,13 @@
         if (fnDllWinMainW) {
             // Convert the command-line string to unicode and call the dll function
             lpwCmdLine = ConvertToWideChar(lptCmdLine);
-            nRetVal = fnDllWinMainW(hWindow,hInstance,lpwCmdLine,nCmdShow);
+            fnDllWinMainW(hWindow,hInstance,lpwCmdLine,nCmdShow);
             FreeConvertedWideChar(lpwCmdLine);
         }
         else if (fnDllWinMainA) {
             // Convert the command-line string to ansi and call the dll function
             lpaCmdLine = ConvertToMultiByte(lptCmdLine);
-            nRetVal = fnDllWinMainA(hWindow,hInstance,lpaCmdLine,nCmdShow);
+            fnDllWinMainA(hWindow,hInstance,lpaCmdLine,nCmdShow);
             FreeConvertedMultiByte(lpaCmdLine);
         }
         else {
@@ -478,6 +476,6 @@
     }
 
     if (argv) free(argv);
-    return nRetVal;
-}
-
+    return 0; /* rundll32 always returns 0! */
+}
+