[ros-diffs] [ion] 52754: [KERNEL32]: Winesync all there is to Winesync in ReactOS' kernel32. This mainly affects LZ*, Comm*, *ProfileString* (INI), and *Resource* APIs, however the changes in there are relativ...

Author: ion
Date: Thu Jul 21 05:24:59 2011
New Revision: 52754

URL: http://svn.reactos.org/svn/reactos?rev=52754&view=rev
Log:
[KERNEL32]: Winesync all there is to Winesync in ReactOS' kernel32. This mainly
affects LZ*, Comm*, *ProfileString* (INI), and *Resource* APIs, however the changes in
there are relatively minor. More substantial changes affect the locale/NLS/language
functions, many which were bitrotting for 6+ years.
In theory, this code is "better" than before, and it is closer to Wine (which
arguably has better compatibility). It also resets things in sync with Wine however, and
may lose and "fixes" ReactOS may have added over the years. But this is a good
thing, since these fixes have been "lost" (they obviously never made it into
Wine), and if regressions are now found due to this, actual upstream patches can be sent
and picked up on the next sync. This avoids maintaining duplicate code, at the expenses of
some potential short-term regressions in i18n.
Finally, note that much of /string seems to be taken from Wine's Unicode library
(which a host "unicode" already exists in ReactOS' tools/. It may be better
(for someone with more experience as to these wine-isms) to simply just pull-in whatever
winelib files are not currently present in ReactOS, and have kernel32 and tools/unicode
use winelib, instead of having 2 or 3 copies of the code.

Modified:
    trunk/reactos/dll/win32/kernel32/client/misc/comm.c
    trunk/reactos/dll/win32/kernel32/client/misc/commdcb.c
    trunk/reactos/dll/win32/kernel32/client/misc/lzexpand.c
    trunk/reactos/dll/win32/kernel32/client/misc/profile.c
    trunk/reactos/dll/win32/kernel32/client/misc/res.c
    trunk/reactos/dll/win32/kernel32/winnls/string/casemap.c
    trunk/reactos/dll/win32/kernel32/winnls/string/chartype.c
    trunk/reactos/dll/win32/kernel32/winnls/string/collation.c
    trunk/reactos/dll/win32/kernel32/winnls/string/format_msg.c
    trunk/reactos/dll/win32/kernel32/winnls/string/lang.c
    trunk/reactos/dll/win32/kernel32/winnls/string/lcformat.c
    trunk/reactos/dll/win32/kernel32/winnls/string/nls.c
    trunk/reactos/dll/win32/kernel32/winnls/string/sortkey.c

[This mail would be too long, it was shortened to contain the URLs only.]

Modified: trunk/reactos/dll/win32/kernel32/client/misc/comm.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…

Modified: trunk/reactos/dll/win32/kernel32/client/misc/commdcb.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…

Modified: trunk/reactos/dll/win32/kernel32/client/misc/lzexpand.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…

Modified: trunk/reactos/dll/win32/kernel32/client/misc/profile.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…

Modified: trunk/reactos/dll/win32/kernel32/client/misc/res.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…

Modified: trunk/reactos/dll/win32/kernel32/winnls/string/casemap.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/winnls/…

Modified: trunk/reactos/dll/win32/kernel32/winnls/string/chartype.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/winnls/…

Modified: trunk/reactos/dll/win32/kernel32/winnls/string/collation.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/winnls/…

Modified: trunk/reactos/dll/win32/kernel32/winnls/string/format_msg.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/winnls/…

Modified: trunk/reactos/dll/win32/kernel32/winnls/string/lang.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/winnls/…

Modified: trunk/reactos/dll/win32/kernel32/winnls/string/lcformat.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/winnls/…

Modified: trunk/reactos/dll/win32/kernel32/winnls/string/nls.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/winnls/…

Modified: trunk/reactos/dll/win32/kernel32/winnls/string/sortkey.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/winnls/…