[ros-diffs] [apriyadarshi] 71988: Fixed SrbExtension == NULL bug! :D

Author: apriyadarshi
Date: Sun Jul 24 12:41:07 2016
New Revision: 71988

URL: http://svn.reactos.org/svn/reactos?rev=71988&view=rev
Log:
Fixed SrbExtension == NULL bug! :D

Modified:
    branches/GSoC_2016/AHCI/drivers/storage/storahci/storahci.c

Modified: branches/GSoC_2016/AHCI/drivers/storage/storahci/storahci.c
URL:
http://svn.reactos.org/svn/reactos/branches/GSoC_2016/AHCI/drivers/storage/…
==============================================================================
--- branches/GSoC_2016/AHCI/drivers/storage/storahci/storahci.c	[iso-8859-1] (original)
+++ branches/GSoC_2016/AHCI/drivers/storage/storahci/storahci.c	[iso-8859-1] Sun Jul 24
12:41:07 2016
@@ -420,6 +420,7 @@
 
     StorPortAcquireSpinLock(AdapterExtension, InterruptLock, NULL, &lockhandle);
     Srb = RemoveQueue(&PortExtension->CompletionQueue);
+    StorPortReleaseSpinLock(AdapterExtension, &lockhandle);
 
     NT_ASSERT(Srb != NULL);
 
@@ -427,22 +428,21 @@
     {
         Srb->SrbStatus = SRB_STATUS_SUCCESS;
     }
+    else
+    {
+        return;
+    }
 
     SrbExtension = GetSrbExtension(Srb);
+
     CompletionRoutine = SrbExtension->CompletionRoutine;
-
-    if (CompletionRoutine != NULL)
-    {
-        // now it's completion routine responsibility to set SrbStatus
-        CompletionRoutine(PortExtension, Srb);
-    }
-    else
-    {
-        Srb->SrbStatus = SRB_STATUS_SUCCESS;
-        //StorPortNotification(RequestComplete, AdapterExtension, Srb);
-    }
-
-    StorPortReleaseSpinLock(AdapterExtension, &lockhandle);
+    NT_ASSERT(CompletionRoutine != NULL);
+
+    // now it's completion routine responsibility to set SrbStatus
+    CompletionRoutine(PortExtension, Srb);
+
+    StorPortNotification(RequestComplete, AdapterExtension, Srb);
+
     return;
 }// -- AhciCommandCompletionDpcRoutine();
 
@@ -537,6 +537,7 @@
 {
     ULONG NCS, i;
     PSCSI_REQUEST_BLOCK Srb;
+    PAHCI_SRB_EXTENSION SrbExtension;
     PAHCI_ADAPTER_EXTENSION AdapterExtension;
 
     AhciDebugPrint("AhciCompleteIssuedSrb()\n");
@@ -553,10 +554,25 @@
         if (((1 << i) & CommandsToComplete) != 0)
         {
             Srb = PortExtension->Slot[i];
-            NT_ASSERT(Srb != NULL);
-
-            AddQueue(&PortExtension->CompletionQueue, Srb);
-            StorPortIssueDpc(AdapterExtension, &PortExtension->CommandCompletion,
PortExtension, Srb);
+
+            if (Srb == NULL)
+            {
+                continue;
+            }
+
+            SrbExtension = GetSrbExtension(Srb);
+            NT_ASSERT(SrbExtension != NULL);
+
+            if (SrbExtension->CompletionRoutine != NULL)
+            {
+                AddQueue(&PortExtension->CompletionQueue, Srb);
+                StorPortIssueDpc(AdapterExtension,
&PortExtension->CommandCompletion, PortExtension, Srb);
+            }
+            else
+            {
+                Srb->SrbStatus = SRB_STATUS_SUCCESS;
+                StorPortNotification(RequestComplete, AdapterExtension, Srb);
+            }
         }
     }
 
@@ -748,7 +764,6 @@
         return TRUE;
     }
 
-    AhciDebugPrint("\tPathId: %d Function: %x\n", Srb->PathId,
Srb->Function);
     switch(Srb->Function)
     {
         case SRB_FUNCTION_PNP:
@@ -844,7 +859,10 @@
             break;
     }
 
-    StorPortNotification(RequestComplete, AdapterExtension, Srb);
+    if (Srb->SrbStatus != SRB_STATUS_PENDING)
+    {
+        StorPortNotification(RequestComplete, AdapterExtension, Srb);
+    }
     return TRUE;
 }// -- AhciHwStartIo();
 
@@ -1054,7 +1072,6 @@
     ConfigInfo->NumberOfPhysicalBreaks = 0x21;
     ConfigInfo->MaximumNumberOfLogicalUnits = 1;
     ConfigInfo->NumberOfBuses = MAXIMUM_AHCI_PORT_COUNT;
-    ConfigInfo->MapBuffers = STOR_MAP_NON_READ_WRITE_BUFFERS;
     ConfigInfo->MaximumTransferLength = MAXIMUM_TRANSFER_LENGTH;
     ConfigInfo->SynchronizationModel = StorSynchronizeFullDuplex;
 
@@ -1396,7 +1413,6 @@
     )
 {
     AHCI_PORT_CMD cmd;
-    ULONG sact, ci;
     ULONG QueueSlots, slotToActivate, tmp;
     PAHCI_ADAPTER_EXTENSION AdapterExtension;
 
@@ -1418,9 +1434,6 @@
     {
         return;
     }
-
-    sact = StorPortReadRegisterUlong(AdapterExtension,
&PortExtension->Port->SACT);
-    ci = StorPortReadRegisterUlong(AdapterExtension,
&PortExtension->Port->CI);
 
     // get the lowest set bit
     tmp = QueueSlots & (QueueSlots - 1);
@@ -1703,6 +1716,8 @@
     DataTransferLength = Srb->DataTransferLength;
     BytesPerSector = PortExtension->DeviceParams.BytesPerLogicalSector;
 
+    NT_ASSERT(BytesPerSector > 0);
+
     ROUND_UP(DataTransferLength, BytesPerSector);
 
     SectorCount = DataTransferLength / BytesPerSector;
@@ -1712,7 +1727,7 @@
     NT_ASSERT(SectorCount > 0);
 
     SrbExtension->AtaFunction = ATA_FUNCTION_ATA_READ;
-    SrbExtension->Flags = ATA_FLAGS_USE_DMA;
+    SrbExtension->Flags |= ATA_FLAGS_USE_DMA;
     SrbExtension->CompletionRoutine = NULL;
 
     if (IsReading)