[ros-diffs] [hbelusca] 64696: [fast486]: code formatting + add a comment about the instruction 0xF1.

Author: hbelusca
Date: Sun Oct 12 13:50:05 2014
New Revision: 64696

URL: http://svn.reactos.org/svn/reactos?rev=64696&view=rev
Log:
[fast486]: code formatting + add a comment about the instruction 0xF1.

Modified:
    trunk/reactos/lib/fast486/common.c
    trunk/reactos/lib/fast486/extraops.c
    trunk/reactos/lib/fast486/fpu.c
    trunk/reactos/lib/fast486/opcodes.c

Modified: trunk/reactos/lib/fast486/common.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/common.c?rev=6…
==============================================================================
--- trunk/reactos/lib/fast486/common.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/fast486/common.c	[iso-8859-1] Sun Oct 12 13:50:05 2014
@@ -166,8 +166,6 @@
                     UCHAR Number,
                     PFAST486_IDT_ENTRY IdtEntry)
 {
-    ULONG FarPointer;
-
     /* Check for protected mode */
     if (State->ControlRegisters[FAST486_REG_CR0] & FAST486_CR0_PE)
     {
@@ -185,6 +183,7 @@
     else
     {
         /* Read from the real-mode IVT */
+        ULONG FarPointer;
 
         /* Paging is always disabled in real mode */
         State->MemReadCallback(State,
@@ -215,9 +214,9 @@
     USHORT SegmentSelector = IdtEntry->Selector;
     ULONG  Offset          = MAKELONG(IdtEntry->Offset, IdtEntry->OffsetHigh);
     ULONG  GateType        = IdtEntry->Type;
-
-    BOOLEAN GateSize = (GateType == FAST486_IDT_INT_GATE_32)
-                       || (GateType == FAST486_IDT_TRAP_GATE_32);
+    BOOLEAN GateSize = (GateType == FAST486_IDT_INT_GATE_32) ||
+                       (GateType == FAST486_IDT_TRAP_GATE_32);
+
     BOOLEAN Success = FALSE;
     ULONG OldPrefixFlags = State->PrefixFlags;
 

Modified: trunk/reactos/lib/fast486/extraops.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/extraops.c?rev…
==============================================================================
--- trunk/reactos/lib/fast486/extraops.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/fast486/extraops.c	[iso-8859-1] Sun Oct 12 13:50:05 2014
@@ -2267,9 +2267,9 @@
         ULONG Source, Destination, Result;
 
         if (!Fast486ReadModrmDwordOperands(State,
-                                          &ModRegRm,
-                                          &Source,
-                                          &Destination))
+                                           &ModRegRm,
+                                           &Source,
+                                           &Destination))
         {
             /* Exception occurred */
             return FALSE;

Modified: trunk/reactos/lib/fast486/fpu.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/fpu.c?rev=6469…
==============================================================================
--- trunk/reactos/lib/fast486/fpu.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/fast486/fpu.c	[iso-8859-1] Sun Oct 12 13:50:05 2014
@@ -125,7 +125,7 @@
     /* Find the largest exponent */
     TempResult.Exponent = max(FirstOperand->Exponent, SecondOperand->Exponent);
 
-    /* Adjust the first operand to it */
+    /* Adjust the first operand to it... */
     if (FirstAdjusted.Exponent < TempResult.Exponent)
     {
         FirstAdjusted.Mantissa >>= (TempResult.Exponent - FirstAdjusted.Exponent);

Modified: trunk/reactos/lib/fast486/opcodes.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/opcodes.c?rev=…
==============================================================================
--- trunk/reactos/lib/fast486/opcodes.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/fast486/opcodes.c	[iso-8859-1] Sun Oct 12 13:50:05 2014
@@ -279,7 +279,7 @@
     Fast486OpcodeOutByte,               /* 0xEE */
     Fast486OpcodeOut,                   /* 0xEF */
     Fast486OpcodePrefix,                /* 0xF0 */
-    Fast486OpcodeInvalid,               /* 0xF1 */  // Invalid opcode
+    Fast486OpcodeInvalid,               /* 0xF1 */  // Invalid opcode -- ICEBP/INT01
opcode
     Fast486OpcodePrefix,                /* 0xF2 */
     Fast486OpcodePrefix,                /* 0xF3 */
     Fast486OpcodeHalt,                  /* 0xF4 */
@@ -300,7 +300,12 @@
 
 FAST486_OPCODE_HANDLER(Fast486OpcodeInvalid)
 {
-    /* This is not a valid opcode */
+    /*
+     * This is not a valid opcode.
+     * Well, not totally: see http://www.rcollins.org/secrets/opcodes/ICEBP.html
+     * for more details.
+     */
+    DPRINT1("FAST486 -- Calling ICEBP opcode\n");
     Fast486Exception(State, FAST486_EXCEPTION_UD);
     return FALSE;
 }
@@ -5428,6 +5433,11 @@
 
 FAST486_OPCODE_HANDLER(Fast486OpcodeSalc)
 {
+    /*
+     * See: http://www.rcollins.org/secrets/opcodes/SALC.html
+     * for more information.
+     */
+
     /* Make sure this is the right instruction */
     ASSERT(Opcode == 0xD6);